68180 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Bartłomiej Dach	9c22fa3a9f	Fix android test project compile failures	2024-02-15 12:22:14 +01:00
Dan Balasescu	755bc7c050	Fix resolution scaling	2024-02-15 20:07:55 +09:00
Dean Herbert	e91d38872d	Update framework	2024-02-15 18:28:59 +08:00
Bartłomiej Dach	898d5ce88b	Show selected submission failure messages even in solo ... Previously, if a `SubmittingPlayer` instance deemed it okay to proceed with gameplay despite submission failure, it would silently log all errors and proceed, but the score would still not be submitted. This feels a bit anti-user in the cases wherein something is genuinely wrong with either the client or web, so things like token verification failures or API failures are now shown as notifications to give the user an indication that something went wrong at all. Selected cases (non-user-playable mod, logged out, beatmap is not online) are still logged silently because those are either known and expected, or someone is messing with things.	2024-02-15 10:55:08 +01:00
Bartłomiej Dach	95e745c6fb	Use better messaging for selected submission failure reasons ... These have been cropping up rather often lately, mostly courtesy of linux users, but not only: https://github.com/ppy/osu/issues/26840 https://github.com/ppy/osu/issues/27008 https://github.com/ppy/osu/discussions/26962 so this is a proposal for slightly improved messaging for such cases to hopefully get users on the right track. The original error is still logged to network log, so there's no information loss.	2024-02-15 10:51:27 +01:00
Dan Balasescu	a037dbf8de	Update test to set Child in more canonical manner	2024-02-15 18:33:48 +09:00
Bartłomiej Dach	e10c4c7079	Merge pull request #27176 from peppy/document-classic-mod-no-rank ... Add inline documentation as to why classic mod is not ranked	2024-02-15 09:22:05 +01:00
Dean Herbert	409dfd33e7	Merge pull request #27178 from Joehuu/truncate-osu-dropdown-items ... Truncate long dropdown menu item text and show tooltip	2024-02-15 16:11:36 +08:00
Joseph Madamba	3d08bc5605	Truncate long dropdown menu item text and show tooltip	2024-02-14 23:01:51 -08:00
Joseph Madamba	401bd91dc4	Add visual test showing overflow on dropdown menu items	2024-02-14 22:57:38 -08:00
Dean Herbert	9e9297bfb3	Add inline documentation as to why classic mod is not ranked ... See https://github.com/ppy/osu/pull/27149#issuecomment-1939509941.	2024-02-15 13:22:54 +08:00
Dean Herbert	207ad599d0	Merge pull request #27162 from frenzibyte/catch-playfield ... Limit vertical visibility of osu!catch playfield to an aspect ratio of 4:3	2024-02-15 13:12:49 +08:00
Salman Ahmed	02bcd29303	Merge branch 'master' into catch-playfield	2024-02-15 08:08:01 +03:00
Dean Herbert	728f65b6d3	Merge pull request #27173 from EVAST9919/song-select-sort ... Reduce allocations during aggregate beatmap sorts in song-select screen	2024-02-15 12:50:16 +08:00
Salman Ahmed	0c25a9a460	Add extra bottom space for catcher to not look cut off on tall resolutions	2024-02-15 07:31:01 +03:00
Joseph Madamba	a03835bf1c	Improve comments	2024-02-14 20:13:27 -08:00
Dean Herbert	674ee91bb5	Define aggregate max delegates as static to further reduce allocations	2024-02-15 11:40:50 +08:00
Dean Herbert	80abf6aab3	Avoid some further enumerator allocations	2024-02-15 09:45:24 +08:00
Andrei Zavatski	6e1b4152c0	Redice allocations during aggregate beatmap sort	2024-02-15 00:01:55 +03:00
Dean Herbert	ebea0d283e	Merge pull request #27156 from bdach/score-statistics-updates-working-2 ... Watch online statistics changes after every play & display them in toolbar	2024-02-15 03:21:42 +08:00
Dean Herbert	59efd22ba2	Merge branch 'master' into score-statistics-updates-working-2	2024-02-15 02:55:12 +08:00
Dean Herbert	9ec79755fb	Standardise font specs	2024-02-15 02:54:28 +08:00
Dean Herbert	c175e03600	Inline rolling duration variable	2024-02-15 02:53:38 +08:00
Bartłomiej Dach	c588b81cee	Merge pull request #27163 from frenzibyte/ignore-soft-deleted-beatmaps-in-notification ... Ignore soft-deleted beatmaps when trying to present from notification	2024-02-14 18:07:59 +01:00
Bartłomiej Dach	692ff8ea11	Merge pull request #23129 from Elvendir/add-last-played-filter ... Add last played search filter in song select	2024-02-14 18:05:31 +01:00
Bartłomiej Dach	aae431e8f6	Cancel rolling properly	2024-02-14 16:48:31 +01:00
Bartłomiej Dach	53884f61c3	Apply suggested changes	2024-02-14 16:41:41 +01:00
Bartłomiej Dach	ae9a2661ac	Sprinkle some raw string prefixes	2024-02-14 16:20:47 +01:00
Bartłomiej Dach	f7bea00564	Improve test coverage	2024-02-14 16:19:32 +01:00
Bartłomiej Dach	414066fd34	Inline problematic function (and rename things to make more sense)	2024-02-14 16:07:42 +01:00
Bartłomiej Dach	f1d69abdc8	Rename test	2024-02-14 15:59:07 +01:00
Bartłomiej Dach	a8ae0a032f	Simplify parsing	2024-02-14 15:58:38 +01:00
Dean Herbert	3da1d05d98	Merge branch 'master' into ignore-soft-deleted-beatmaps-in-notification	2024-02-14 22:56:47 +08:00
Bartłomiej Dach	c24328dda3	Abandon date filter if no meaningful time bound found during parsing	2024-02-14 15:56:32 +01:00
Bartłomiej Dach	d7dfc8b88a	Add failing test coverage for empty date filter not parsing	2024-02-14 15:55:57 +01:00
Bartłomiej Dach	f0f37df67f	Revert unnecessary change	2024-02-14 15:37:02 +01:00
Bartłomiej Dach	1113355753	Merge branch 'master' into add-last-played-filter	2024-02-14 15:36:19 +01:00
Bartłomiej Dach	2c0a5b7ef5	Fix missing tiny droplet not triggering fail with perfect on ... Stable does this: 46cd3a10af/osu!/GameplayElements/HitObjectManagerFruits.cs#L98-L102 I'd rather not say what I think about it doing that, since it's likely to be unpublishable, but to approximate that, just make it so that only the "default fail condition" is beholden to the weird ebbs and flows of what the ruleset wants. This appears to fix the problem case and I'm hoping it doesn't break something else but I'm like 50/50 on it happening anyway at this point. Just gotta add tests add nauseam.	2024-02-14 14:21:48 +01:00
Bartłomiej Dach	f1363dc9e4	Merge pull request #27164 from frenzibyte/comment-mapper-pill ... Add support for displaying "mapper" badge in comment section	2024-02-14 13:53:50 +01:00
Bartłomiej Dach	3f46e1afc3	Merge branch 'master' into comment-mapper-pill	2024-02-14 13:22:36 +01:00
Bartłomiej Dach	68247fa022	Fix typo in json property name ... Would cause the mapper badge to never actually be shown in the real world.	2024-02-14 13:21:37 +01:00
Bartłomiej Dach	8312f92b4e	Use better value for alignment	2024-02-14 12:24:28 +01:00
Bartłomiej Dach	d189fa0f69	Rename flag	2024-02-14 11:53:41 +01:00
Bartłomiej Dach	746f50e738	Merge pull request #27165 from frenzibyte/catch-remove-plate-flipping ... Remove behaviour of flipping catcher plate on direction change	2024-02-14 10:55:14 +01:00
Bartłomiej Dach	153024e61b	Increase transition durations slightly ... Maybe slightly better readability. Dunno.	2024-02-14 10:16:10 +01:00
Bartłomiej Dach	6baa099906	Fix broken delay	2024-02-14 10:12:01 +01:00
Bartłomiej Dach	7f76ff1f5d	Merge pull request #27145 from tsunyoku/legacy-relax-replays-key-presses ... Create key-presses when watching legacy Relax replays	2024-02-14 10:06:06 +01:00
Dan Balasescu	3b8203a3ad	Merge pull request #27167 from smoogipoo/fix-inspection ... Prefer collection initializer over collection expression syntax	2024-02-14 17:58:40 +09:00
Dan Balasescu	2981ebe3d5	Fix inspection	2024-02-14 17:13:44 +09:00
Bartłomiej Dach	f53bce8ff7	Fix catch health processor allowing fail on tiny droplet ... Closes https://github.com/ppy/osu/issues/27159. In today's episode of "just stable things"...	2024-02-14 09:02:33 +01:00