60580 Commits

This Branch

This Branch

All Branches

• Add more commenting
  Dean Herbert · 2023-06-14 14:05:30 +09:00
  54abe572ec
• Fix typo

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-06-14 14:05:30 +09:00
  0b91e50c62
• Avoid tracking hit events altogether during migration
  Dean Herbert · 2023-06-14 14:05:30 +09:00
  d9cb37a53d
• Move local classes to their rightful location
  Dean Herbert · 2023-06-14 14:05:30 +09:00
  eb526b8c4c
• Avoid unnecessary operations during score processor simulation
  Dean Herbert · 2023-06-14 14:05:30 +09:00
  36da464a6e
• Avoid overhead from retrieving MaxCombo inside loop from realm
  Dean Herbert · 2023-06-14 14:05:30 +09:00
  e7b42ddebc
• Add basic profiling output of realm migrations
  Dean Herbert · 2023-06-14 14:05:30 +09:00
  cd0d5e4521
• Remove logging and catch any kind of errors
  Dean Herbert · 2023-06-14 14:05:30 +09:00
  21f9acb882
• Account for scores which don't have correct maximum statistics populated
  Dean Herbert · 2023-06-14 14:05:30 +09:00
  2208cdb038
• Add basic setup for score migration
  Dean Herbert · 2023-06-14 14:05:30 +09:00
  b7d9e826f4
• Update resources
  Dean Herbert · 2023-06-14 14:02:41 +09:00
  748d8ab741
• Fix osu!mania scroll speed milliseconds having too much precision

  Closes #23750.

  Dean Herbert · 2023-06-10 02:21:59 +09:00
  2023.610.0 d5fa8e5390
• Revert to previous bound in drum roll tick generation

  While `EndTime + tickSpacing` _was_ closer to what stable was using, it
  could cause undesirable edge cases wherein a tick would be spawned
  outside of the drum roll's duration
  (see https://github.com/ppy/osu/pull/23768/files#r1222073027).
  
  For this reason, stick with the old code for now, as it is not as
  susceptible to that sort of breakage.

  Bartłomiej Dach · 2023-06-10 02:21:49 +09:00
  8962cba88c
• Update drum roll judgement tests to work correctly with more correct tick rate applied
  Dean Herbert · 2023-06-10 02:21:49 +09:00
  fd8e77d2d2
• Clean up TestSceneDrumRollJudgements
  Dean Herbert · 2023-06-10 02:21:49 +09:00
  063c8c40d8
• Add note about lastTickHittable requirement
  Dean Herbert · 2023-06-10 02:21:49 +09:00
  47d24d59ed
• Fix osu!taiko drum rolls not getting correct tick rate after placement in the editor
  Dean Herbert · 2023-06-10 02:21:49 +09:00
  76b09abb04
• Fix ticks being created after the end of drum rolls in osu!taiko editor

  Closes https://github.com/ppy/osu/issues/23135.

  Dean Herbert · 2023-06-10 02:21:49 +09:00
  3686aceee8
• Fix triangles song progress bar blinking during gameplay

  Closes #23760.

  Bartłomiej Dach · 2023-06-10 02:21:22 +09:00
  719fbfd7ed
• Change osu!mania scoring ratio to 99% acc (to match previous lazer scoring)
  Dean Herbert · 2023-06-10 02:21:14 +09:00
  c40887eee8
• Be slightly more specific with error message
  Bartłomiej Dach · 2023-06-10 02:19:34 +09:00
  06040828c0
• Inline binary reading to avoid polluting RealmAccess with nested class
  Dean Herbert · 2023-06-10 02:19:34 +09:00
  7fe06185b9
• try-catch more
  Dean Herbert · 2023-06-10 02:19:34 +09:00
  50e3932256
• Catch errors during score parsing
  Dan Balasescu · 2023-06-10 02:19:34 +09:00
  f47bca7e32
• Don't scale stable scores with the classic scoring mode
  Dan Balasescu · 2023-06-10 02:19:34 +09:00
  8c1d6e0aeb
• Parse ScoreInfo.IsLegacyScore from replays
  Dan Balasescu · 2023-06-10 02:19:34 +09:00
  1d5464022c
• Fix test failures due to cross-test state pollution

  `TestSceneEditorTestGameplay` is not isolated from database, and one of
  the tests exiting editor when seeked to 60000 milliseconds
  (`TestClockTimeTransferIsOneDirectional()`) ended up changing
  `EditorTimestamp` to the same value, causing
  `TestSaveChangesBeforeGameplayTest()` to fail due to changing initial
  state.
  
  To fix, perform a direct deletion of imported beatmaps in realm to avert
  this scenario, contrary to the soft-deletion via `BeatmapManager` done
  previously.

  Bartłomiej Dach · 2023-06-10 02:19:34 +09:00
  7032ba9df1
• Fix incorrect realm schema comment

  Co-authored-by: timiimit <32331609+timiimit@users.noreply.github.com>

  Dean Herbert · 2023-06-10 02:19:34 +09:00
  b90b76c039
• Add test coverage of editor timestamp remembering
  Dean Herbert · 2023-06-10 02:19:34 +09:00
  19734193fe
• Bump schema version
  Dean Herbert · 2023-06-10 02:19:34 +09:00
  90c30dee62
• Rename variable and ensure timestamp is updated even when not saving
  Dean Herbert · 2023-06-10 02:19:34 +09:00
  38fda7ac7d
• Use LastEditTime in Editor
  timiimit · 2023-06-10 02:19:34 +09:00
  aa0e4e16f7
• Add BeatmapInfo.LastEditTime property
  timiimit · 2023-06-10 02:19:34 +09:00
  2c327a74b2
• Update framework
  Dean Herbert · 2023-06-10 01:47:30 +09:00
  1765e6d430
• Bump replay version in encoder after Score V2 changes

  One release too late, but this may help in the future if we need to
  discern replays set with Score V2 from older lazer replays.

  Bartłomiej Dach · 2023-06-10 01:46:09 +09:00
  e07cae50a2
• Merge pull request #23741 from peppy/fix-manage-collection-commit-on-focus-loss

  Fix collection name changes not being reflected if enter is not pressed

  Bartłomiej Dach · 2023-06-04 17:19:13 +02:00
  25d0f0f3da
• Merge pull request #23718 from peppy/tidy-results-grid-usage

  Tidy up results screen statistic item flow

  Bartłomiej Dach · 2023-06-04 16:57:51 +02:00
  d0167cb324
• Ensure collection edit textbox commits on focus loss

  As discussed in https://github.com/ppy/osu/discussions/23739

  Dean Herbert · 2023-06-04 12:51:03 +09:00
  eb7586b517
• Add test coverage showing commit failure in manage collections dialog
  Dean Herbert · 2023-06-04 12:50:30 +09:00
  3e308e4c27
• Merge branch 'master' into tidy-results-grid-usage
  Bartłomiej Dach · 2023-06-03 19:45:23 +02:00
  331e90f720
• Merge pull request #23551 from timiimit/update-multiplayer-room-diff-range

  Fix multiplayer room difficulty range not being updated

  Bartłomiej Dach · 2023-06-03 19:41:50 +02:00
  51149343fb
• Simplify column dimensions code

  `dimensions` would always receive exactly one item, so might as well
  inline it.
  
  And yes, at this point the grid container is mostly a glorified
  `FillFlowContainer { Direction = FlowDirection.Vertical }`, but I am not
  touching that in this pull pending further decisions with respect to
  direction.

  Bartłomiej Dach · 2023-06-03 19:40:01 +02:00
  602d5db3bb
• Fix code quality inspection
  Bartłomiej Dach · 2023-06-03 16:50:58 +02:00
  474f7c2bc0
• Merge branch 'master' into update-multiplayer-room-diff-range
  Bartłomiej Dach · 2023-06-03 16:50:09 +02:00
  a9d4556647
• Merge pull request #23719 from peppy/disable-tablet-support-on-error

  Automatically disable tablet support on error

  Bartłomiej Dach · 2023-06-03 12:25:06 +02:00
  0b841eda71
• Merge pull request #23733 from peppy/bubble-mod-pool-fix

  Fix "bubbles" mod not adding pool to hierarchy (and constructing too early)

  Bartłomiej Dach · 2023-06-03 08:56:26 +02:00
  24f0b8df1f
• Fix "bubbles" mod not adding pool to hierarchy (and constructing too early)
  Dean Herbert · 2023-06-02 23:01:03 +09:00
  a5fd833214
• Merge pull request #23730 from smoogipoo/reduce-legacy-diffcalc-mod-init

  Fix legacy mod difficulty calculation creating all mods unnecessarily

  Dean Herbert · 2023-06-02 22:22:19 +09:00
  8063d50369
• Fix legacy diffcalc creating all mods unnecessarily
  Dan Balasescu · 2023-06-02 17:37:43 +09:00
  bfe80fe143
• Disable all tablet handlers to guard against a grim future
  Dean Herbert · 2023-06-02 08:48:47 +09:00
  c33ddedca0