Avoid overhead from retrieving MaxCombo inside loop from realm

2026-05-27 21:08:34 +08:00 · 2023-06-13 02:05:00 +09:00
parent cd0d5e4521
commit e7b42ddebc
1 changed files with 4 additions and 1 deletions
@@ -14,6 +14,9 @@ namespace osu.Game.Database
    {
        public static long GetNewStandardised(ScoreInfo score)
        {
+            // Avoid retrieving from realm inside loops.
+            int maxCombo = score.MaxCombo;
+
            var ruleset = score.Ruleset.CreateInstance();
            var processor = ruleset.CreateScoreProcessor();

@@ -61,7 +64,7 @@ namespace osu.Game.Database
                if (result == HitResult.Miss || result == HitResult.LargeTickMiss)
                    continue;

-                if (processor.Combo.Value == score.MaxCombo)
+                if (processor.Combo.Value == maxCombo)
                {
                    if (misses.Count > 0)
                    {