400 Commits

• Restore editor mode when changing difficulty (#37671)

  When editing metadata, it's annoying that the editor returns to compose
  mode when switching between difficulties. This fixes that fallacy.
  
  Supersedes and closes https://github.com/ppy/osu/pull/36724.

  Dean Herbert · 2026-05-08 10:25:22 +02:00
  e6fdd37e76
• Turn tests green, for a short while, maybe (#37218)

  ## [Rewrite `BackgroundMusicManager` to not run into framework
  breakage](https://github.com/ppy/osu/commit/622216d8911832c39fa4e126b2810e4e0f46cbf7)
  
  The attempted proper fix to this was
  https://github.com/ppy/osu-framework/pull/6727. Unfortunately when
  presented with [the framework
  bump](https://github.com/ppy/osu/pull/37217) with that change, CI says
  "you're stupid" and fails on some disposal idiocy that of course is
  undebuggable and irreproducible:
  
  The active test run was aborted. Reason: Test host process crashed :
  Unhandled exception. System.AggregateException: One or more errors
  occurred. (Object reference not set to an instance of an object.)
  ---> System.NullReferenceException: Object reference not set to an
  instance of an object.
  at osu.Framework.Audio.Sample.SampleChannelBass.Dispose(Boolean
  disposing)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  	--- End of stack trace from previous location ---
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task&
  currentTaskSlot, Thread threadPoolThread)
  	   --- End of inner exception stack trace ---
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Threading.AudioThread.OnExit()
  at osu.Framework.Threading.GameThread.setExitState(GameThreadState
  exitState)
  	   at osu.Framework.Threading.GameThread.RunSingleFrame()
  at osu.Framework.Threading.GameThread.<createThread>g__runWork|70_0()
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  	--- End of stack trace from previous location ---
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  
  
  (https://github.com/ppy/osu/actions/runs/24019928154/job/70046733058?pr=37217#step:5:119)
  
  I no longer have the energy for any of this shit.
  
  @nekodex would appreciate if you could check that I actually haven't
  broken anything with the bgm here. Seems okay to me in test scenes at
  least.
  
  ## [Apply lowest-effort maybe-fixing changes to a bunch of flaking
  tests](https://github.com/ppy/osu/commit/7bd3ca4adfcce5b90add11565a13f3fe9177ad5e)
  
  None of the failures are reproducible locally, of course. I'm tired of
  this. If anyone else wants to subject themselves to actually
  investigating any of these, by all means, godspeed and good luck.

  Bartłomiej Dach · 2026-04-06 17:59:39 +09:00
  809298ddeb
• Fix osu!mania editor not zooming playfield to match timeline (#37176)

  - Fixes CI failures due to completely wrong test (sorry)
  - Fixes #37167 (oops)

  Dean Herbert · 2026-04-02 12:49:45 +02:00
  e207a42889
• Fix replay/spectator scroll text not toggling with Ctrl+H (#37027)

  Intended to add toggle but forgot.
  
  This also fixes https://github.com/ppy/osu/issues/37012 via a convoluted
  refactor of a lot of stuff. The basic overview is:
  
  - Moved all replay overlay concerns out of `HUDOverlay`. We can display
  this above everything confidently (i think).
  - Split out `ReplayOverlay` and `ReplaySettingsOverlay` so the base
  class can handle the visibility, hotkeys and everything that should be
  shared with *all* replay overlay components going forward. `Ctrl+H` is
  supposed to hide any of these kinds of details, and I'm sure we'll add
  more in the future.
  - Reorganised some things in `Player` so the new structure would work.
  Mainly the overlays which add a black layer during fade out.

  Dean Herbert · 2026-04-01 11:29:25 +02:00
  279effe23c
• "Fix" performance drop caused by changing scroll speed (#37149)

  The fix is just disabling the animation. It works I guess.
  
  ---
  
  - Closes https://github.com/ppy/osu/issues/37042
  
  Currently in Mania, you can change the scroll speed for a brief period
  during the beginning of a song. However this scroll speed change occurs
  over a short period of time, which causes a bunch of extra hit object
  updates, causing major fps and latency drops.
  
  This fix simply replaces the dampening with an immediate scroll speed
  update. Since the scroll speed can only be updated for a short time at
  the beginning of the song, providing immediate visual feedback on the
  scroll speed makes sense to me. However another potential solution would
  be to filter the TimeRange Value updates to keep the gradual scroll
  speed visual change, while greatly reducing the number of updates to the
  hit objects currently on screen.
  
  If there is any feedback I would greatly appreciate it as this is my
  first issue here. I had ran both inspectCode.ps1 and the code formatter
  before creating the merge request. Thank you.
  
  Before fix:
  
  https://github.com/user-attachments/assets/55e30894-7341-414a-af2e-2ec051c3a252
  
  After fix:
  
  https://github.com/user-attachments/assets/c085d33f-c0ae-45dd-8131-e79a5682b9ca
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Austin Moore · 2026-03-31 23:33:53 +09:00
  cbcbc788b8
• Fix a few flaky tests

  See failures on https://github.com/ppy/osu/runs/66073876886#r3s1.

  Dean Herbert · 2026-03-07 23:19:13 +09:00
  14ae2312ff
• Refactor ShearedButton to allow easier relative sizing (#36802)

  This commit rearranges the contents of `ShearedButtons` to be more
  independent of each other in regards to sizing. Thanks to that, the
  custom logic related to enabling autosizing is no longer necessary.
  Witdh and height are no longer set via the constructor, and can be
  freely configured using the initializer syntax.
  
  Additionally, this allows the button to use relative sizing without
  having to resort to any hackery with `Size` (this will come in handy for
  me when implementing the new footer on multiplayer screens).
  
  Given that most of the `ShearedButton`s currently in use set their width
  explicitly, I did not set `AutoSizeAxes = Axes.X` like it would be by
  default previously. Instead it is set on the only two such buttons (show
  converts/selected mods on ssv2). I suppose it might be a good idea to
  have it set that by default if no `Width` is specified, as right now
  it'll just not show anything.
  
  Also I've set the margin on the text field by default in all cases
  instead of only when autosizing like how it was previously, since
  otherwise it would be a pain to set that on each button instance when
  needed. I've checked all affected components and could not find any text
  overflowing issues that this could cause.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Krzysztof Gutkowski · 2026-03-06 02:09:05 +09:00
  b76a7e1bb6
• Move v2 files to final location

  This contains only renames and namespace updates.

  Dean Herbert · 2026-03-03 16:45:15 +09:00
  c28c64940a
• Move leaderboards classes to gameplay namespace for now
  Dean Herbert · 2026-03-03 16:45:13 +09:00
  54a1417dd8
• Refactor TestSceneScreenFooter to test entire OsuScreens (#36718)

  Part of the `ScreenFooter` refactor, which intends to move the footer
  content handling to `OsuScreen`. This commit updates the `ScreenFooter`
  test to operate on entire `OsuScreen`s, in order to better test the
  entire flow of pushing a screen, and having it create and add its own
  content to the footer.
  
  This should be 80-90% identical to the original test case structure
  wise, just that instead of manually manipulating the footer with
  `SetButtons()`, various screens with the appropriate buttons are being
  moved around the screen stack.
  
  Additionally this adds some more tests handling common use cases, as
  well as removes `TestLoadOverlayAfterFooterIsDisplayed()`, since as far
  as I understand the behaviour described in it doesn't actually happen in
  production code. From what I can see, Screens instantiate their overlays
  in `load()`, and then register them in `LoadComplete()`. There seems to
  be no case where a `ShearedOverlayContainer` is created in the middle of
  a screen's lifecycle.

  Krzysztof Gutkowski · 2026-03-01 22:36:07 +09:00
  b88cba0829
• Rename one more missed song select v2 class
  Dean Herbert · 2026-02-25 02:18:18 +09:00
  ee8d99034c
• Fix failing test case due to mod overlay being moved to game level
  Dean Herbert · 2026-01-10 01:44:07 +09:00
  dda1c7f75b
• Fix/remove tests broken by screen behaviour change
  Dean Herbert · 2026-01-01 00:29:04 +09:00
  0a2fc12061
• Merge branch 'master' into new-playlists-song-select
  Dan Balasescu · 2025-12-17 13:33:34 +09:00
  67e0348fa8
• Fix dragging volume meter to adjust volume closing overlays if mouse is released outside of overlay content (#35940)

  * Add failing test
  
  * Fix dragging volume meter to adjust volume closing overlays if mouse is released outside of overlay content
  
  Fixes https://osu.ppy.sh/community/forums/topics/2159553.

  Bartłomiej Dach · 2025-12-11 13:47:08 +09:00
  095a67c24e
• Merge branch 'master' into new-playlists-song-select
  Dan Balasescu · 2025-11-18 14:08:12 +09:00
  a30f08be80
• Fix intermittent footer test failures

  See:
  https://github.com/ppy/osu/pull/35367/checks?check_run_id=53269836615
  
  Can be reproed via a `Thread.Sleep(1000)` in a `TestScreenOne` BDL load.
  Code here is similar to `OsuGameTestScene.PushAndConfirm()`.

  Dan Balasescu · 2025-10-22 16:40:20 +09:00
  62599de649
• Fix tests
  Dan Balasescu · 2025-10-17 09:18:04 +09:00
  b663fe17ab
• Add footer tests involving subscreens
  Dan Balasescu · 2025-10-16 17:38:51 +09:00
  81a529200d
• Fix weird xmldoc issue

  Rider was fine with it...

  Bartłomiej Dach · 2025-10-09 10:17:55 +02:00
  3fc3a53521
• Add test demonstrating failure scenario
  Bartłomiej Dach · 2025-10-09 09:46:32 +02:00
  e33de9b658
• Add failing test case
  Bartłomiej Dach · 2025-10-02 13:24:24 +02:00
  e7076b9582
• Add failing test case
  Bartłomiej Dach · 2025-10-01 14:17:16 +02:00
  0230a27de6
• Attempt to fix flaky TestGameplaySettingsDoesNotExpandWhenSkinOverlayPresent

  See https://github.com/ppy/osu/pull/35118/checks?check_run_id=51202910556.

  Dean Herbert · 2025-09-25 15:56:48 +09:00
  12e29f0bcc
• Apply suggested rename
  Bartłomiej Dach · 2025-08-29 09:58:56 +02:00
  526ee32268
• Adjust tests to new beatmap set model usage in carousel
  Bartłomiej Dach · 2025-08-28 13:09:11 +02:00
  6ba72fa481
• Merge pull request #34491 from peppy/wedge-background-click-block

  Fix clicks propagating through personal best score area

  Bartłomiej Dach · 2025-08-04 12:56:40 +02:00
  3bfe2581a4
• Fix test failure due to over-scoping
  Dean Herbert · 2025-08-04 18:53:55 +09:00
  13ff11ac85
• Fix skin editor tests not passing on macOS
  Dan Balasescu · 2025-08-03 03:50:06 +09:00
  0270ca6cf1
• Remove duplicate test
  Dean Herbert · 2025-07-24 13:24:57 +09:00
  ad9584e658
• Adjust variable name
  eyhn · 2025-07-23 22:33:22 +08:00
  843cd86551
• Fix present beatmap audio start at the preview point
  eyhn · 2025-07-23 22:29:07 +08:00
  e55a9e486b
• Fix flaky playlists navigation test

  See: https://github.com/ppy/osu/actions/runs/16267403227/job/45929099025
  
  Repro:
  
  ```diff
  diff --git a/osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs b/osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs
  index a4e808ff76..db0a0e83a6 100644
  --- a/osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs
  +++ b/osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs
  @@ -88,6 +88,7 @@ public abstract partial class LoungeSubScreen : OnlinePlaySubScreen, IOnlinePlay
           [BackgroundDependencyLoader(true)]
           private void load()
           {
  +            System.Threading.Thread.Sleep(1000);
               Masking = true;
  
               const float controls_area_height = 25f;
  
  ```

  Dan Balasescu · 2025-07-14 22:41:08 +09:00
  3a3c1c4e09
• Remove duplicated test method
  Dean Herbert · 2025-07-01 17:34:52 +09:00
  99220408f6
• Update existing tests to work with Song Select v2
  Dean Herbert · 2025-07-01 17:25:38 +09:00
  397b9b3994
• Attempt to fix flaky test TestExitWithHoldDisabled

  See
  https://github.com/ppy/osu/actions/runs/15915618971/job/44892620536#step:5:203.
  
  Note that the `DialogOverlay` only finishes loading after the until step
  failure.

  Dean Herbert · 2025-06-27 14:32:58 +09:00
  e713a68c49
• Add failing test
  Bartłomiej Dach · 2025-06-25 09:47:53 +02:00
  57bfb37888
• Add failing test case
  Salman Alshamrani · 2025-06-18 19:19:54 +03:00
  9cb824df6f
• Increase hitbox for footer back button

  Based on countless feedback of users wanting to be able to throw their
  mouse into the corner of the screen to go back. It makes sense.

  Dean Herbert · 2025-06-11 18:00:22 +09:00
  70a5474489
• Add test coverage of editor flow from song select
  Dean Herbert · 2025-06-05 03:49:00 +09:00
  bb49bb5e23
• Add back more song select navigation tests
  Dean Herbert · 2025-06-05 03:49:00 +09:00
  118583bf21
• Merge pull request #33413 from bdach/update-framework

  Update framework

  Dean Herbert · 2025-06-05 03:15:27 +09:00
  6d5bf22a71
• Fix cursor test
  Bartłomiej Dach · 2025-06-04 13:34:21 +02:00
  68795255ee
• Mark test scene class partial
  Bartłomiej Dach · 2025-06-04 11:23:10 +02:00
  2cd923ba26
• Add back test covering immediate exit song select
  Dean Herbert · 2025-06-04 17:59:08 +09:00
  7d8df1d8d4
• Fix audio not correctly continuing on resuming from gameplay
  Dean Herbert · 2025-06-04 17:39:22 +09:00
  f086be9c18
• Fix test being sensitive to selected tab on new song select
  Bartłomiej Dach · 2025-05-30 10:02:40 +02:00
  9d0d3bb97a
• Add test coverage of volume changing while at song select

  This passes without changes in this pull request. But I'm just copying
  across from https://github.com/ppy/osu/pull/33225 to stay in theme?

  Dean Herbert · 2025-05-27 15:53:31 +09:00
  7d8dc1bd0a
• Fix footer buttons not restoring when exiting an already displayed screen

  Closes https://github.com/ppy/osu/issues/33168.

  Dean Herbert · 2025-05-18 16:53:33 +09:00
  bec3450a44
• Merge branch 'master' into tidy-screen-footer
  Bartłomiej Dach · 2025-05-15 12:55:28 +02:00
  0132b78eec