osu-lazer

Fix mania hold notes dimming unexpectedly (#37008 )

Fixes https://github.com/ppy/osu/issues/29223

This fixes several issues around hold note dimming.

Notice in the following video:
- The tail piece of the first note not getting dimmed.
- The body of the second note not responding to dimming at all.

https://github.com/user-attachments/assets/8e51053d-8d88-4e48-909b-79218d65917b

Then, notice in the following video:
- The body piece of the second note is dimmed from the very beginning.

https://github.com/user-attachments/assets/a514c630-5c72-4ba5-96d5-472bae1058b3

This requires a specific setup whereby the hold note and its components
must be reused from the pool. In particular:
1. The hold note must be long. So long that by the time the tail becomes
on screen, the body will already have dimmed.
2. The hold note must be re-used from the pool. We can induce this by
setting the pool sizes to 1 in
[`Column.cs`](https://github.com/ppy/osu/blob/780ce2666099c22d1e0673cafab544418b5d14b0/osu.Game.Rulesets.Mania/UI/Column.cs#L121-L123).
3. The second hold note should be placed far enough in the timeline that
the first hold note dies by the time it becomes visible.
4. Scroll speed should be adjusted to fit the above constraints.

I haven't done a full deep dive into exactly _why_ this is happening, so
the fix here is hand-wavy. That said, just by looking at the old code in
`LegacyBodyPiece` you'll get a feeling that something's bound to go
wrong;
- It never resets the `missingFadeTime` state.
- It never resets the colours back to `Color4.White`.
- It applies transforms onto external components.
- It jumps through hoops to figure out how to set `missingFadeTime`.

My hope is that these changes first bring some sanity in the process,
and if it breaks again I'll consider doing a more proper root cause
(I've had this issue in the back of my mind for about 1 year).

With this PR, they now behave as expected:

https://github.com/user-attachments/assets/140b37c5-cf84-44ba-b797-86ac6d8130c8

https://github.com/user-attachments/assets/6f2342a4-6a9a-4941-a55a-24a357f27c25

Dan Balasescu · 2026-03-23 08:33:23 +01:00

d4a4acd3f4

Partial everything

Dan Balasescu · 2022-11-27 00:00:27 +09:00

7bc8908ca9

Fix mania hold note head disappears

ekrctb · 2022-10-06 19:46:10 +09:00

ea4dbc8c0f

Fix tests

ekrctb · 2022-10-04 16:10:18 +09:00

15d159a97e

Automated #nullable processing

Dan Balasescu · 2022-06-17 16:37:17 +09:00

f8830c6850

Update with keybinding changes

smoogipoo · 2021-09-16 18:26:12 +09:00

f9d5abff8a

Fix hold notes handling all input ever

Dean Herbert · 2021-08-24 19:08:04 +09:00

6252b8aa42

Initial implementation of DHO pooling

smoogipoo · 2021-05-12 16:35:05 +09:00

5692cecaa4

Fix mania hold note heads hiding when frozen

This was an insidious regression from a3dc1d5. Prior to that commit,
`DrawableHoldNoteHead` had `UpdateStateTransforms()` overridden, to set
the hold note head's lifetime. When that method was split into
`UpdateInitialStateTransforms()` and `UpdateHitStateTransforms()`, the
lifetime set was moved to the former.

Unfortunately, that override served two purposes: both to set the
lifetime, and to suppress hit animations which would normally be added
by the base `DrawableManiaHitObject`. That fact being missed led to
`UpdateHitStateTransforms()` hiding the hold note head immediately on
hit and with a slight delay on miss.

To resolve, explicitly override `UpdateHitStateTransforms()` and
suppress the base call, with an explanatory comment.