Dean Herbert
af2e82d7d5
Move operation of setting GameplayClockContainer.StartTime
to Reset
call
2022-08-22 14:11:06 +09:00
Dean Herbert
17a1df281c
Fix incorrect implicit null specification for user audio offset bindable
2022-08-22 14:03:51 +09:00
Dean Herbert
ba23ce75c2
Make FramedBeatmapClock.Track
non-null
2022-08-22 14:02:41 +09:00
Dean Herbert
85d0b7fc57
Reword class xmldoc to better explain that offset application is optional
2022-08-22 14:02:20 +09:00
Dan Balasescu
b81c7ffc60
Merge pull request #19868 from peppy/fix-test-deadlocks
...
Add safeties to avoid deadlock in `SubmittingPlayer`
2022-08-22 13:17:41 +09:00
Dan Balasescu
e1fa959f0b
Fix language change removing mod column bold text
2022-08-22 13:00:47 +09:00
Andrew Hong
c6a739f5a8
Add date submitted sorting
2022-08-21 23:09:33 -04:00
Dean Herbert
3ef6c60d1f
Merge pull request #19898 from bdach/mod-select/fix-difficulty-multiplier-rounding
...
Adjust rounding in mod select difficulty multiplier to match song select footer
2022-08-22 11:18:34 +09:00
Bartłomiej Dach
aa15e84bea
Adjust rounding in mod select difficulty multiplier to match song select footer
...
The 0.01 `Precision` spec on `DifficultyMultiplierDisplay.Current` would
cause the difficulty multiplier to use a different midpoint rounding
strategy than `double.ToString()`, which is the one that the song select
footer relies on. For example, a value of 0.015 would be rounded down
to 0.01 by `double.ToString()`, but rounded up to 0.02
by `BindableDouble`.
Fix the discrepancy by just deleting the `Precision` spec. Since the
value of the bindable would go through `ToLocalisableString(@"N2")`
anyway, it was redundant as is.
Fixes #19889 .
2022-08-21 23:15:49 +02:00
naoei
29ef1c8db8
Check if StatisticItem.Name is null or empty
2022-08-20 21:48:53 -04:00
naoei
9386d352b8
Make StatisticItem.Name not nullable
2022-08-20 21:48:35 -04:00
Nao
189a407cb1
Merge branch 'master' into ruleset-localization
2022-08-20 21:39:10 -04:00
Dean Herbert
513ba69f6f
Merge pull request #19865 from OliBomby/fix-slider-flip
...
Fix flipping a slider sometimes changing the curve type from "Perfect" to "Bezier"
2022-08-21 00:04:35 +09:00
OliBomby
7732fb21d5
fix code quality
2022-08-20 16:09:02 +02:00
OliBomby
614ae815c0
Added tests for making sure flipping and rotating retains perfect control point type
2022-08-20 15:57:39 +02:00
Dean Herbert
8566e93c72
Guard against SubmittingPlayer
potentially getting stuck waiting on request forever
2022-08-20 17:19:17 +09:00
Dean Herbert
a1e849c4db
Ensure that DummyAPIAccess
runs all queued tasks on disposal
2022-08-20 16:22:35 +09:00
Dean Herbert
885ea4270b
Reorder context menu items and tidy up surrounding code
2022-08-20 14:03:54 +09:00
Dean Herbert
cbdd870ecf
Merge pull request #19693 from its5Q/editor-localisation
...
Add localisation support for beatmap editor setup
2022-08-20 11:51:57 +09:00
Dean Herbert
36e202c70e
Add inline comment explaining necessity to use AddRange
for slider transform operations
2022-08-20 11:38:43 +09:00
OliBomby
65f7ecec83
moving all controlpoints at once for slider
2022-08-20 00:26:04 +02:00
OliBomby
91e6f4c4ee
fix TestPerfectCurveChangeToBezier
2022-08-19 19:31:47 +02:00
OliBomby
d1519343f6
Improved visual tests for slider splitting
2022-08-19 18:29:01 +02:00
Dean Herbert
339f0b0cd2
Merge branch 'master' into no-gameplay-clock-gameplay-offset
2022-08-19 23:01:09 +09:00
Jay L
c1da509119
round numerical value
...
this is painfully annoying me
2022-08-19 23:23:40 +10:00
Jay L
faf143b11a
fix comment
2022-08-19 23:15:38 +10:00
Dan Balasescu
4ef8e00a78
Merge pull request #19851 from peppy/update-framework
...
Update framework and resources
2022-08-19 22:03:55 +09:00
Jay L
b30fba1430
emc attribute
2022-08-19 22:57:40 +10:00
Jay L
fea31cc895
introduce effective misscount, accuracy rescale
2022-08-19 22:57:28 +10:00
Dean Herbert
7bf318541c
Reword comment to hopefully read better
2022-08-19 20:57:55 +09:00
Dean Herbert
c3c44c19cd
Use CompositeComponent
in various locations
2022-08-19 20:43:15 +09:00
Dean Herbert
41321521e5
Update resources
2022-08-19 20:40:05 +09:00
Dean Herbert
426c4c9bf7
Update framework
2022-08-19 20:39:53 +09:00
Dean Herbert
3f0da14065
Delay start operation by one frame to allow children to see initial start time
2022-08-19 17:39:51 +09:00
vun
f3e1287f04
Remove redundant using statement
2022-08-19 16:19:45 +08:00
vun
684efefb50
Add FirstHitObject as a property of encoding classes
2022-08-19 16:13:36 +08:00
vun
a26de0a10f
Add HitType property to MonoStreak
2022-08-19 16:05:34 +08:00
vun
51176e9577
Naming changes
2022-08-19 15:45:43 +08:00
vun
5dcd4ce7c5
Naming changes
2022-08-19 15:31:03 +08:00
Jamie Taylor
41408a3106
Add audio feedback for text selection
2022-08-19 15:51:27 +09:00
OliBomby
89eb0a4079
Added TestScene for slider splitting
2022-08-19 01:10:54 +02:00
its5Q
4c24d8ed58
Improve string consistency
2022-08-19 03:17:05 +10:00
Dean Herbert
e7d4962128
Merge branch 'master' into no-gameplay-clock-gameplay-offset
2022-08-19 01:50:14 +09:00
Dean Herbert
3eb1cda6aa
Reorganise call order of Start
/ Reset
to make more sense
2022-08-19 01:46:36 +09:00
Dean Herbert
15d49b0357
Update TestSceneSpectator
to user new assert style
2022-08-19 01:46:19 +09:00
Dean Herbert
1d774f3f12
Remove redundant ProcessFrame
calls
...
Of note, I'm not sure whether the `IsPaused` check was meaningful, but
it's not reimplemented in the new `FramedBeatmapClock`.
2022-08-19 01:39:02 +09:00
Dean Herbert
7bc96431a7
Remove unnecessary virtual
spec from GameplayClockContainer.Seek
2022-08-19 01:39:01 +09:00
Dean Herbert
0e228791c0
Remove unnecessary Reset
call in MultiSpectatorScreen
2022-08-19 01:39:01 +09:00
Dean Herbert
cc86909633
Increase lenience on TestSceneLeadIn
tests
...
I've gone through these in detail and can't find an issue with the
actual flow of things. For whatever reason, the new structure has a
slightly higher delay, likely due to performing less `Seek` calls
(previously a `Seek` was called after the clock start which may have
been making this more accurate on the first `Player.Update`).
I don't think it really matters that this is slightly off, but we'll see
how this plays out.
2022-08-19 01:39:00 +09:00
Bartłomiej Dach
bc851c174b
Merge pull request #19836 from peppy/split-offset-clock
...
Split `OffsetCorrectionClock` out of `MasterGameplayClockContainer`
2022-08-18 18:26:51 +02:00