1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-17 02:12:56 +08:00
Commit Graph

19 Commits

Author SHA1 Message Date
Bartłomiej Dach
079e687bee
Fix incorrect mock setup after refactor 2023-06-08 10:09:27 +02:00
Dean Herbert
a842f79ad4 Refactor IWorkingBeatmap.Background to GetBackground() 2023-06-08 16:19:32 +09:00
andy840119
5931e965c5 Mark background prams in the getMockWorkingBeatmap() as nun-nullable because technically it should not accept the null background. 2022-11-05 16:16:26 +08:00
andy840119
c8c76f2351 Use AsNonNull() because the type does not accept the null case. 2022-10-30 17:03:54 +08:00
andy840119
500bf90a34 Mark as accept the nullable stream. 2022-10-30 17:03:54 +08:00
andy840119
6ce3841686 Remove nullable disable annotation in the test case. 2022-10-30 17:03:54 +08:00
Dan Balasescu
b4e55f7309 Apply IRenderer changes 2022-08-02 19:50:57 +09:00
Dan Balasescu
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Dean Herbert
c7bc03e6f7 Add helper method for editor check tests 2021-11-24 14:22:41 +09:00
Dean Herbert
c2f8d9f677 Update tests which set Files lists directly 2021-11-24 14:00:14 +09:00
Naxesss
72ee2b1556 Refactor to avoid duplicate code 2021-11-10 06:18:40 +01:00
Naxesss
5dc6a9ed21 Add background stream closed test 2021-11-10 05:04:30 +01:00
Dean Herbert
d1e6d1cb98 Update some other missed incorrect null/empty usages 2021-11-04 14:50:43 +09:00
Naxess
19800f5f7f Move IBeatmap arg into context 2021-05-13 11:24:22 +02:00
Naxess
c13b93e6f1 Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks
This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.

See next commit for example.
2021-05-12 02:29:18 +02:00
Naxess
c0318a4d3e Fix usage of _ in Moq lambdas 2021-04-20 13:29:14 +02:00
Naxess
be6a02a17e Simplify background quality test names 2021-04-20 01:32:22 +02:00
Naxess
8656176ab8 Add the playable beatmap as check argument
This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor.

So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`.

This should be preferred over `workingBeatmap.Beatmap`.
2021-04-20 01:31:51 +02:00
Naxess
0502fbb429 Add background quality check tests 2021-04-18 01:21:51 +02:00