31 Commits

• Fix changing normal sample bank via keyboard hotkeys not updating addition bank if set to auto (#36741)

  Closes https://github.com/ppy/osu/issues/36703.
  
  It was only broken via keyboard hotkeys and not via the sample popover
  because the sample popover has a separate copy of the logic that didn't
  have the bug. Compare:
  
  
  https://github.com/ppy/osu/blob/13aeed15f95fa6585ff01eedaccc43b28ff656cb/osu.Game/Screens/Edit/Compose/Components/Timeline/SamplePointPiece.cs#L473-L475
  
  I considered splitting a helper to have one copy of the logic but it's
  not very simple to do compared to a two-liner fix so I gave up.

  Bartłomiej Dach · 2026-02-26 02:47:45 +09:00
  5174d8b918
• Fix tests
  Bartłomiej Dach · 2025-10-24 12:09:38 +02:00
  78eaad13ae
• Remove leftover [Solo] attribute
  Bartłomiej Dach · 2024-11-26 12:40:49 +01:00
  c69d36dc96
• Add failing test case showing changing selection in editor affects samples
  Dean Herbert · 2024-11-26 17:33:41 +09:00
  e0199386a3
• Fix TestHotkeysUnifySliderSamplesAndNodeSamples
  OliBomby · 2024-10-01 11:02:46 +02:00
  3769b0da5d
• Merge branch 'master' into additions
  Dean Herbert · 2024-10-01 16:38:56 +09:00
  1b4215576d
• fix test
  OliBomby · 2024-08-29 22:22:15 +02:00
  3a1afda2b3
• Merge remote-tracking branch 'upstream/master' into doubleclick
  OliBomby · 2024-08-29 19:34:18 +02:00
  ba0c4df2a9
• Merge remote-tracking branch 'upstream/master' into doubleclick
  OliBomby · 2024-08-20 23:19:27 +02:00
  ae6d855f8d
• Add failing test
  Bartłomiej Dach · 2024-08-20 12:36:05 +02:00
  3202c77279
• Merge branch 'master' into additions
  Dean Herbert · 2024-08-08 03:31:11 +09:00
  b5a19707d0
• Add test coverage for expected sample popover behaviour
  Bartłomiej Dach · 2024-07-24 12:08:13 +02:00
  55382a4ba6
• extend tests
  OliBomby · 2024-07-14 22:50:25 +02:00
  29c2e821ea
• update tests
  OliBomby · 2024-07-05 14:33:15 +02:00
  9013c119ab
• Add failing test coverage
  Bartłomiej Dach · 2024-07-05 08:54:47 +02:00
  d6c1b5d399
• Add test coverage
  OliBomby · 2024-07-04 15:25:43 +02:00
  00f7a34139
• Add failing test coverage for changing banks/samples not working on node samples
  Bartłomiej Dach · 2024-07-02 16:21:56 +02:00
  6453522b34
• Fix obsoletion warning
  Bartłomiej Dach · 2024-06-06 13:50:31 +02:00
  dd9c77d248
• Merge branch 'master' into edit-nodesample
  Bartłomiej Dach · 2024-06-06 13:42:25 +02:00
  86b13074a0
• Cast remaining test usages to IFocusManager to remove obsolete notice
  Dean Herbert · 2024-05-22 21:55:53 +08:00
  093be3d723
• fix focus test
  OliBomby · 2023-08-16 23:16:57 +02:00
  080d2b62f4
• Merge branch 'master' into edit-nodesample
  Dean Herbert · 2023-07-31 14:06:38 +09:00
  f06b203067
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• add new behaviour tests to TestSceneHitObjectSampleAdjustments
  OliBomby · 2023-06-02 00:40:00 +02:00
  035163a792
• Add test coverage of new hotkeys
  Dean Herbert · 2023-05-24 17:33:48 +09:00
  8e5ba2208d
• Update new usages of "soft" to use the new constant
  Dean Herbert · 2023-05-24 14:04:10 +09:00
  e68ba6366c
• Merge branch 'master' into sample-set-controls
  Dean Herbert · 2023-05-24 14:03:04 +09:00
  298989ffd2
• Add failing test case for sample undo
  Bartłomiej Dach · 2023-05-22 22:23:05 +02:00
  2ce150ba2b
• Add test coverage of failing sample bank transfer
  Dean Herbert · 2023-05-16 18:52:52 +09:00
  ebce39cd1c
• Rename editor sample adjustment test scene to increase scope of tests
  Dean Herbert · 2023-05-16 18:52:52 +09:00
  8528fcaedc