1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-07 18:07:28 +08:00
Commit Graph

54981 Commits

Author SHA1 Message Date
Dean Herbert
510972e3ad Avoid reference counting by using height calculation for IsPresent instead
The reference counting was to guarantee performance (zero allocations)
when the notification overlay was not required, but adds extra
complexity.

Instead, the toast tray now uses its ongoing height calculation as a
metric for presence.
2022-09-05 19:38:09 +09:00
Dean Herbert
0514c96191 Fix incorrect count tracking when notification is manually disposed 2022-09-05 19:26:40 +09:00
Dean Herbert
229e1a8ef7 Fix notification overlay being present when it doesn't need to 2022-09-05 19:13:58 +09:00
Dean Herbert
f754686521 Remove necessity of AlwaysPresent for ProgressUpdate completion posting 2022-09-05 19:13:58 +09:00
Dean Herbert
0d4ee6bd80 Centralise ability to fetch all toast tray notifications (including animating ones) 2022-09-05 18:42:20 +09:00
Dean Herbert
eca7b8f988 Fix completion notifications not always showing as toasts 2022-09-05 18:39:11 +09:00
Dean Herbert
56886fed09 Add test coverage of progress notification completions showing 2022-09-05 18:39:11 +09:00
Dean Herbert
4fa6707bf0 Set all progress notifications to non-important 2022-09-05 18:29:35 +09:00
Dan Balasescu
87e26e34b8
Merge pull request #20141 from peppy/fix-editor-timeline-sv-display
Fix incorrect slider length in timeline when non-default velocity is inherited from previous object
2022-09-05 17:51:25 +09:00
Dan Balasescu
764bb7a8e1
Merge pull request #20142 from peppy/fix-textbox-potential-crash
Fix textbox sample playback potentially crashing if called before load
2022-09-05 17:05:28 +09:00
Dean Herbert
f1d9b225a7
Remove probably pointless comment 2022-09-05 16:40:10 +09:00
Dean Herbert
2bec8b82b3 Fix textbox sample playback potentially crashing if called before load 2022-09-05 16:26:41 +09:00
Dean Herbert
8af8adf22d Fix incorrect slider length in timeline when non-default velocity is inherited from previous object 2022-09-05 16:17:26 +09:00
Dean Herbert
57954bb8f5 Enable nullability on TimelineHitObjectBlueprint 2022-09-05 14:50:43 +09:00
Dan Balasescu
07d4a025b0
Merge pull request #20109 from frenzibyte/online-play-room-status-inconsistency
Fix room status dropdown placement inconsistent between multiplayer and playlists
2022-09-05 11:19:56 +09:00
Salman Ahmed
cbc3627189
Merge pull request #19971 from peppy/remove-dispose-updates
Update `Remove`/`RemoveRange`/`RemoveAll` calls in line with framework changes
2022-09-03 17:38:17 +03:00
Salman Ahmed
ff4a051c05
Merge branch 'master' into remove-dispose-updates 2022-09-03 16:14:50 +03:00
Salman Ahmed
e8fa872f61 Fix room status dropdown position inconsistent on online-play screens 2022-09-03 16:14:21 +03:00
Salman Ahmed
b43995269a Dispose ScrollingTeams on removal 2022-09-03 15:17:51 +03:00
Salman Ahmed
778d767a12 Revert disposal on SectionsContainer properties 2022-09-03 15:02:57 +03:00
Dean Herbert
7364173fa9
Merge pull request #20093 from smoogipoo/dont-serialise-has-replay
Don't serialise `has_replay`
2022-09-02 18:00:01 +09:00
Dean Herbert
a7799e4f1e
Merge pull request #20092 from smoogipoo/bump-diffcalc-versions
Bump difficulty calculator versions
2022-09-02 17:11:36 +09:00
Dan Balasescu
b10026993a Don't serialise has_replay 2022-09-02 16:41:53 +09:00
Dean Herbert
8c50ccc48e Fix incorrect specification in SectionsContainer 2022-09-02 16:37:39 +09:00
Dean Herbert
a70fc10d06 Fix mock track construction failure 2022-09-02 16:30:04 +09:00
Dan Balasescu
9645bfe708 Bump difficulty calculator versions 2022-09-02 16:27:25 +09:00
Dean Herbert
d80151756c
Merge pull request #20070 from smoogipoo/replay-and-legacy-id
Add `has_replay` and `legacy_score_id` to `SoloScoreInfo`
2022-09-02 14:55:29 +09:00
Dan Balasescu
59ec94f1f4
Merge pull request #20079 from peppy/fix-update-progres-colour
Fix double colour application in update progress notification
2022-09-02 14:45:43 +09:00
Dan Balasescu
9024b57760
Merge pull request #20076 from peppy/fix-beat-sync-after-beatmap-change
Fix beat sync components stopping after beatmap change
2022-09-02 14:25:55 +09:00
Dean Herbert
d13e353a53 Fix double colour application in update progress notification
I'd like to restore it to yellow, but let's clean the slate first.
2022-09-02 03:03:35 +09:00
Dean Herbert
23d5e8b286 Fix beat sync components stopping after beatmap change
Not an amazing fix, but it seems to work and would rather get this in
ASAP rather than trying to fix at a framework level.

Closes #20059.
2022-09-01 23:46:02 +09:00
Dean Herbert
7eaa4c5ccd Update new usages of Remove / RemoveInternal 2022-09-01 23:05:34 +09:00
Dean Herbert
c9dec473d3 Update virtual track logic to match framework changes 2022-09-01 23:05:07 +09:00
Dean Herbert
22c18d9a81 Update framework 2022-09-01 23:03:28 +09:00
Dean Herbert
6a35b233e5 Merge branch 'master' into remove-dispose-updates 2022-09-01 23:03:19 +09:00
Dan Balasescu
e1e46ad7aa
Merge pull request #20073 from peppy/fix-tournament-lookup
Fix tournament population failure when beatmap is not found on server
2022-09-01 22:44:53 +09:00
Dan Balasescu
8b2652702a
Merge pull request #20072 from peppy/fix-seasonal-background-sticking
Fix seasonal background not being unloaded when changing setting to "Never"
2022-09-01 22:44:43 +09:00
Dean Herbert
d3ae60ec6d Fix tournament population failure when beatmap is not found on server 2022-09-01 22:03:01 +09:00
Dan Balasescu
5ca6395295
Merge pull request #20066 from peppy/fix-filtering-with-date-modes
Fix "date submitted" and "date ranked" filtering not working as intended
2022-09-01 22:01:49 +09:00
Dean Herbert
8866250cff Fix seasonal background not being unloaded when changing setting to "Never"
Closes #20065.
2022-09-01 21:42:40 +09:00
Dan Balasescu
a277431266 Add has_replay and legacy_score_id to SoloScoreInfo 2022-09-01 21:10:38 +09:00
Dean Herbert
1524623624 Fix back-to-front filter logic
Was copied across from a place which was checking for `match` and
applied verbatim to a place that was `filter`. Which are polar
opposites.
2022-09-01 19:59:27 +09:00
Dean Herbert
148e487c02 Add failing test of date submitted search failing 2022-09-01 19:59:27 +09:00
Dean Herbert
db9970b72a
Merge pull request #20047 from smoogipoo/multiplayer-auto-skip
Add auto skip for multiplayer rooms
2022-09-01 18:47:47 +09:00
Dan Balasescu
d70208fcf1 Default to off 2022-09-01 14:14:22 +09:00
Bartłomiej Dach
a4dc3fe412
Merge pull request #19984 from OliBomby/fix-merge-crash
Fixed merging circles at the same time causing a crash
2022-08-31 22:00:11 +02:00
Bartłomiej Dach
cd72f087b3
Merge branch 'master' into fix-merge-crash 2022-08-31 21:25:53 +02:00
Dean Herbert
3495215ed1
Merge pull request #20045 from nekodex/textbox-invalid-sfx
Add audio feedback for invalid textbox input
2022-08-31 23:58:10 +09:00
Dean Herbert
ba20044af4 Fix missing nullability consideraition 2022-08-31 23:24:39 +09:00
Dean Herbert
6af8143c8c Fix typing of new setting to allow it to be visible to tools export 2022-08-31 22:34:07 +09:00