123 Commits

• Add missing .
  Dean Herbert · 2024-09-09 18:09:28 +09:00
  63b6f36a29
• Move environment variable logic to static bool in OsuGameDesktop
  smallketchup82 · 2024-09-09 03:28:50 -04:00
  d451415d5c
• Merge branch 'master' into complete-disable-velopack
  smallketchup82 · 2024-09-08 21:33:50 -04:00
  bf3597f711
• Completely disable velopack when using external update manager
  smallketchup82 · 2024-09-08 01:17:18 -04:00
  4cf057db8f
• Fix windows check weirdness
  Dean Herbert · 2024-09-07 13:58:17 +09:00
  9b189fd244
• Fix file associations not updating & uninstalling
  smallketchup82 · 2024-09-06 16:16:40 -04:00
  575da0992f
• Make comment about velopack's init a bit more loud
  Dean Herbert · 2024-09-02 16:46:29 +09:00
  68e6fa286e
• Use full name
  Dean Herbert · 2024-09-02 13:08:14 +09:00
  b990af6ada
• Move setupVelo logic higher up
  smallketchup82 · 2024-07-04 17:33:05 -04:00
  9e01cf7fc2
• initial implementation
  smallketchup82 · 2024-06-26 15:25:41 -04:00
  0ee89183cc
• Avoid weird codestyle rules
  Dean Herbert · 2024-05-09 22:17:00 +08:00
  de05998421
• Apply adjustments after framework-side FriendlyGameName changes
  Bartłomiej Dach · 2024-04-29 13:00:22 +02:00
  45c2327509
• Upgrade to SDL3
  Susko3 · 2024-04-09 09:55:50 +02:00
  14c26926f3
• Fix NVAPI startup exception on non-Windows platforms
  Dan Balasescu · 2024-03-27 00:07:51 +09:00
  4c1a1b54be
• Merge pull request #27001 from Susko3/windows-file-uri-association

  Associate with files and URIs on windows

  Dean Herbert · 2024-03-01 11:26:44 +08:00
  91483bdc2f
• Update unsupported windows startup blocker comment
  Joseph Madamba · 2024-02-15 22:52:27 -08:00
  27ce965dd2
• Refactor public methods
  Susko3 · 2024-02-07 22:17:13 +01:00
  738c28755c
• Install associations as part of initial squirrel install
  Susko3 · 2024-02-07 21:56:39 +01:00
  f9d257b99e
• Make WindowsAssociationManager static

  Usages/localisation logic TBD

  Susko3 · 2024-02-07 21:55:42 +01:00
  eeba937686
• Move WindowsAssociationManager to osu.Desktop
  Susko3 · 2024-02-05 13:44:12 +01:00
  01efd1b353
• Uninstall associations when uninstalling from squirrel
  Susko3 · 2024-02-03 17:56:14 +01:00
  cdcf5bddda
• Update IPC usages

  Of note, I've disabled IPC on visual test runners as we generally don't
  use IPC in these cases. Having it set means that the game will not open
  while visual tests are open, which has been a complaint from devs in the
  past.

  Dean Herbert · 2024-01-18 19:45:36 +09:00
  82e7643df5
• Fix broken installer

  Closes https://github.com/ppy/osu/issues/26510.
  
  Time for a rant.
  
  Technically, this "broke" with 9e8d07d314,
  but it is actually an end result of upstream behaviours that I am
  failing to find a better description for than "utterly broken".
  
  Squirrel (the installer we use) has unit tests. Which is great, power
  to them. However, the method in which that testing is implemented leads
  to epic levels of WTF breakage.
  
  To determine whether Squirrel is being tested right now, it is checking
  all currently loaded assemblies, and determining that if any loaded
  assembly contains the magic string of "NUNIT" - among others - it must
  be being tested right now:
  
      https://github.com/clowd/Clowd.Squirrel/blob/24427217482deeeb9f2cacac555525edfc7bd9ac/src/Squirrel/SimpleSplat/PlatformModeDetector.cs#L17-L32
  
  If one assumes that there is no conceivable way that an NUnit assembly
  *may* be loaded *without* it being a test context, this *may* seem sane.
  Foreshadowing.
  
  (Now, to avoid being hypocritical, we also do this, *but* we do this
  by checking if the *entry* assembly is an NUnit:
  
      https://github.com/ppy/osu-framework/blob/92db55a52742047b42c0b4b25327ce28bd991b44/osu.Framework/Development/DebugUtils.cs#L16-L34
  
  which seems *much* saner, no?)
  
  Now, why did this break with 9e8d07d314
  *specifically*, you might wonder?
  
  Well the reason is this line:
  
      https://github.com/ppy/osu/blob/3d3f58c2523f519504d9156a684538e2aa0c094c/osu.Desktop/NVAPI.cs#L183
  
  Yes you are reading this correctly, it's not NVAPI anything itself that
  breaks this, it is *a log statement*. To be precise, what the log
  statement *does* to provoke this, is calling into framework. That causes
  the framework assembly to load, *which* transitively loads the
  `nunit.framework` assembly.
  
  (If you ever find yourself wanting to find out this sort of cursed
  knowledge - I hope you never need to - you can run something along
  the lines of
  
      dotnet-trace collect --providers Microsoft-Windows-DotNETRuntime:4 -- .\osu!.exe
  
  then open the resulting trace in PerfView, and then search the
  `Microsoft-Windows-DotNETRuntime/AssemblyLoader/Start` log for
  the cursed assembly. In this case, the relevant entry said something
  along the lines of
  
      HasStack="True"
      ThreadID="23,924"
      ProcessorNumber="0"
      ClrInstanceID="6"
      AssemblyName="nunit.framework, Version=3.13.3.0, Culture=neutral, PublicKeyToken=2638cd05610744eb"
      AssemblyPath=""
      RequestingAssembly="osu.Framework, Version=2024.113.0.0, Culture=neutral, PublicKeyToken=null"
      AssemblyLoadContext="Default"
      RequestingAssemblyLoadContext="Default"
      ActivityID="/#21032/1/26/"
  
  Either that or just comment the log line for kicks. But the above
  is *much* faster.)
  
  Now, what *happens* if Squirrel "detects" that it is being "tested"?
  Well, it will refuse to close after executing the "hooks" defined via
  `SquirrelAwareApp`:
  
      https://github.com/clowd/Clowd.Squirrel/blob/24427217482deeeb9f2cacac555525edfc7bd9ac/src/Squirrel/SquirrelAwareApp.cs#L85-L88
  
  and it will also refuse to create version shortcuts:
  
      https://github.com/clowd/Clowd.Squirrel/blob/24427217482deeeb9f2cacac555525edfc7bd9ac/src/Squirrel/UpdateManager.Shortcuts.cs#L63-L65
  
  Sounds familiar, don't it?
  
  There are days on which I tire of computers. Today is one of them.

  Bartłomiej Dach · 2024-01-13 22:04:21 +01:00
  1e3c332658
• Change threaded optimisations setting to "Auto" on startup
  Dean Herbert · 2024-01-03 15:41:08 +09:00
  d38f8d9c78
• Add NVAPI and force thread optimisations on

  This undoes what stable does to force this setting off.

  Dean Herbert · 2024-01-03 15:41:08 +09:00
  9e8d07d314
• Disable IPC binding in tournament client to allow running concurrently
  Dean Herbert · 2023-08-16 16:55:48 +09:00
  56a4989f71
• Remove nullable disable annotation and fix the api broken.
  andy840119 · 2022-08-02 22:29:54 +08:00
  78cc28d75f
• Isolate development builds' storage from release builds
  Dean Herbert · 2022-08-01 14:38:02 +09:00
  a5f48e336a
• Add mention of "compatibility mode" in windows version check error message
  Dean Herbert · 2022-07-19 17:25:52 +09:00
  09613f1af3
• Fix unsupported OS message stating Windows 8 to be supported
  Salman Ahmed · 2022-07-12 18:29:17 +03:00
  c046585842
• Change minimum version to Windows 8.1 instead of Windows 8
  Dean Herbert · 2022-07-12 16:16:46 +09:00
  a36f786725
• Show an error message on startup when attempting to run on an unsupported version of windows

  A lot of sentry error reports are coming from realm / EF failures due to the host operating system being too old. Let's give the user some proper feedback rather than a silent crash and error report hitting our logging.

  Dean Herbert · 2022-07-12 15:48:36 +09:00
  10a14f39ed
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Handle osu:// scheme links via IPC in desktop game
  Bartłomiej Dach · 2022-06-20 21:26:22 +02:00
  330af7ec74
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix app version not updating on windows uninstaller entry
  Joseph Madamba · 2022-06-10 20:01:45 -07:00
  e3418f570a
• Move exception soft-handling logic to OsuGameBase
  Salman Ahmed · 2022-05-10 10:02:32 +03:00
  bcd91ac743
• Fix windows taskbar context menu not popping up correctly

  Closes https://github.com/ppy/osu/issues/17965.
  
  Note that this will cause a second osu! icon to appear after running the
  application (after any update). As per the inline comment, this will
  eventually be resolved via https://github.com/clowd/Clowd.Squirrel/issues/24.
  
  I do think having context menus working is more important than duplicate
  icons.
  
  Note that for anyone who already has a pinned taskbar icon, it will need
  to be manually unpinned and repinned after a future update to actually
  fix this issue.
  
  Thanks to @caesay for help with investigation.

  Dean Herbert · 2022-04-25 18:37:41 +09:00
  7e9d51f33f
• Move uninstaller registry operation to onInitialInstall
  Dean Herbert · 2022-03-03 03:54:39 +09:00
  b286122413
• Add startup squirrel icon/association handling
  Dean Herbert · 2022-03-02 17:55:35 +09:00
  3aa2d4548a
• Fix incorrect flag to options conversion
  Dean Herbert · 2022-01-25 14:16:15 +09:00
  5872dabf60
• Update GetSuitableHost usages in line with new HostOptions
  Dean Herbert · 2022-01-25 13:52:02 +09:00
  dd2caea694
• Remove unnecessary StartAsync call on TcpIpcProvider
  Dean Herbert · 2021-12-16 19:53:22 +09:00
  c08b6cf160
• Move event handlign internal to LegacyTcpIpcProvider
  Dan Balasescu · 2021-11-28 23:02:57 +09:00
  4ee2063683
• Refactor
  Dan Balasescu · 2021-11-28 22:24:42 +09:00
  18a0a791fd
• Refactoring
  Dan Balasescu · 2021-11-28 21:31:22 +09:00
  36fffbd917
• Bind legacy IPC on startup
  Dan Balasescu · 2021-11-28 21:15:29 +09:00
  f506cb35bc
• Use IPC via TCP
  Dan Balasescu · 2021-11-28 18:24:00 +09:00
  ef24780642
• Use console IPC
  Dan Balasescu · 2021-11-28 14:03:21 +09:00
  e5dcfc3113
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486