Dean Herbert
f58c69e639
Fix potential startup crash due to early application of animations
...
This was always haphazard code, but by luck it never triggered before
drawable load until now. With the recently nullability changes, this
would be triggered when `flash` is not yet constructed.
Switching to `AddOnce` seems safer to avoid multiple applications,
regardless.
2023-07-28 17:17:15 +09:00
Bartłomiej Dach
3c923b9e81
Fix even more missed nullability-related inspections
2023-07-27 22:10:41 +02:00
Dean Herbert
fa4992f05a
Apply NRT and avoid throws from null RoundBeatmap.Beatmaps
2023-07-26 17:49:07 +09:00
Dean Herbert
04c1333b59
Merge pull request #24346 from cdwcgt/tournament-no-unload-cover
...
Use `DelayedLoadWrapper` in `TournamentBeatmapPanel` to avoid beatmap cover unload in map pool
2023-07-25 16:27:52 +09:00
Dean Herbert
7b3bd0b042
Reword comments to make more sense
2023-07-25 16:15:16 +09:00
cdwcgt
6f66e2fdd7
set LoadDelay to 0
2023-07-25 07:45:48 +09:00
Dean Herbert
e0c0797f55
Fix dodgy implementation of current bindable in DateTextBox
2023-07-25 01:46:45 +09:00
cdwcgt
fd4d3a6d66
Use DelayedLoadWrapper to avoid beatmap cover unload in map pool
2023-07-25 00:52:02 +09:00
Dean Herbert
34f53965c4
Never remove significant digits from stsar rating displays
...
Closes https://github.com/ppy/osu/issues/24079 .
2023-06-29 13:55:04 +09:00
Bartłomiej Dach
7d9d7066cd
Remove no-longer-needed BDL permitNulls spec
2023-06-25 17:39:15 +02:00
Bartłomiej Dach
9862992af0
Use alternative guard
...
Early-returning from ctors feels pretty bad. Also saves on some
nested accesses.
2023-06-25 17:37:05 +02:00
cdwcgt
a3cd0d14a3
null guard for Current Match in MatchMessage
2023-06-25 20:46:58 +09:00
Bartłomiej Dach
caf5673b68
Revert nullability enables in tournament client
...
Not trivial to fix right now and I'm not fixing in a 1k-line changeset.
2023-06-24 16:05:19 +02:00
Dean Herbert
2bda63c2c8
Merge branch 'master' into mass-nrt
2023-06-24 09:59:15 +09:00
Dean Herbert
df5b389629
Manual fixes to reduce warnings to zero
2023-06-24 01:52:53 +09:00
Dean Herbert
0ab0c52ad5
Automated pass
2023-06-24 01:00:03 +09:00
cdwcgt
2da8335da2
let team member color match their team color
2023-06-12 22:11:06 +09:00
Berkan Diler
08d2fbeb8e
Use new ArgumentNullException.ThrowIfNull throw-helper API
2022-12-22 21:27:59 +01:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Dan Balasescu
fa18b5f701
Construct notifications client inside ChannelManager
2022-11-04 18:51:00 +09:00
Dan Balasescu
58c6b026ae
Remove unused using
2022-11-02 15:23:11 +09:00
Dan Balasescu
fe66b20702
Fix one more case of constructing connector directly
2022-11-02 15:22:46 +09:00
Dan Balasescu
169bcc2654
Use polling connector in tests
2022-10-28 18:08:08 +09:00
Dan Balasescu
2f731f86ba
Adjust ChannelManager to use notifications client
2022-10-28 16:28:58 +09:00
Dean Herbert
1516756d8b
Fix team name not updating on TeamDisplay immediately
2022-07-13 18:10:27 +09:00
Dean Herbert
73e924479f
Find video by recursive check rather than marker interface
...
Seems a lot more reliable, and allows falling back to the "main" video
in cases which didn't support this previously.
A next step may be to allow every screen to support a video based on its
screen name, rather than specifying the local `TourneyVideo` every time.
2022-07-11 20:42:05 +09:00
Dean Herbert
31a447fda0
Update parameter discards
2022-06-24 21:26:19 +09:00
Dean Herbert
f3c9f9a216
Merge pull request #18751 from frenzibyte/tournament-beatmap
...
Improve tournament beatmap JSON storage using lightweight model
2022-06-18 11:00:26 +09:00
Salman Ahmed
4c47996130
TournamentPlayer -> TournamentUser
2022-06-18 02:33:26 +03:00
Salman Ahmed
9f97d1a7db
Replace tournament beatmap storage type with lightweight model
2022-06-18 01:34:09 +03:00
Salman Ahmed
b977ce7995
Replace tournament player storage type with lightweight model
2022-06-17 21:35:04 +03:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Bartłomiej Dach
f88c568c8d
Update flag sizes after switch to twemoji assets
...
The old flags used a size of 150x100, while the new assets based on
twemoji use a size of 150x108. Update existing usages to match this new
aspect ratio better.
2022-06-15 21:45:47 +02:00
Dean Herbert
c661f2b059
Ensure ChannelManager has access to API from point of construction
...
Closes https://github.com/ppy/osu/issues/18451 .
2022-06-08 19:15:23 +09:00
Dean Herbert
df4170b939
Display star ratings in tournament mode using two decimal places
2022-02-27 23:17:04 +09:00
Dean Herbert
297e5ec62e
Remove unused constants
2022-02-27 23:16:04 +09:00
Dean Herbert
5288eedd31
Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID
2022-01-27 15:38:03 +09:00
Salman Ahmed
b2d1bd029d
Turn on high poll rate when tournament chat is expanded
2022-01-22 16:34:57 +03:00
Susko3
19467e58c1
Remove unused params from BDL methods
2022-01-15 01:06:39 +01:00
Dean Herbert
e75e209053
Cache and consume IRulesetStore where feasible
2021-12-03 18:16:01 +09:00
Bartłomiej Dach
87d6a743dd
Migrate custom tournament client assets to uppercased directories
...
It has transpired that on filename-case-sensitive filesystems, the
tournament client does not consistently handle custom asset paths.
Videos and mods could only be looked up from `videos` and `mods`
directories (lowercase), while flags could only be looked up from the
`Flags` directory (uppercase).
A complicating circumstance is that default country flags, coming from
osu-resources, also depend on the flag lookup being uppercased.
To attempt to clean up the handling as much as it appears to be
possible, automatically move user-supplied lowercase directories to
uppercase.
2021-11-28 16:36:19 +01:00
Dean Herbert
bbd3ea5b77
Update all actual usages of RulesetInfo.ID to use OnlineID instead
2021-11-24 15:50:26 +09:00
Dean Herbert
86540d1fb6
Update existing usages of Author as string to access Username directly
2021-11-04 18:57:54 +09:00
Dean Herbert
b9983add15
Rename User to APIUser and move to correct namespace
2021-11-04 18:21:31 +09:00
Dean Herbert
10a9266956
Fix beatmap creator showing twice in tournament map pool panels
2021-11-01 14:33:24 +09:00
Dean Herbert
6f5040722a
Merge branch 'master' into beatmap-refactor/uncontested
2021-10-28 16:37:26 +09:00
smoogipoo
313f78cbfb
Fix non-null inspection
2021-10-28 15:24:44 +09:00
Dean Herbert
f3d208fecf
Remove TODO (tested to work correctly)
2021-10-28 14:48:36 +09:00
Dean Herbert
7245baba69
Remove IBeatmapSetOnlineInfo implementation from BeatmapSetInfo to avoid null cases
2021-10-28 00:50:45 +09:00
Dean Herbert
f1499641f3
Rename all usages of APIBeatmap to beatmap in tournament namespace
2021-10-27 18:42:48 +09:00
