75050 Commits

This Branch

This Branch

All Branches

• Merge branch 'master' into pinned-rooms
  Dean Herbert · 2025-09-01 16:01:50 +09:00
  4e976cff6a
• Merge pull request #34837 from smoogipoo/more-testable-footers

  Add footer to `ScreenTestScene`

  Dean Herbert · 2025-08-30 21:52:30 +09:00
  c26e669fc5
• Merge pull request #34841 from peppy/interpolate-more

  Adjust interpolation workaround to catch-up slightly smoother

  Dean Herbert · 2025-08-29 22:04:20 +09:00
  2025.829.0-tachyon e621eed0ba
• Adjust interpolation workaround to catch-up slightly smoother
  Dean Herbert · 2025-08-29 21:24:23 +09:00
  41b8033ebd
• Merge pull request #34836 from bdach/online-lookups-on-reenter

  Fix song select not performing online lookup on re-enter

  Dean Herbert · 2025-08-29 21:21:34 +09:00
  1d9de88aaa
• Merge branch 'master' into online-lookups-on-reenter
  Dean Herbert · 2025-08-29 19:03:41 +09:00
  3ca5e20e70
• Merge pull request #34822 from bdach/carousel-multi-grouping-clean
  Dean Herbert · 2025-08-29 19:02:58 +09:00
  404044e8d7
• Merge pull request #34830 from minetoblend/fix/hitobject-lifetime-delay

  Fix hitobject drawables becoming visible 1 frame too late

  Dan Balasescu · 2025-08-29 18:38:24 +09:00
  d5575b4037
• Move footer to ScreenTestScene
  Dan Balasescu · 2025-08-29 17:49:48 +09:00
  04ba5aa575
• Merge branch 'master' into carousel-multi-grouping-clean
  Bartłomiej Dach · 2025-08-29 10:41:46 +02:00
  51ed19cb99
• Fix tournament test failure due to control change
  Dean Herbert · 2025-08-29 17:12:24 +09:00
  0a408a3ac4
• Merge pull request #34833 from peppy/fix-mod-cosmetics

  Fix some mods showing tooltips when settings are default

  Dean Herbert · 2025-08-29 17:09:01 +09:00
  22ba956f25
• Apply suggested rename
  Bartłomiej Dach · 2025-08-29 09:58:56 +02:00
  526ee32268
• Fix song select not performing online lookup on re-enter

  Closes https://github.com/ppy/osu/issues/34825.
  
  Root cause is
  
  	https://github.com/ppy/osu/blob/24ec43b3b65fa3b164b7713341cd62b1e0dacc2e/osu.Game/Screens/SelectV2/SongSelect.cs#L345-L356
  
  not specifying `(..., true)`, therefore the fetch doesn't happen on
  enter if song select doesn't change the global beatmap as a side effect
  of the enter, which is the case on re-entering.

  Bartłomiej Dach · 2025-08-29 09:31:20 +02:00
  df6d6edaca
• Merge pull request #34834 from peppy/tournament-warmup-better

  Use switches for warmup/chat toggles in tournament interface

  Bartłomiej Dach · 2025-08-29 09:09:20 +02:00
  24ec43b3b6
• Fix obviously incorrect conditional

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2025-08-29 16:01:49 +09:00
  9e77a5b050
• Use switches for warmup/chat toggles in tournament interface

  As proposed in https://github.com/ppy/osu/discussions/32515.

  Dean Herbert · 2025-08-29 14:35:42 +09:00
  12832e9fef
• Fix some mods showing tooltips when settings are default
  Dean Herbert · 2025-08-29 14:08:18 +09:00
  e83f3d5e77
• Return early to avoid creating mod description strings unnecessarily
  Dean Herbert · 2025-08-29 14:08:06 +09:00
  f2f5cf19a2
• Fix operations in PooledDrawableWithLifetimeContainer.CheckChildrenLife being in wrong order

  Previously CompositeDrawable.CheckChildrenLife() would be run before lifetimeManager.Update() which lead to the new drawables being inserted into the container but not being made alive immediately, leading to the drawable not becoming visibile until the next update loop.

  marvin · 2025-08-28 23:36:29 +02:00
  bb9f9e4d35
• Merge pull request #34774 from genskyff/feat/long-note-ratio

  Add long note percentage filter for mania mode

  Bartłomiej Dach · 2025-08-28 14:32:52 +02:00
  6e1316241a
• Merge pull request #34808 from peppy/fix-difficulty-churn

  Fix beatmap carousel triggering full filters more often than it needs to

  Bartłomiej Dach · 2025-08-28 14:26:25 +02:00
  3eaa5314ac
• Adjust tests to new beatmap set model usage in carousel
  Bartłomiej Dach · 2025-08-28 13:09:11 +02:00
  6ba72fa481
• Support beatmap sets being split apart by the active group mode in beatmap carousel
  Bartłomiej Dach · 2025-08-28 13:09:08 +02:00
  8dd131f17e
• Ensure filtering also runs after local gameplay LastPlayed changes
  Dean Herbert · 2025-08-28 19:10:20 +09:00
  7e109add96
• Merge pull request #34740 from bdach/maximised-player-audio

  Always use audio from maximised player if there is one in multiplayer spectator

  Dean Herbert · 2025-08-28 18:27:56 +09:00
  f953d58922
• Add failing test coverage of splitting beatmap sets apart
  Bartłomiej Dach · 2025-08-28 11:00:23 +02:00
  47164c61b4
• Adjust test after allowing grouping modes to split beatmap sets apart
  Bartłomiej Dach · 2025-08-28 11:00:23 +02:00
  311c75aa53
• Merge pull request #34818 from smoogipoo/completion-handler-override

  Preserve pre-post notification completion target

  Dean Herbert · 2025-08-28 14:10:59 +09:00
  0b40f1d0db
• Preserve pre-post notification completion target
  Dan Balasescu · 2025-08-28 13:07:05 +09:00
  e831d1b6fa
• Merge branch 'master' into fix-difficulty-churn
  Dean Herbert · 2025-08-28 02:38:10 +09:00
  ed15e1fb88
• Merge pull request #34812 from bdach/failed-at-judgement

  Fix `HealthProcessor` potentially incorrectly reverting failed state

  Dean Herbert · 2025-08-28 02:37:44 +09:00
  33b99a51b1
• Fix hidden beatmap state not being reflected immediately
  Dean Herbert · 2025-08-28 02:33:18 +09:00
  8a6c857719
• Merge pull request #34809 from peppy/fix-star-rating-weird-mod-double-handling

  Fix beatmap panels locally handling mod and ruleset changes unnecessarily

  Dean Herbert · 2025-08-28 01:27:31 +09:00
  5abd93eda7
• Allow grouping modes that apply max aggregate to split beatmap sets apart
  Bartłomiej Dach · 2025-08-27 14:45:20 +02:00
  4030383276
• Apply in more places
  Dean Herbert · 2025-08-27 19:59:44 +09:00
  f9c1b24df4
• Fix HealthProcessor potentially incorrectly reverting failed state

  This stems from me looking into `TestSceneFailAnimation` failures
  (https://github.com/ppy/osu/runs/48663953318). As it turns out, I should
  not have been mad by CI, and rather should have been mad at myself for
  failing to read.
  
  `FailedAtJudgement` in fact does not mean "this judgement, and only this
  judgement, triggered failure". If any further judgements occur
  post-fail, they will also have `FailedAtJudgement` set to true. It is
  essentially a *dump* of the state of `HealthProcessor.Failed` prior to
  applying the judgement.
  
  	https://github.com/ppy/osu/blob/ec21685c2531af3b243f7f0833ffbb340bf3c044/osu.Game/Rulesets/Scoring/HealthProcessor.cs#L49-L57
  
  Because of this, reverting several judgements which occur post-fail
  could lead to failed state reverting earlier than intended, and thus
  potentially trigger a second fail, thus tripping the `Player` assertion.

  Bartłomiej Dach · 2025-08-27 12:27:11 +02:00
  197c318180
• Fix beatmap panels locally handling mod changes unnecessarily

  The `BeatmapDifficultyCache` handles mod changes, so handling locally is
  unnecessary. By handling locally, it creates a visual issue when
  adjusting mods often. Test using Ctrl +/- at song select and observing
  that without this change, the star rating will flicker back to the
  default due to the local re-fetch.

  Dean Herbert · 2025-08-27 18:31:50 +09:00
  fda40d7fd5
• Fix beatmap carousel re-filtering when it doesn't need to

  Local rules ensure we only handle callbacks when we need to.

  Dean Herbert · 2025-08-27 18:21:19 +09:00
  be6fb9aa77
• Avoid triggering changes when add operations are empty

  Only seems to happen in tests. I think.

  Dean Herbert · 2025-08-27 18:13:13 +09:00
  0e57ee9ba6
• Add test coverage ensuring filtering does not occur on unnecessary updates
  Dean Herbert · 2025-08-27 18:13:12 +09:00
  043235fed2
• Merge pull request #34803 from peppy/update-framework-please-no-clock-breakage

  Update framework

  Dean Herbert · 2025-08-27 13:23:09 +09:00
  2025.827.0-tachyon ec21685c25
• Update framework
  Dean Herbert · 2025-08-26 21:43:09 +09:00
  244bad07c7
• test(ManiaFilterCriteriaTest): simplify test case
  Binwalker · 2025-08-26 21:36:20 +09:00
  149f18c3f5
• refactor(ManiaFilterCriteria): exclude converted beatmaps from long note filter
  Binwalker · 2025-08-26 21:36:20 +09:00
  6a82b7331f
• test(ManiaFilterCriteriaTest): fix some test case for ln filter
  Binwalker · 2025-08-26 21:36:20 +09:00
  65253708d8
• fix(ManiaFilterCriteria): converted beatmaps are not included
  Binwalker · 2025-08-26 21:36:20 +09:00
  556c2469bf
• test(ManiaFilterCriteriaTest): add some testcase
  Binwalker · 2025-08-26 21:36:20 +09:00
  f7b0e114a9
• feat(ManiaFilterCriteria): add long note ratio filter for mania
  Binwalker · 2025-08-26 21:36:19 +09:00
  68677200f3
• Merge pull request #34802 from bdach/hack-around-carousel-panel-refresh

  Work around excessive refreshes of carousel beatmap set panel backgrounds

  Dean Herbert · 2025-08-26 21:13:28 +09:00
  2bea59e65f