3086 Commits

• Change userBeatmapOffsetClock to a FramedOffsetClock

  Assuming that the global audio offset is set perfectly, such that
  any audio latency is fully accounted for, if a specific beatmap
  still sounds out of sync, that would no longer be a latency issue.
  
  Instead, it would indicate a misalignment between the beatmap's
  track and time codes, the correction for which should be a
  virtual-time offset, not a real-time offset.

  Mike Will · 2024-02-19 09:14:49 -05:00
  012d6b7fe1
• Fix beatmap potentially loading in a bad state

  Over-caching could mean that a beatmap could load and cause a late
  crash. Let's catch it early to avoid such a crash occurring.

  Dean Herbert · 2024-02-19 17:18:07 +08:00
  7f82f10317
• Merge branch 'master' into judgements-rework
  Andrei Zavatski · 2024-02-16 20:08:57 +03:00
  dd32c0a226
• Only apply set-level metadata after all difficulties have been processed
  Bartłomiej Dach · 2024-02-12 12:08:51 +01:00
  138fea8c38
• Only check online matching when determining whether to save online metadata

  After https://github.com/ppy/osu/pull/23362 I'm not sure the
  `LocallyModified` check is doing anything useful. It was confusing me
  really hard when trying to parse this logic, and it can misbehave (as
  `None` will also pass the check).

  Bartłomiej Dach · 2024-02-12 12:07:20 +01:00
  87702b3312
• Refuse to apply online metadata in the most dodgy scenarios
  Bartłomiej Dach · 2024-02-12 11:43:41 +01:00
  4f0ae4197a
• Don't convert pixel data to array
  Andrei Zavatski · 2024-02-11 17:44:54 +03:00
  5e692345de
• Move init method to bottom of file
  Dean Herbert · 2024-02-11 20:05:58 +08:00
  7dba21fdac
• Merge branch 'master' into refactor-metadata-lookup-sources
  Dean Herbert · 2024-02-10 14:43:51 +08:00
  01501f3b82
• Cache created judgement in HitObject
  Andrei Zavatski · 2024-02-09 23:20:31 +03:00
  c500264306
• Use new LINQ Order() instead of OrderBy() when possible
  Berkan Diler · 2024-02-08 18:01:00 +01:00
  6adf0ac01e
• Update R# + fix inspections
  Dan Balasescu · 2024-02-02 21:00:28 +09:00
  b44f77cee1
• Merge branch 'master' into dont-round-sv
  Dean Herbert · 2024-01-26 19:16:58 +09:00
  cf97cb1e0c
• Merge pull request #26605 from peppy/simplify-gameplay-pause

  Simplify gameplay pause sequence

  Bartłomiej Dach · 2024-01-22 08:49:08 +01:00
  493d495992
• Remove rounding of slider velocity (when applied as scroll speed)

  This affects both osu!taiko and osu!mania.
  
  Closes https://github.com/ppy/osu/issues/25862.

  Dean Herbert · 2024-01-18 18:37:44 +09:00
  c9945b41c1
• Remove "pause rate adjust" flow
  Dean Herbert · 2024-01-18 14:21:02 +09:00
  8ab8c90e33
• Fix ConstrainedIconContainer always using masking
  Andrei Zavatski · 2024-01-18 04:06:02 +03:00
  42e4c933d3
• Change default values of new object counts to -1 to identify non-processed values
  Dean Herbert · 2023-12-19 18:20:02 +09:00
  f09c6b8c1b
• Also populate ObjectCounts when running a full beatmap process

  Saves running things twice on an old install

  Dean Herbert · 2023-12-18 18:41:41 +09:00
  bfa90e9dcb
• Fix StarRatingDisplay's display width to avoid text making slight autosize changes
  Dean Herbert · 2023-12-15 16:00:03 +09:00
  dc5c9837ed
• Fix InverseDifficultyRange() not working correctly in both directions
  Bartłomiej Dach · 2023-12-14 20:41:12 +01:00
  c0e68df20f
• Implement inverse of IBeatmapDifficultyInfo.DifficultyRange()
  Bartłomiej Dach · 2023-12-14 20:41:12 +01:00
  24e31f7d91
• Move object counts to BeatmapInfo
  Dan Balasescu · 2023-12-13 17:33:24 +09:00
  0171078052
• Add object counts to IBeatmapDifficultyInfo
  Dan Balasescu · 2023-12-09 22:31:51 +09:00
  767d5c8018
• Move constant local to taiko
  Dean Herbert · 2023-12-06 15:59:34 +09:00
  1b50d1011a
• Fix incorrect slider velocity being written on export for osu!taiko beatmaps
  Dean Herbert · 2023-12-06 15:59:34 +09:00
  b5bae566c2
• Change default slider velocity to 1.4

  This is the default in osu!stable and plays better than 1.0.

  Dean Herbert · 2023-12-06 13:38:46 +09:00
  0af16732b8
• Fix change in filter behaviour
  Dean Herbert · 2023-12-05 18:20:27 +09:00
  8704dc3505
• Avoid list construction when doing filtering
  Dean Herbert · 2023-12-05 15:26:14 +09:00
  42010574b5
• Merge pull request #25552 from peppy/fix-r#-inpsections

  Fix a couple of new r# inspections

  Bartłomiej Dach · 2023-11-24 11:04:08 +09:00
  02c794cc1f
• Enable NRT on Beatmap
  Dean Herbert · 2023-11-23 17:28:16 +09:00
  268b965ee8
• Fix a couple of new r# inspections
  Dean Herbert · 2023-11-23 17:11:40 +09:00
  a80a5be4ec
• Merge branch 'master' into fix-combo-handling
  Dan Balasescu · 2023-11-23 16:22:01 +09:00
  7bc2d6e6cd
• Fix combo/combo colouring issues around spinners
  Dan Balasescu · 2023-11-23 13:54:05 +09:00
  7998204cfe
• Fix first object after break not starting a new combo
  Dan Balasescu · 2023-11-22 17:22:48 +09:00
  cb4568c4a1
• Merge branch 'master' into bspline-sliders
  Bartłomiej Dach · 2023-11-20 12:03:29 +09:00
  b6e3e42445
• Fix code style/quality issues
  cs · 2023-11-13 08:25:27 +01:00
  fa976a5aa0
• CI Fixup
  cs · 2023-11-11 15:02:06 +01:00
  54b8244a18
• Generalize Bezier curves to BSplines of Nth degree
  Thomas Müller-Höhne · 2023-11-11 13:32:53 +01:00
  926636cc03
• Refactor everythign back to sanity
  Dean Herbert · 2023-11-09 22:31:28 +09:00
  615d8384ab
• Merge pull request #25167 from peppy/fix-circle-radius

  Fix circle scale not matching stable due to missing multiplier

  Bartłomiej Dach · 2023-10-20 20:59:53 +02:00
  c58a47760e
• Move helper method to LegacyRulesetExtensions and stop applying rounding allowance to catch

  As discussed, it isn't used in stable like this. Was a mistake.

  Dean Herbert · 2023-10-20 18:57:14 +09:00
  3fb74cb5f9
• Fix insufficient leniency when querying sample points
  Bartłomiej Dach · 2023-10-20 10:26:16 +02:00
  c89081589c
• Use DifficultyRange helper method in one more place
  Dean Herbert · 2023-10-18 23:54:18 +09:00
  040d0970f2
• Centralise and repair circle size calculations game-wide
  Dean Herbert · 2023-10-18 19:50:42 +09:00
  3a5490892c
• Fix various other inspections
  Dean Herbert · 2023-10-17 17:48:51 +09:00
  e081fa48a2
• Fix beatmaps with no preview point set getting incorrect default

  Note that this will require a re-import to fix existing beatmaps
  becuse.. it's stored to realm. Probably not worth worrying about for
  now.

  Dean Herbert · 2023-10-10 19:13:16 +09:00
  2781846147
• Fix double interpolation being applied when applyOffsets=false
  Dean Herbert · 2023-10-05 13:20:52 +09:00
  f8455af0d0
• Merge branch 'master' into clock-fix-attempt-2
  Dean Herbert · 2023-10-04 16:57:49 +09:00
  5a17a86d1d
• Don't show replay import "missing beatmap" notifications during stable import

  Closes https://github.com/ppy/osu/issues/24926.

  Dean Herbert · 2023-09-27 17:04:43 +09:00
  2481c0b64b