2628 Commits

Author	SHA1	Message	Date
Guido	8756dd25c6	Changed file chooser in resource selection to show file name when file is selected	2023-12-04 22:51:56 +01:00
Dean Herbert	340227a06d	Replace all hexacon lookups with strongly typed properties	2023-11-24 13:17:39 +09:00
Dean Herbert	21bf288277	Merge pull request #25520 from peppy/context-menu-spacers ... Allow context menus to have visible spacers	2023-11-21 16:56:36 +09:00
Bartłomiej Dach	d83b2e24e7	Merge pull request #25371 from RatinFX/open-editor-timestamp ... Implement opening editor timestamp links	2023-11-21 15:48:36 +09:00
Dean Herbert	7c5345bf7e	Use SimpleErrorNotification for error display	2023-11-21 15:10:41 +09:00
Dean Herbert	917a68eac3	Adjust localisablel strings and keys	2023-11-21 15:08:15 +09:00
Dean Herbert	405ab499e9	Allow context menus to have visible spacers	2023-11-21 14:24:10 +09:00
Bartłomiej Dach	b6215b2809	Rename and document SelectFromTimestamp	2023-11-20 21:57:14 +09:00
Bartłomiej Dach	234ef6f923	Rectify selection keep-alive logic	2023-11-20 21:57:14 +09:00
Bartłomiej Dach	246aacb216	Remove unnecessary guard ... Setting a bindable's value to something if that value is already there is a no-op (doesn't trigger bindings / callbacks).	2023-11-20 21:57:14 +09:00
Bartłomiej Dach	0e0ab66148	Simplify parsing code ... Less methods, less smeared around logic, saner data types.	2023-11-20 21:57:12 +09:00
ratinfx	4e1e19728c	Refactor HitObject selection in Composer	2023-11-11 14:02:42 +01:00
Dean Herbert	35e11c7c63	Rename diagonal scale variable and update xmldoc	2023-11-10 17:55:02 +09:00
Dean Herbert	ec3b6e47fb	Change selection handling to adjust Size instead of Scale for edge nodes	2023-11-10 14:22:28 +09:00
ratinfx	544d5d1d86	Forgot a clock.Stop call	2023-11-07 12:23:22 +01:00
ratinfx	bdbeb2bce4	Renamed CollectionChanged event handler	2023-11-07 11:11:32 +01:00
ratinfx	aa87e0a44d	HitObject Selection logic and separation for gamemodes ... + moved time_regex into EditorTimestampParser	2023-11-07 01:36:58 +01:00
ratinfx	44f127c8a8	Renamed method and made private	2023-11-07 01:02:45 +01:00
ratinfx	0834b79cc7	Renamed method and moved Notifications inside	2023-11-07 00:56:24 +01:00
Salman Ahmed	b2749943e2	Display "required save" popup when creating another difficulty on a new beatmap	2023-11-06 21:54:40 +03:00
Dean Herbert	51c891e2e4	Automatically refresh the verify screen's issue list on re-entering it ... Addresses https://github.com/ppy/osu/discussions/25365.	2023-11-06 19:34:36 +09:00
ratinfx	277cf7dc12	Ensure every SelectedItem is alive and has Blueprint	2023-11-05 18:26:51 +01:00
ratinfx	7492d953ae	Moved error checks into Editor ... - Invoke Action on error to Notify user - added some comments	2023-11-04 21:17:58 +01:00
ratinfx	60f62faec3	Renamed Editor method	2023-11-04 03:30:38 +01:00
ratinfx	43ab7f4942	Added OpenEditorTimestamp base implementation	2023-11-04 02:01:18 +01:00
Bartłomiej Dach	850866e7f4	Merge pull request #25316 from peppy/metronome-always-play-tick ... Decouple metronome tick playback from pendulum movement	2023-10-31 09:37:29 +01:00
Bartłomiej Dach	144006fbe8	Update autoselect implementation to work correctly with framework changes	2023-10-31 08:38:22 +01:00
Bartłomiej Dach	8a68333425	Merge branch 'master' into beat-divisor-select-text-on-click	2023-10-31 08:36:53 +01:00
Dean Herbert	64efc3d251	Decouple metronome tick playback from pendulum movement ... Not super happy about doing this, but it seems like it's in the best interest of editor usability.	2023-10-31 15:33:46 +09:00
Dean Herbert	f706fd2fca	Merge pull request #25307 from bdach/slider-velocity-undo ... Fix slider velocity changes not being undone correctly	2023-10-31 01:44:18 +09:00
Bartłomiej Dach	cea24298cb	Privatise setters	2023-10-30 12:42:34 +01:00
Bartłomiej Dach	de89b7e53c	Fix slider velocity changes not being undone correctly ... Closes https://github.com/ppy/osu/issues/25239. `LegacyEditorBeatmapPatcher.processHitObjectLocalData()` was already supposed to be handling changes to hitobjects that will show up neither when comparing the hitobjects themselves or the timing point with "legacy" info stripped - so, in other words, changes to slider velocity and samples. However, a change to slider velocity requires default application to take effect, so just resetting the value would visually fix the timeline marker but not change the actual object. Calling `EditorBeatmap.Update()` fixes this by way of triggering default re-application. This could probably be smarter (by only invoking the update when strictly necessary, etc.) - but I'm not sure it's worth the hassle. This is intended to be a quick fix, rather than a complete solution - the complete solution would indeed likely entail a wholesale restructuring of the editor's change handling.	2023-10-30 10:59:02 +01:00
Dean Herbert	63e6eaf538	Fix failing tests	2023-10-30 18:06:11 +09:00
Dean Herbert	57d88a0ac4	Fix right clicks on timeline objects potentially getting eaten by playfield area ... `SelectionHandler` is receiving input from anywhere out of necessity: 19f892687a/osu.Game/Screens/Edit/Compose/Components/SelectionHandler.cs (L119-L125) Also important is that `BlueprintContainer` will selectively not block right clicks to make sure they fall through to the `ContextMenuContainer`: 19f892687a/osu.Game/Screens/Edit/Compose/Components/BlueprintContainer.cs (L122-L126) But because the whole editor is sharing a `ContextMenuContainer` and it's at a higher level than both components, we observe here the playfield's `SelectionHandler` intercepting the right click before it can reach the `ContextMenuContainer`. The fix here is similar to what we're already doing in `TimelineBlueprintContaienr`.	2023-10-30 18:06:11 +09:00
Dean Herbert	6934e045df	Fix editor not prompting before saving beatmap for export	2023-10-25 14:39:46 +09:00
Bartłomiej Dach	12282fff5c	Disallow setting sample volume lower than 5% in editor	2023-10-20 15:50:21 +02:00
Dean Herbert	52c2eb93de	Merge branch 'master' into taiko-beat-snap-grid	2023-10-19 23:53:01 +09:00
Dean Herbert	5341a335a6	Bypass Parent nullability checks for now	2023-10-17 17:48:45 +09:00
Dean Herbert	2a89a25790	Add beat snap grid to osu!taiko editor ... Addresses https://github.com/ppy/osu/discussions/25150.	2023-10-17 16:59:56 +09:00
Dean Herbert	1b9acdf55c	Abstract out common implementation of BeatSnapGrid	2023-10-17 16:42:52 +09:00
Dean Herbert	1005b7ac85	Fix incorrect test assumption in TestSceneEditorClock ... I don't know what this test was trying to do, but it was wrong. Any offset which is applied should be invisible to the clock's final `CurrentTime` (and to the user).	2023-10-06 16:43:28 +09:00
Dean Herbert	354193c53a	Merge branch 'master' into clock-fix-attempt-2	2023-10-06 16:43:27 +09:00
Dean Herbert	61fd4186af	Ensure regenerateDisplay is eventually performed if originally called before load	2023-10-05 22:55:23 +09:00
Dean Herbert	76cc2f9f22	Fix WaveformComparisonDisplay potentially crashing on invalid track length ... As seen at https://github.com/ppy/osu/runs/17415814918#r0s2.	2023-10-05 14:58:55 +09:00
Dean Herbert	5a17a86d1d	Merge branch 'master' into clock-fix-attempt-2	2023-10-04 16:57:49 +09:00
Dean Herbert	7908b36b39	Flash dialog popup when attempting to exit editor while exit is being blocked	2023-09-28 15:25:39 +09:00
Dean Herbert	faa0481fc6	Fix editor operating directly on track rather than decoupled clock	2023-09-22 16:22:36 +09:00
Dean Herbert	df08c4e1ad	Disable decoupling for OsuGameBase's beatmap implementation ... This avoids it ever mutating the underlying track (aka attempting to start it). Resolves the one caveat mentioned in aeef92fa710648d4a00edc523e13c17ac6104125.	2023-09-22 12:49:25 +09:00
Dean Herbert	600651795b	Change FramedBeatmapClock to always be decoupled	2023-09-22 12:49:25 +09:00
Salman Ahmed	9e4a56d64e	Merge branch 'master' into update-framework	2023-09-21 19:49:20 +03:00