Bartłomiej Dach
4c5dacd559
Merge pull request #26770 from peppy/fucking-hitobject-references
...
Fix `OsuPlayfield` being retained indefinitely after gameplay
2024-01-29 09:40:56 +01:00
Dean Herbert
48fc0545c2
Merge pull request #26724 from bdach/decouple-notification-websocket-from-chat
...
Decouple notifications websocket handling from chat operations
2024-01-29 16:57:13 +09:00
Dean Herbert
ef94eff574
Rename PollingChatClientConnector to better describe usage
2024-01-29 16:56:28 +09:00
Dean Herbert
fb24c66342
Mark ResultsScreen.Score as nullable
...
Is nullable in playlist results at very least.
2024-01-29 16:43:26 +09:00
Dean Herbert
760368709a
Mark some delegates as static because we can
2024-01-29 16:16:28 +09:00
Dean Herbert
eb90ee5415
Add safety in ResultsScreen.Exit to ensure HitEvents are not holding references
...
This is a catch-all safety disconnecting `ScoreInfo` from `HitObject`s.
2024-01-29 16:16:17 +09:00
Dean Herbert
76832a1495
Remove ScorePerformanceCache
...
This class was only used in two places, both on the results screen, but
was holding references to `OsuPlayfield` game-wide (due to unrelated
issues, but still).
Because I can't really think of future use cases for this, and running
the calculation twice at results screen isn't a huge overhead, let's
just do that for now to keep things simple.
2024-01-29 15:28:20 +09:00
Dean Herbert
de32e7815b
Clean up DrawableHitObject events on Dispose
...
This is just general safeties to avoid cases where
components don't correctly unbind events.
2024-01-29 15:28:20 +09:00
Dean Herbert
462dab3c90
Remove unnecessary bindable
2024-01-29 02:13:39 +09:00
Dean Herbert
f4dd84fa77
Fix various inconsistencies and document better
2024-01-29 02:10:33 +09:00
Dean Herbert
23f12e1ea3
Should not be a container
2024-01-29 01:50:27 +09:00
Andrei Zavatski
b48f99ba4b
Stop using SliderBar as a base
2024-01-28 18:06:09 +03:00
Andrei Zavatski
ed9e0fe1db
Merge branch 'master' into progress-bar-improvements
2024-01-28 17:59:29 +03:00
Andrei Zavatski
9d73d0e04d
Clamp logo triangles along both axes
2024-01-27 19:06:04 +03:00
Dean Herbert
4c34d2e352
Update framework
2024-01-27 20:21:27 +09:00
Dean Herbert
3cad5fe292
Merge pull request #26704 from peppy/new-logo
...
Update logo
2024-01-27 19:34:22 +09:00
Andrei Zavatski
3387565ba9
Fix song progress value may go beyond 1
2024-01-27 03:11:12 +03:00
Andrei Zavatski
567d2bedbf
Refactor ArgonSongProgress for same CurrentTime meaning
2024-01-27 03:03:01 +03:00
Dean Herbert
9dc2a1d6f8
Update resources
2024-01-27 01:02:16 +09:00
Bartłomiej Dach
243c2bc9b4
Make sure the polling connector actually auto-starts itself
2024-01-26 11:21:23 +01:00
Dean Herbert
6e3eb674f6
Move cast to local function and make direct cast
2024-01-26 12:55:36 +09:00
Andrei Zavatski
9b5b313193
Move common logic into own SongProgressBar class
2024-01-26 05:03:40 +03:00
Andrei Zavatski
d2af05b30e
Remove useless bindable from ArgonSongProgressBar
2024-01-26 04:09:00 +03:00
Andrei Zavatski
542f571dee
Remove LINQ cast in HUDOverlay
2024-01-26 01:03:22 +03:00
Dean Herbert
14067c2e57
Remove unused using statements
2024-01-26 00:39:29 +09:00
Bartłomiej Dach
c463aa5ba1
xmldoc everything
2024-01-25 14:47:29 +01:00
Bartłomiej Dach
de52f0a80c
Decouple notifications websocket handling from chat operations
...
This is a prerequisite for https://github.com/ppy/osu/pull/25480 .
The `WebSocketNotificationsClient` was tightly coupled to chat specifics
making it difficult to use in the second factor verification flow.
This commit's goal is to separate the websocket connection and message
handling concerns from specific chat logic concerns.
2024-01-25 14:47:29 +01:00
Dean Herbert
6a338ce555
Adjust spawn ratio up slightly
2024-01-25 21:59:38 +09:00
Dean Herbert
baaf33d995
Merge pull request #26689 from myQwil/divisor_cycle
...
Prevent custom divisor ranges from halting divisor preset cycling
2024-01-25 20:46:16 +09:00
Dean Herbert
4a629fbc79
Update logo to new version
2024-01-25 20:37:50 +09:00
Dean Herbert
56a9b059e9
Add back ScaleAdjust to triangles
2024-01-25 20:37:50 +09:00
Mike Will
a264ac9f38
Change name and description of force parameter in SetArbitraryDivisor
2024-01-25 05:12:54 -05:00
Bartłomiej Dach
088397b0c3
Merge pull request #26699 from peppy/fix-log-save-failure
...
Add retry loop to avoid log export failing occasionally on windows
2024-01-25 09:51:14 +01:00
Bartłomiej Dach
3e13fb87f2
Merge pull request #26700 from peppy/accuracy-circle-crash
...
Fix crash at results screen when hidden is enabled and S rank becomes A due to miss
2024-01-25 09:32:47 +01:00
Dean Herbert
45b4edcd23
Merge pull request #26697 from LeNitrous/add/scaled-screenshot
...
Crop screenshots to scaling container
2024-01-25 15:03:56 +09:00
Dean Herbert
37e370e654
Fix crash at results screen when hidden is enabled and S rank becomes A due to miss
...
Closes https://github.com/ppy/osu/issues/26692 .
2024-01-25 15:02:44 +09:00
Dean Herbert
69e822f3c5
Refactor crop logic slightly
2024-01-25 14:30:26 +09:00
Dean Herbert
85927e0682
Move configuration retrieval to non-bindable inline for readability
2024-01-25 14:22:27 +09:00
Dean Herbert
0cbba7e011
Apply NRT to ScreenshotManager
2024-01-25 14:18:20 +09:00
Dean Herbert
d2990170d0
Add retry loop to avoid log export failing occasionally on windows
...
Closes https://github.com/ppy/osu/issues/26693 .
2024-01-25 13:53:36 +09:00
Nitrous
b20051fd55
offset crop rectangle to scaling container
2024-01-25 10:35:41 +08:00
Nitrous
30e335233d
Crop screenshot image to scaling container.
2024-01-25 09:27:10 +08:00
Andrei Zavatski
7811968582
Fix ArgonScoreCounter is still using localisation
2024-01-25 03:28:02 +03:00
Mike Will
9e1c242713
Prevent custom divisor ranges from halting preset cycling
...
A custom divisor like 24 or 32 will result in a range containing
many divisors that are already in the `Common` and `Triplets` presets.
When this happens, it can become impossible to cycle between presets,
because the preset can only be changed if the new divisor isn't already
contained within the current preset's range.
2024-01-24 18:31:39 -05:00
Andrei Zavatski
67010fcd03
Reduce allocation overhead in ScoreCounter
2024-01-24 23:45:07 +03:00
Dean Herbert
b272d34960
Merge pull request #26630 from peppy/s-rank-change
...
Change S rank to require no miss
2024-01-24 13:27:40 +09:00
Bartłomiej Dach
871683a3dc
Merge pull request #26674 from peppy/use-better-enumerator
...
Reduce enumerator overhead in `GameplayLeaderboard`
2024-01-23 16:31:17 +01:00
Bartłomiej Dach
0486c77a74
Merge pull request #26680 from peppy/fix-now-playing-centering
...
Fix now playing beatmap backgrounds not being correctly centred
2024-01-23 16:17:34 +01:00
Bartłomiej Dach
6c169e3156
Do not reprocess ranks for custom rulesets
...
Chances are that because we've broken rank API, it would utterly fail
for all custom rulesets anyhow.
2024-01-23 12:59:36 +01:00
Bartłomiej Dach
cb87d6ce50
Move transferal of LegacyTotalScore back to original spot
...
This subtle detail was messing with server-side score import flows.
Server-side, legacy total score will *already* be in `LegacyTotalScore`
from the start, and `TotalScore` will be zero until recomputed via
`StandardisedScoreMigrationTools.UpdateFromLegacy()` - so in that
context, attempting to move it across is incorrect.
2024-01-23 12:42:57 +01:00
