1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 14:32:55 +08:00
Commit Graph

65359 Commits

Author SHA1 Message Date
Bartłomiej Dach
4c5dacd559
Merge pull request #26770 from peppy/fucking-hitobject-references
Fix `OsuPlayfield` being retained indefinitely after gameplay
2024-01-29 09:40:56 +01:00
Dean Herbert
48fc0545c2
Merge pull request #26724 from bdach/decouple-notification-websocket-from-chat
Decouple notifications websocket handling from chat operations
2024-01-29 16:57:13 +09:00
Dean Herbert
ef94eff574
Rename PollingChatClientConnector to better describe usage 2024-01-29 16:56:28 +09:00
Bartłomiej Dach
a41ba7c381
Fix more nullable inspections 2024-01-29 08:44:27 +01:00
Dean Herbert
fb24c66342
Mark ResultsScreen.Score as nullable
Is nullable in playlist results at very least.
2024-01-29 16:43:26 +09:00
Dean Herbert
760368709a
Mark some delegates as static because we can 2024-01-29 16:16:28 +09:00
Dean Herbert
eb90ee5415
Add safety in ResultsScreen.Exit to ensure HitEvents are not holding references
This is a catch-all safety disconnecting `ScoreInfo` from `HitObject`s.
2024-01-29 16:16:17 +09:00
Dean Herbert
76832a1495
Remove ScorePerformanceCache
This class was only used in two places, both on the results screen, but
was holding references to `OsuPlayfield` game-wide (due to unrelated
issues, but still).

Because I can't really think of future use cases for this, and running
the calculation twice at results screen isn't a huge overhead, let's
just do that for now to keep things simple.
2024-01-29 15:28:20 +09:00
Dean Herbert
de32e7815b
Clean up DrawableHitObject events on Dispose
This is just general safeties to avoid cases where
components don't correctly unbind events.
2024-01-29 15:28:20 +09:00
Dean Herbert
9c55498058
r# says hi 2024-01-29 15:28:14 +09:00
Dean Herbert
8922190055
Merge pull request #26723 from EVAST9919/progress-bar-improvements
Reduce allocation overhead of song progress bars
2024-01-29 02:44:16 +09:00
Dean Herbert
462dab3c90
Remove unnecessary bindable 2024-01-29 02:13:39 +09:00
Dean Herbert
f4dd84fa77
Fix various inconsistencies and document better 2024-01-29 02:10:33 +09:00
Dean Herbert
23f12e1ea3
Should not be a container 2024-01-29 01:50:27 +09:00
Andrei Zavatski
b48f99ba4b Stop using SliderBar as a base 2024-01-28 18:06:09 +03:00
Andrei Zavatski
ed9e0fe1db Merge branch 'master' into progress-bar-improvements 2024-01-28 17:59:29 +03:00
Dean Herbert
17a645f6d4
Merge pull request #26750 from EVAST9919/logo-triangles 2024-01-28 03:13:58 +09:00
Andrei Zavatski
9d73d0e04d Clamp logo triangles along both axes 2024-01-27 19:06:04 +03:00
Dean Herbert
c1da0ba6df
Merge pull request #26744 from peppy/update-framework
Update framework
2024-01-27 20:58:23 +09:00
Dean Herbert
4c34d2e352
Update framework 2024-01-27 20:21:27 +09:00
Dean Herbert
3cad5fe292
Merge pull request #26704 from peppy/new-logo
Update logo
2024-01-27 19:34:22 +09:00
Dean Herbert
f7095c939e
Merge pull request #26740 from hrfarmer/patch-1
Update README.md to link to new development project
2024-01-27 19:17:21 +09:00
Dean Herbert
71dd8e2729
Update iOS icons 2024-01-27 19:16:54 +09:00
aychar
96dba03513
Update README.md 2024-01-27 00:06:01 -06:00
Andrei Zavatski
3387565ba9 Fix song progress value may go beyond 1 2024-01-27 03:11:12 +03:00
Andrei Zavatski
567d2bedbf Refactor ArgonSongProgress for same CurrentTime meaning 2024-01-27 03:03:01 +03:00
Bartłomiej Dach
33738b5285
Update android icons 2024-01-26 19:04:16 +01:00
Dean Herbert
f54e1418ae
Update to v4 2024-01-27 01:42:47 +09:00
Dean Herbert
9dc2a1d6f8
Update resources 2024-01-27 01:02:16 +09:00
Bartłomiej Dach
243c2bc9b4
Make sure the polling connector actually auto-starts itself 2024-01-26 11:21:23 +01:00
Dean Herbert
2778e43713
Merge pull request #26635 from frenzibyte/shift-taiko-playfield
Move osu!taiko playfield down a nudge to match stable visually
2024-01-26 18:53:01 +09:00
Dean Herbert
68d5e8affc
Use a better constant for playfield positioning 2024-01-26 18:52:36 +09:00
Dean Herbert
9aa637f791
Merge pull request #26721 from EVAST9919/all-judged-no-alloc
Reduce allocation overhead in `SliderInputManager.updateTracking`
2024-01-26 18:17:14 +09:00
Dean Herbert
afc4b63473
Merge branch 'master' into shift-taiko-playfield 2024-01-26 18:15:30 +09:00
Dean Herbert
1c22dbcb46
Merge pull request #26634 from frenzibyte/fix-taiko-hit-position-v2
Change hit target position in osu!taiko to always match stable
2024-01-26 18:14:35 +09:00
Dean Herbert
aca1ce9972
Merge branch 'master' into fix-taiko-hit-position-v2 2024-01-26 17:51:06 +09:00
Dean Herbert
6b8dd91199
Merge pull request #26632 from frenzibyte/constant-taiko-input-drum-width
Define constant input drum width for osu!taiko
2024-01-26 17:50:53 +09:00
Dean Herbert
b6fa50c312
Reduce allocation overheads in SliderInputManager 2024-01-26 17:49:20 +09:00
Dean Herbert
b84457fd15
Merge branch 'master' into constant-taiko-input-drum-width 2024-01-26 17:18:26 +09:00
Dean Herbert
e78f0bc89b
Merge pull request #26631 from frenzibyte/refactor-taiko-playfield-layout
Rewrite osu!taiko playfield adjustment container to keep playfield height constant
2024-01-26 17:17:49 +09:00
Dean Herbert
86027268a8
Merge pull request #26711 from EVAST9919/hud-linq-remove
Remove LINQ cast in `HUDOverlay`
2024-01-26 16:13:21 +09:00
Dean Herbert
6e3eb674f6
Move cast to local function and make direct cast 2024-01-26 12:55:36 +09:00
Dean Herbert
84a0291c85
Update icon in nuspec file 2024-01-26 12:32:18 +09:00
Andrei Zavatski
9b5b313193 Move common logic into own SongProgressBar class 2024-01-26 05:03:40 +03:00
Andrei Zavatski
d2af05b30e Remove useless bindable from ArgonSongProgressBar 2024-01-26 04:09:00 +03:00
Andrei Zavatski
542f571dee Remove LINQ cast in HUDOverlay 2024-01-26 01:03:22 +03:00
Dean Herbert
14067c2e57
Remove unused using statements 2024-01-26 00:39:29 +09:00
Bartłomiej Dach
c463aa5ba1
xmldoc everything 2024-01-25 14:47:29 +01:00
Bartłomiej Dach
de52f0a80c
Decouple notifications websocket handling from chat operations
This is a prerequisite for https://github.com/ppy/osu/pull/25480.

The `WebSocketNotificationsClient` was tightly coupled to chat specifics
making it difficult to use in the second factor verification flow.
This commit's goal is to separate the websocket connection and message
handling concerns from specific chat logic concerns.
2024-01-25 14:47:29 +01:00
Salman Ahmed
c35df0313f Fix taiko playfield test scene 2024-01-25 16:33:34 +03:00