Andrei Zavatski
397def9ceb
Move layout specification outside the GradedCircles class
2024-02-04 02:58:15 +03:00
Andrei Zavatski
7b2adc857a
Merge branch 'master' into results-clean
2024-02-04 02:41:12 +03:00
Dan Balasescu
b44f77cee1
Update R# + fix inspections
2024-02-02 21:00:28 +09:00
Mike Will
e4ec8c111b
give better volume names to addVolumeSteps
2024-02-02 05:48:57 -05:00
Mike Will
906560f66d
Fix mute button test
...
Lowering the master volume in the previous test meant that the
volume levels would end up being modified.
2024-02-02 04:06:22 -05:00
Mike Will
5d9200b4fe
Update tests to reflect new restore target volume
2024-02-02 02:59:02 -05:00
Bartłomiej Dach
091618db1a
Add test coverage of full account creation flow
2024-02-02 07:25:07 +01:00
Mike Will
dfd966e039
Improve silence detection in MutedNotification
...
Instead of checking the master and music volumes separately to
see if they're <= 1%, check the aggregate of the two volumes to
see if it's <= -60 dB.
When muted notification is activated, restore the aggregate volume
level to -30 dB.
2024-02-02 00:48:42 -05:00
Bartłomiej Dach
865f4d76ff
Add unranked indicator to song select footer too
2024-02-01 21:51:41 +01:00
Bartłomiej Dach
966093f7ce
Transform score multiplier display to also show ranked state
2024-02-01 21:32:37 +01:00
Andrei Zavatski
b0f6a87a2b
Add stress test in TestSceneDashboardOverlay
2024-02-01 16:22:07 +03:00
Salman Ahmed
6ab8960fdc
Add step for toggling skins in results screen test scene
2024-02-01 16:08:48 +03:00
Salman Ahmed
35c3f5e250
Merge branch 'master' into fix-results-f-rank
2024-02-01 15:29:07 +03:00
Dean Herbert
a1fe5eedd5
Merge pull request #26751 from frenzibyte/fix-multiplayer-fail-freezing-score
...
Fix score processor no longer applying results when failing in multiplayer match
2024-01-29 19:51:31 +09:00
Dean Herbert
cbbe2f9dc0
Merge pull request #25480 from peppy/2fa
...
Add two factor authentication flow
2024-01-29 19:14:55 +09:00
Bartłomiej Dach
a41ba7c381
Fix more nullable inspections
2024-01-29 08:44:27 +01:00
Dean Herbert
fb24c66342
Mark ResultsScreen.Score as nullable
...
Is nullable in playlist results at very least.
2024-01-29 16:43:26 +09:00
Andrei Zavatski
809ca81b9c
Add TestSceneGradedCircles
2024-01-29 05:29:29 +03:00
Salman Ahmed
64b61108ad
Move solution to multiplayer flow instead
2024-01-28 00:42:04 +03:00
Salman Ahmed
5f68999893
Fix TestSceneFailJudgement asserts no longer being correct
2024-01-27 23:23:32 +03:00
Salman Ahmed
ea641bb8d2
Rename GameplayState.HasFailed to properly clarify its meaning
2024-01-27 23:23:10 +03:00
Salman Ahmed
d38779f962
Add failing test case
2024-01-27 23:22:56 +03:00
Salman Ahmed
2ccd0e3692
Add visual and failing test cases
2024-01-27 01:45:39 +03:00
Bartłomiej Dach
a2e69d37e8
Add basic testing of failure flow
2024-01-26 11:17:32 +01:00
Chandler Stowell
93bd3ce5ae
update DrawableHitCircle.ApplyResult to pass this to its callback
2024-01-25 11:25:41 -05:00
Bartłomiej Dach
3d3506b906
Merge branch 'decouple-notification-websocket-from-chat' into 2fa
2024-01-25 14:51:42 +01:00
Dean Herbert
d66a2c452f
Merge branch 'master' into multiplayer-difficulty-tooltip
2024-01-25 21:18:16 +09:00
Dean Herbert
baaf33d995
Merge pull request #26689 from myQwil/divisor_cycle
...
Prevent custom divisor ranges from halting divisor preset cycling
2024-01-25 20:46:16 +09:00
Dean Herbert
f22bfa350a
Add test coverage of hidden scores on accuracy circle
2024-01-25 15:02:44 +09:00
Mike Will
9e1c242713
Prevent custom divisor ranges from halting preset cycling
...
A custom divisor like 24 or 32 will result in a range containing
many divisors that are already in the `Common` and `Triplets` presets.
When this happens, it can become impossible to cycle between presets,
because the preset can only be changed if the new divisor isn't already
contained within the current preset's range.
2024-01-24 18:31:39 -05:00
Bartłomiej Dach
2f8747776e
Fix nullability inspection
2024-01-24 22:01:59 +01:00
Dean Herbert
b272d34960
Merge pull request #26630 from peppy/s-rank-change
...
Change S rank to require no miss
2024-01-24 13:27:40 +09:00
Bartłomiej Dach
0d7834af5f
Ensure all remaining test usages of IAPIAccess.Login() also authenticate with second factor
2024-01-23 18:04:41 +01:00
Bartłomiej Dach
d7e957087e
Fix account creation overlay test not clearing second auth factor
2024-01-23 17:00:16 +01:00
Bartłomiej Dach
d0d09a8657
Fix login overlay test not clearing second auth factor
2024-01-23 17:00:14 +01:00
Bartłomiej Dach
2cfaa1c103
Merge branch 'master' into 2fa
2024-01-23 16:51:23 +01:00
Andrei Zavatski
da992ccc55
Implement per-axis triangles clamping
2024-01-23 04:54:27 +03:00
Dean Herbert
83f9118b22
Adjust results screen to handle S->A rank adjustment when misses are present
2024-01-22 21:43:32 +09:00
Dean Herbert
c8521b49cd
Change S rank to require no miss
2024-01-22 21:43:32 +09:00
Dean Herbert
2ab0be7606
Merge pull request #26669 from bdach/fix-score-submission-test-failures-again-aaaaaaaaAAAAAA
...
Fix score submission test failures due to checking audio playback validity (again)
2024-01-22 20:07:51 +09:00
Bartłomiej Dach
9b2740f8a4
Fix score submission test failures due to checking audio playback validity (again)
...
As seen in https://github.com/ppy/osu/actions/runs/7607899979/job/20716013982?pr=26662#step:5:75
In https://github.com/ppy/osu/pull/26484 , I went "well if I'm moving the
enabling of validation of playback rate to `SubmittingPlayer` context,
then surely I can remove the local override in the test scene, right?"
Reader: Apparently I did not notice that `FakeImportingPlayer :
TestPlayer : SoloPlayer : SubmittingPlayer`. So no, I could not remove
the local override in the test scene.
You could probably attempt to conjure up some excuse about deep
inheritance hierarchies here but nah. Really just a failure to read
on my behalf as usual.
2024-01-22 11:15:42 +01:00
Bartłomiej Dach
77ef12ebb0
Merge branch 'master' into frame-stable-catchup-zoom
2024-01-22 10:37:06 +01:00
Dean Herbert
f12be60d8d
Make test actually test multiple icons
2024-01-22 17:18:22 +09:00
Bartłomiej Dach
493d495992
Merge pull request #26605 from peppy/simplify-gameplay-pause
...
Simplify gameplay pause sequence
2024-01-22 08:49:08 +01:00
Dean Herbert
3b7a47aded
Merge branch 'master' into update-framework
2024-01-21 13:49:44 +09:00
Andrei Zavatski
1393f52b2b
Rename Masking to ClampToDrawable
2024-01-21 05:20:42 +03:00
smallketchup82
87369f8a80
Conform to code style & remove unused imports
2024-01-18 11:16:03 -05:00
Salman Ahmed
22cfc86050
Add failing test case
2024-01-18 14:24:49 +03:00
Dean Herbert
c4e9bcd140
Remove test guarantee of audio time not advancing
2024-01-18 20:06:53 +09:00
Dean Herbert
82e7643df5
Update IPC usages
...
Of note, I've disabled IPC on visual test runners as we generally don't
use IPC in these cases. Having it set means that the game will not open
while visual tests are open, which has been a complaint from devs in the
past.
2024-01-18 19:45:36 +09:00
smallketchup82
d80a5d44ee
Add tests for DifficultyIcon
2024-01-18 03:17:37 -05:00
Dean Herbert
799c74cfe5
Simplify gameplay pause sequence
2024-01-18 14:17:19 +09:00
Dean Herbert
fb4efd992d
Add a fake load to visual test to restore previous testing behaviour
2024-01-18 14:01:37 +09:00
Dean Herbert
c362a93a36
Change frame stable catch-up method to allow for much faster sync
2024-01-18 14:01:37 +09:00
Dean Herbert
6a8a45bb13
Merge pull request #26585 from frenzibyte/fix-editor-ux
...
Fix timing point changes not applying after selecting another one
2024-01-17 19:53:35 +09:00
Dean Herbert
1af5d1434c
Rename test method slightly
2024-01-17 19:53:23 +09:00
Bartłomiej Dach
5cb17bcacf
Merge pull request #26502 from frenzibyte/prevent-submission-with-invalid-mods
...
Add guard against submitting score with invalid mod instances
2024-01-17 11:39:32 +01:00
Dean Herbert
ee18123fc2
Merge pull request #26340 from stanriders/user-rank-card
...
Add user card with global/country ranks to login overlay
2024-01-17 17:22:33 +09:00
Salman Ahmed
05729706eb
Fix android build CI failing
...
No idea why this is only in android, but okay.
2024-01-17 08:53:28 +03:00
Salman Ahmed
23e5167cb5
Merge branch 'master' into drag-volume-controls
2024-01-17 08:37:34 +03:00
Salman Ahmed
a34d2a3424
Add small volume meter to test feel
2024-01-17 08:28:47 +03:00
Salman Ahmed
f11682d44f
Add failing test case
2024-01-17 08:15:01 +03:00
Salman Ahmed
485195d4c2
Fix submission test not asserting properly
2024-01-16 14:27:40 +03:00
Dean Herbert
0e41d0c9cf
Add failing test coverage of skin getting nuked
...
This doesn't fail in headless unfortunately.
Run a few times manually to confirm.
2024-01-16 15:22:38 +09:00
Bartłomiej Dach
40f612435d
Merge pull request #26178 from felipemarins/mod-search-text-box-select-all
...
Make mod search box text be selected when a new mod is selected/deselected
2024-01-15 20:08:02 +01:00
Bartłomiej Dach
a41108057f
Merge pull request #26287 from wooster0/no-scores-yet
...
Don't leave scores screen empty if no scores are present yet
2024-01-15 19:49:20 +01:00
Bartłomiej Dach
4d39c91972
Merge pull request #26449 from peppy/playlist-room-buttons
...
Allow interacting with playlist item buttons when not selected
2024-01-15 19:12:01 +01:00
Bartłomiej Dach
c0d4ed4789
Add test coverage of select-all-text-in-search when nothing matched
2024-01-15 19:07:52 +01:00
Bartłomiej Dach
e8394e6f74
Add test coverage
2024-01-15 19:05:33 +01:00
Bartłomiej Dach
988794cf90
Improve test coverage for empty results
2024-01-15 18:49:41 +01:00
Bartłomiej Dach
8a839f64ed
Add failing test coverage for placeholder shown when it shouldn't be
2024-01-15 18:47:46 +01:00
Bartłomiej Dach
d8d1d9264c
Fix test failure
2024-01-15 18:29:51 +01:00
Bartłomiej Dach
91f8144f98
Add test coverage
2024-01-15 14:58:46 +01:00
Bartłomiej Dach
d206acac63
Merge pull request #26540 from peppy/fix-double-counters
...
De-dupe displayed hits in judgement counter
2024-01-15 14:02:11 +01:00
Bartłomiej Dach
fe8540b441
Merge pull request #26541 from peppy/fix-collection-dropdown-crash
...
Fix collection dropdown crashing when all collections are deleted at once
2024-01-15 13:28:00 +01:00
Salman Ahmed
d346dd0650
Fix TestModReinstantiation failing due to custom mod being used
2024-01-15 15:01:13 +03:00
Bartłomiej Dach
96c472b870
Remove unused using directive
2024-01-15 12:33:25 +01:00
Bartłomiej Dach
6dee2860d2
Merge branch 'master' into fix-multiplayer-mods-cheesing
2024-01-15 12:19:29 +01:00
Bartłomiej Dach
0a02050a85
Fix test crashing at the end in visual test browser
2024-01-15 12:12:27 +01:00
StanR
b86c883a5d
Merge branch 'master' into user-rank-card
2024-01-15 16:37:48 +06:00
Salman Ahmed
494c1be655
Fix blatant error in TestSceneModAccuracyChallenge
2024-01-15 13:30:34 +03:00
Bartłomiej Dach
9da3aeb28b
Merge pull request #26492 from frenzibyte/fix-system-mods-selected-on-free-mods-overlay
...
Fix touch device mod getting selected as a free mod in playlists
2024-01-15 11:29:37 +01:00
Dean Herbert
a3b63391fa
Merge pull request #26356 from stanriders/global-user-statistics
...
Add `Statistics` bindable to `IAPIProvider` and update it from `SoloStatisticsWatcher`
2024-01-15 18:43:35 +09:00
Dean Herbert
2b45a9b7c6
Add failing test coverage showing collection dropdown crash
2024-01-15 17:10:16 +09:00
Dean Herbert
e6453853c2
De-dupe displayed hits in judgement counter
2024-01-15 16:02:59 +09:00
Dean Herbert
2d5a39b234
Add failing test coverage of duplicates in judgement counter display
2024-01-15 16:02:58 +09:00
Salman Ahmed
b1fae2bc6a
Add failing test case
2024-01-13 16:24:49 +03:00
Salman Ahmed
4cde8685d3
Add failing test case
2024-01-13 11:16:22 +03:00
Salman Ahmed
5303023e57
Add failing test case and fix selection assertion
2024-01-13 09:42:23 +03:00
Bartłomiej Dach
6572fa4378
Only validate playback rate when in submission context
...
Temporary workaround for https://github.com/ppy/osu/issues/26404 .
It appears that some audio files do not behave well with BASS, leading
BASS to report a contradictory state of affairs (i.e. a track that is
in playing state but also not progressing). This appears to be related
to seeking specifically, therefore only enable the validation of
playback rate in the most sensitive contexts, namely when any sort of
score submission is involved.
2024-01-12 14:59:15 +01:00
Bartłomiej Dach
600e4b6ef3
Adjust skinnable health display test scene for usability
2024-01-11 10:17:32 +01:00
Bartłomiej Dach
861080d3ae
Move simulated drain to separate test case
...
Having it on at all times was causing other tests to fail.
2024-01-11 10:04:37 +01:00
Dean Herbert
c2706ca91b
Also show drain on argon health display test
2024-01-11 00:31:31 +09:00
Dean Herbert
49d13cda6b
Fix failing test by setting health on source of truth
2024-01-10 23:09:43 +09:00
Dean Herbert
f912a1ba31
Merge branch 'master' into health-less-value-changed
2024-01-10 18:03:34 +09:00
wooster0
d5fdd0c0f9
make each test bind the handler only once, depending on its need
2024-01-09 21:44:05 +09:00
wooster0
ea37c70e0b
apply suggestion
2024-01-09 21:34:40 +09:00
wooster0
8ad697ff4c
apply some suggestions/corrections
2024-01-09 21:28:46 +09:00
Dean Herbert
8324b75fa4
Merge pull request #26437 from bdach/song-select-logo-crash
...
Fix crash when clicking osu! logo in song select immediately after exiting
2024-01-09 19:40:19 +09:00
Dean Herbert
f1b4c305b0
Change skinnable health test scene to drain
2024-01-09 17:09:19 +09:00
