Dean Herbert
59d6e67512
Add missing TestManualClock.Reset implementation for safe measure
2023-09-22 16:22:35 +09:00
Dean Herbert
0200b63fd3
Add note about beatmap offset not being reapplied correctly on ChangeSource
2023-09-22 14:41:07 +09:00
Dean Herbert
a1e298930c
Remove second hopefully-unnecessary workaround
2023-09-22 14:41:07 +09:00
Dean Herbert
a451ab75dd
Remove hopefully-unnecessary workaround
...
It was causing issues with the new implementation.
2023-09-22 14:41:05 +09:00
Dean Herbert
df08c4e1ad
Disable decoupling for OsuGameBase's beatmap implementation
...
This avoids it ever mutating the underlying track (aka attempting to start
it). Resolves the one caveat mentioned in
aeef92fa710648d4a00edc523e13c17ac6104125.
2023-09-22 12:49:25 +09:00
Dean Herbert
5f634f2812
Remove unnecessary encapsulation workaround
...
The new implementation of `DecouplingClock` will not mutate the
underlying clock in any way (unless attempting to start it when
approaching from a negative time value).
This should be quite safe as a result.
2023-09-22 12:49:25 +09:00
Dean Herbert
21a2e27e5f
Simplify some pieces of FramedBeatmapClock
2023-09-22 12:49:25 +09:00
Dean Herbert
04e6ec8715
Fix interpolation not being applied when applyOffsets is set
2023-09-22 12:49:25 +09:00
Dean Herbert
117cd74af6
Update usage of DecoupleableInterpolatingFramedClock in FramedBeatmapClock
2023-09-22 12:49:25 +09:00
Dean Herbert
3f27be1f33
Replace most usages of DecoupleableInterpolatingFramedClock
...
Except `FramedBeatmapClock`, which is the high-effort one.
2023-09-22 12:49:25 +09:00
Dean Herbert
600651795b
Change FramedBeatmapClock to always be decoupled
2023-09-22 12:49:25 +09:00
Salman Ahmed
d18bd2d2ac
Merge pull request #24880 from bdach/flaky-scoreboard-test
...
Fix `TestFriendScore` intermittently failing due to randomness
2023-09-22 02:09:04 +03:00
Bartłomiej Dach
e45d456324
Fix TestFriendScore intermittently failing due to randomness
...
If `createRandomScore()` happened to randomly pick the highest total
score when called with `friend` as the sole argument, that particular
score would not be pink.
`GetScoreByUsername()` would arbitrarily pick the first score for the
user, so in this particular case where a friend had the number 1 score,
the test would wrongly fail.
Fix by checking whether any of the 3 added friend scores have received
the pink colour. Because there is more than 1 friend score in the test,
doing so ensures that at least one of those should eventually become
pink (because, obviously, you can't have two scores at number 1).
2023-09-21 21:12:44 +02:00
Bartłomiej Dach
9301a1907a
Rewrite TestFriendScore assertions to constraint model
...
Allows to clearly see what the failure is:
TearDown : System.TimeoutException : "friend score is pink" timed out: Expected: some item equal to "#FF549A"
But was: < "#FFFFFF", "#7FCC33", "#444444 " >
The #7FCC33 colour is used for the first score on the leaderboard.
2023-09-21 21:05:41 +02:00
Bartłomiej Dach
561f66400a
Merge pull request #24878 from peppy/fix-song-select-shift-delete
...
Fix shift-delete not working at song select
2023-09-21 20:48:42 +02:00
Bartłomiej Dach
d73f06fc89
Add test coverage for delete hotkey
2023-09-21 20:01:59 +02:00
Salman Ahmed
5266cdc722
Add explanatory note
2023-09-21 20:41:10 +03:00
Salman Ahmed
095812c6b8
Merge branch 'master' into fix-song-select-shift-delete
2023-09-21 20:25:43 +03:00
Salman Ahmed
1f3a660443
Merge pull request #24870 from peppy/update-framework
...
Update clocks in line with framework changes
2023-09-21 20:25:08 +03:00
Salman Ahmed
9e4a56d64e
Merge branch 'master' into update-framework
2023-09-21 19:49:20 +03:00
Dean Herbert
f1258a3963
Update framework
2023-09-22 01:26:38 +09:00
Dean Herbert
9af4e75dfc
Disable clipboard export for song select textbox
...
In combination with https://github.com/ppy/osu-framework/pull/5997 ,
closes https://github.com/ppy/osu/issues/24867
2023-09-22 01:24:29 +09:00
Salman Ahmed
ad86bf2d56
Revert redundant size limitations
...
Already handled by the sprites themselves being resized.
2023-09-21 19:03:59 +03:00
Salman Ahmed
c4fc4199d1
Use correct maximum size for droplets
2023-09-21 19:02:31 +03:00
Bartłomiej Dach
08ef840370
Merge pull request #24550 from smoogipoo/mania-edit-disable-sv
...
Adjust osu!taiko and osu!mania editors to not visualise velocity changes by default
2023-09-21 09:50:55 +02:00
Bartłomiej Dach
69ed99dfd5
Merge branch 'master' into mania-edit-disable-sv
2023-09-21 09:13:27 +02:00
Bartłomiej Dach
b81e1ce4b2
Merge pull request #24875 from peppy/update-readme
...
General improvements to README
2023-09-21 09:04:49 +02:00
Dean Herbert
8ef0ef09db
Reword release build disclaimer
2023-09-21 14:59:37 +09:00
Dean Herbert
0eab4c5364
Reword sentence with multiple ands
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-09-21 14:47:55 +09:00
Dean Herbert
262916787e
Apply punctuation and terminology fixes
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2023-09-21 13:27:00 +09:00
Dean Herbert
9629f49afb
Update build instructions to be more clear about slnf files and mention workloads
2023-09-21 11:57:10 +09:00
Dean Herbert
fc6abae968
Remove note about dotnet CLI tools not working (less relevant post-EF)
2023-09-21 11:56:49 +09:00
Dean Herbert
c76853c32c
Add mention of new project
2023-09-21 11:56:32 +09:00
Dean Herbert
2954ad7834
Update language across whole readme to read better
2023-09-21 11:56:23 +09:00
Dean Herbert
8a3d412ffc
Remove mention of no-heated-gameplay-mechanics discussions
...
We're kinda at the point we're allowing this now.
2023-09-21 11:38:16 +09:00
Dean Herbert
bf984388b3
Update clocks in line with framework changes
2023-09-20 21:17:08 +09:00
Bartłomiej Dach
f2791d4f3e
Move comment a bit to fix formatting
...
Would otherwise trigger IDE0055, but that isn't resolveable without
an inspection cycle with resharper, so just move in a more sane place.
2023-09-20 12:22:05 +02:00
Bartłomiej Dach
d7129da8ea
Fix TestSceneDrawableStoryboardSprite not displaying anything
2023-09-20 12:05:23 +02:00
Bartłomiej Dach
46acd807f7
Merge pull request #24848 from Magnus-Cosmos/fix-slider-length
...
Use correct check for slider path extension
2023-09-20 11:45:39 +02:00
Bartłomiej Dach
28da5baea4
Merge branch 'master' into fix-slider-length
2023-09-20 11:10:01 +02:00
Dean Herbert
cb0226f843
Implement new interface-based speed change visualisation support on mania/taiko
2023-09-20 15:28:13 +09:00
Dean Herbert
41a8239e49
Remvoe null default for mods which can't be null
2023-09-20 15:27:50 +09:00
Dean Herbert
c6cc858967
Change implementation of "show speed changes" to require explicit ruleset support
2023-09-20 15:27:30 +09:00
Dean Herbert
2c38bed944
Merge pull request #24730 from cdwcgt/leaderboard-friend-highlight
...
Highlight friend score in gameplay leaderboards
2023-09-20 14:54:12 +09:00
Dean Herbert
c5397bdbb3
Merge branch 'master' into mania-edit-disable-sv
2023-09-20 14:23:07 +09:00
Dean Herbert
71ac5cfc79
Don't bother binding to friends changes for score display purposes
2023-09-20 14:14:37 +09:00
Dean Herbert
1927b524db
Merge branch 'master' into leaderboard-friend-highlight
2023-09-20 14:14:08 +09:00
Dean Herbert
1316403180
Fix inspection in new test scene
2023-09-20 13:02:40 +09:00
Dean Herbert
bd66285bd4
Rename parameter on LegacySpriteText to better imply the maximum size is per glyph
2023-09-20 12:59:40 +09:00
Dean Herbert
b5e64d933c
Apply same fix to DrawableStoryboardAnimation
2023-09-20 12:54:36 +09:00
