73586 Commits

This Branch

This Branch

All Branches

• Reduce maximum sizing of left/right component areas
  Dean Herbert · 2025-05-29 20:11:30 +09:00
  3da4651ea2
• Merge pull request #33319 from peppy/song-select-v2-standalone-panel-design-update

  SongSelectV2: Update general metrics and design of standalone beatmap panel

  Dean Herbert · 2025-05-29 20:11:17 +09:00
  5c0c78d1b1
• Fix code quality
  Bartłomiej Dach · 2025-05-29 12:50:29 +02:00
  3589dfe803
• Adjust sizing slightly
  Dean Herbert · 2025-05-29 19:28:18 +09:00
  17285db53e
• Merge pull request #33318 from bdach/song-select-v2-footer-buttons-stupid

  SongSelectV2: Disable footer buttons when transitioning to another screen

  Dean Herbert · 2025-05-29 18:43:24 +09:00
  9e6d657ec8
• Merge pull request #33316 from bdach/song-select-v2-do-not-start-on-default-beatmap

  SongSelectV2: Fix being able to progress to player loader when no beatmap is selected

  Dean Herbert · 2025-05-29 18:40:31 +09:00
  0a355529b3
• Standardise metrics and variable naming between PanelBeatmap and PanelBeatmapStandalone
  Dean Herbert · 2025-05-29 18:30:46 +09:00
  92ed964627
• Add hack to avoid spacing being added to flow when local rank is not visible
  Dean Herbert · 2025-05-29 18:30:16 +09:00
  185f55a7e6
• Decrease height of set headers and standalone beatmap panels

  They felt too chunky.

  Dean Herbert · 2025-05-29 18:28:35 +09:00
  129dc2e173
• Add precautionary assertion guarding against song select messing with logo while not current

  I considered having this just be a straight guard followed by an
  early-return, but if that guard ever actually gets hit, things are going
  to be severely broken all over, and un-breaking them at that point will
  be very annoying, so just going to cross fingers and hope this can be an
  assertion forevermore instead.

  Bartłomiej Dach · 2025-05-29 10:38:42 +02:00
  cfa0a49e59
• Disable footer buttons when transitioning to another screen
  Bartłomiej Dach · 2025-05-29 10:35:51 +02:00
  36628e24f9
• Add failing test case for mod select becoming visible after suspending song select
  Bartłomiej Dach · 2025-05-29 10:34:46 +02:00
  d328d3d6ed
• Centralise current screen check
  Bartłomiej Dach · 2025-05-29 09:59:50 +02:00
  26aca19af4
• SongSelectV2: Fix being able to progress to player loader when no beatmap is selected
  Bartłomiej Dach · 2025-05-29 09:47:43 +02:00
  dabe28045e
• Add failing test coverage for osu! cookie attempting to start gameplay with nothing selected
  Bartłomiej Dach · 2025-05-29 09:32:38 +02:00
  d1d9749de5
• Merge pull request #33307 from peppy/song-select-v2-fix-incorrect-split-out-conditional

  SongSelectV2: Fix incorrect conditional being used for "split out" check

  Bartłomiej Dach · 2025-05-29 09:21:24 +02:00
  6a7e9b9375
• Merge pull request #33304 from peppy/song-select-v2-retain-selection-on-filter-all

  SongSelectV2: Fix filtering all results away nuking user's selection

  Bartłomiej Dach · 2025-05-29 08:37:10 +02:00
  295ec74761
• SongSelectV2: Select random instead of fixed item when recovering from no selection
  Dean Herbert · 2025-05-29 01:53:10 +09:00
  b4a6803236
• Fix multiple issues causing song select to retain a deleted or hidden selection
  Dean Herbert · 2025-05-29 01:53:10 +09:00
  8f18336b2c
• SongSelectV2: Fix incorrect conditional being used for "split out" check

  🤦
  
  Have inlined the v1 usage so we don't accidentally do this again.

  Dean Herbert · 2025-05-29 01:22:22 +09:00
  ef8fd7b5d7
• SongSelectV2: Fix filtering all results away nuking user's selection
  Dean Herbert · 2025-05-29 00:44:48 +09:00
  5d5a569523
• Add failing test showing selected beatmap is reset on zero result filter
  Dean Herbert · 2025-05-29 00:44:48 +09:00
  5d6868cdae
• Merge pull request #33306 from peppy/song-select-v2-select-single-result

  SongSelectV2: If only one results is visible after filter, select it automatically

  Bartłomiej Dach · 2025-05-28 14:05:33 +02:00
  f1b6814ff3
• Merge pull request #33302 from peppy/song-select-v2-fix-loading-overlay

  SongSelectV2: Fix carousel loading state looking out of place

  Bartłomiej Dach · 2025-05-28 14:05:13 +02:00
  5cdd1f99be
• Merge branch 'master' into song-select-v2-fix-loading-overlay
  Bartłomiej Dach · 2025-05-28 13:16:30 +02:00
  bbeb1be295
• Update existing test assertions in line with new selection logic
  Dean Herbert · 2025-05-28 20:07:44 +09:00
  99ab76ba27
• SongSelectV2: If only one results is visible after filter, select it automatically
  Dean Herbert · 2025-05-28 20:07:44 +09:00
  731a4968f5
• Merge pull request #33298 from peppy/song-select-v2-random

  SongSelectV2: Add back basic random selection support

  Dean Herbert · 2025-05-28 20:07:04 +09:00
  dd4fe7d844
• Merge branch 'master' into song-select-v2-random
  Dean Herbert · 2025-05-28 20:06:50 +09:00
  0b527ce14b
• Merge pull request #33301 from peppy/remember-group-expansion

  SongSelectV2: Fix expanded group not being persisted over filter operations

  Bartłomiej Dach · 2025-05-28 12:55:23 +02:00
  d9d74696df
• Merge pull request #33303 from bdach/song-select-v2-holding-traversal-resets-to-start-end

  SongSelectV2: Fix holding beatmap carousel previous / next traversal actions resetting position to start / end when update frame rate is low

  Dean Herbert · 2025-05-28 19:39:18 +09:00
  13f0f6d7bf
• Remove unused using
  Bartłomiej Dach · 2025-05-28 12:36:38 +02:00
  86ae5043c1
• Prevent random selection from selecting hidden beatmaps
  Bartłomiej Dach · 2025-05-28 12:22:09 +02:00
  db7c6fa850
• Fix difficulty grouping not working with random
  Dean Herbert · 2025-05-28 12:14:27 +02:00
  dca839211c
• Merge pull request #33300 from peppy/song-select-v2-fix-group-panel-recreation

  SongSelectV2: Fix group panels being recreated every filter

  Bartłomiej Dach · 2025-05-28 12:07:16 +02:00
  06b55767f3
• SongSelectV2: Fix holding beatmap carousel previous / next traversal actions resetting position to start / end when update frame rate is low
  Bartłomiej Dach · 2025-05-28 11:45:59 +02:00
  c56c7b7239
• SongSelectV2: Fix carousel loading state looking out of place
  Dean Herbert · 2025-05-28 18:31:37 +09:00
  7a4d9c7c9a
• SongSelectV2: Fix expanded group not being persisted over filter operations
  Dean Herbert · 2025-05-28 18:15:40 +09:00
  df66bab31f
• Add test coverage showing expanded group getting reset on filter
  Dean Herbert · 2025-05-28 18:15:39 +09:00
  c94555388e
• Rename and expose BeatmapCarousel selection handling variables

  For test usage and consistency.

  Dean Herbert · 2025-05-28 18:15:39 +09:00
  ef39b8d9c0
• SongSelectV2: Fix group panels being recreated every filter

  This also allows *all* panels to be re-used based on equality, as
  originally intended. Beatmap updates should be handled correctly without
  a full (flashing) recreation of panels now.

  Dean Herbert · 2025-05-28 17:46:14 +09:00
  c2bd4a9827
• Merge pull request #33299 from peppy/song-select-v2-no-animated-status-pill

  SongSelectV2: Fix status pill still animating on stand-alone panels

  Bartłomiej Dach · 2025-05-28 10:41:43 +02:00
  d3472bdd27
• SongSelectV2: Fix status pill still animating on stand-alone panels

  Addresses
  https://github.com/ppy/osu/issues/32736#issuecomment-2911264829.

  Dean Herbert · 2025-05-28 16:57:11 +09:00
  e2af0654b8
• Set random beatmap on entering song select
  Dean Herbert · 2025-05-28 16:54:11 +09:00
  f602bdeb2f
• SongSelectV2: Add back basic random selection support

  This is a minimal implementation in order to keep moving forward.
  
  For simplicity I've copied over the old implementation verbatim. Note
  that this is beatmap*set* based randomisation, which means that when
  panels are split up by difficulty, it is still randomising by set (with
  the difficulty choice being left up to the user recommendation system).
  I think this is what we want, but if it isn't, any changes can come
  later.

  Dean Herbert · 2025-05-28 16:54:11 +09:00
  1b56ce9a39
• Merge pull request #33288 from peppy/song-select-v2-sounds

  SongSelectV2: Add back missing song select sound effects

  Bartłomiej Dach · 2025-05-28 08:08:17 +02:00
  7926a26b0b
• Merge pull request #33292 from WitherFlower/group-ranked-date

  Add grouping support for Ranked Date and Submitted Date

  Dean Herbert · 2025-05-28 12:53:58 +09:00
  6812503058
• remove grouping by date submitted to reduce clutter

  i doubt it would get much use anyway

  WitherFlower · 2025-05-27 21:09:24 +02:00
  80664d9b92
• add test coverage
  WitherFlower · 2025-05-27 21:07:30 +02:00
  9d7a0eea51
• reverse group order
  WitherFlower · 2025-05-27 20:35:07 +02:00
  e2db76897e