h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-30 05:59:53 +08:00
Code Issues Releases Wiki Activity

Merge pull request #33303 from bdach/song-select-v2-holding-traversal-resets-to-start-end

Browse Source 
SongSelectV2: Fix holding beatmap carousel previous / next traversal actions resetting position to start / end when update frame rate is low
This commit is contained in:
Dean Herbert
2025-05-28 19:39:18 +09:00
committed by GitHub
Unverified
parent 06b55767f3 c56c7b7239
commit 13f0f6d7bf
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Graphics/Carousel/Carousel.cs
+11 -4
View File
@@ -407,20 +407,27 @@ namespace osu.Game.Graphics.Carousel
activateSelection();
return true;
// the selection traversal handlers below are scheduled to avoid an issue
// wherein if the update frame rate is low, keeping one of the actions below pressed leads to selection moving back to the start / end.
// the reason why that happens is that the code managing `current(Keyboard)?Selection` can lose track of the index of the selected item
// if the selection is changed more than once during an update frame,
// which can happen if repeat inputs are enqueued for processing at a rate faster than the update refresh rate.
// `refreshAfterSelection()` is the method responsible for updating the index of the selected item here which runs once per frame.
case GlobalAction.SelectNext:
traverseKeyboardSelection(1);
Scheduler.AddOnce(traverseKeyboardSelection, 1);
return true;
case GlobalAction.SelectPrevious:
traverseKeyboardSelection(-1);
Scheduler.AddOnce(traverseKeyboardSelection, -1);
return true;
case GlobalAction.SelectNextGroup:
traverseGroupSelection(1);
Scheduler.AddOnce(traverseGroupSelection, 1);
return true;
case GlobalAction.SelectPreviousGroup:
traverseGroupSelection(-1);
Scheduler.AddOnce(traverseGroupSelection, -1);
return true;
}