osu-lazer

Resolve CA1835 inspection

"Change the `ReadAsync` method call to use the
`Stream.ReadAsync(Memory<byte>, CancellationToken)` overload"

Bartłomiej Dach · 2020-11-01 18:51:39 +01:00

89bf7b1bd6

Resolve CA1834 inspection

"Use `StringBuilder.Append(char)` instead of
`StringBuilder.Append(string)` when the input is a constant unit string"

Bartłomiej Dach · 2020-11-01 18:50:13 +01:00

ca5de22ca5

Resolve CA1805 inspections

"Member is explicitly initialized to its default value"

Bartłomiej Dach · 2020-11-01 18:47:40 +01:00

2b0bea535e

Bump Microsoft.CodeAnalysis.BannedApiAnalyzers from 3.3.0 to 3.3.1

Bumps [Microsoft.CodeAnalysis.BannedApiAnalyzers](https://github.com/dotnet/roslyn-analyzers) from 3.3.0 to 3.3.1.
- [Release notes](https://github.com/dotnet/roslyn-analyzers/releases)
- [Changelog](https://github.com/dotnet/roslyn-analyzers/blob/master/PostReleaseActivities.md)
- [Commits](https://github.com/dotnet/roslyn-analyzers/compare/v3.3.0...v3.3.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

dependabot-preview[bot] · 2020-11-01 17:15:23 +00:00

79e610d31b

Bump Microsoft.Build.Traversal from 2.1.1 to 2.2.3

Bumps [Microsoft.Build.Traversal](https://github.com/Microsoft/MSBuildSdks) from 2.1.1 to 2.2.3.
- [Release notes](https://github.com/Microsoft/MSBuildSdks/releases)
- [Changelog](https://github.com/microsoft/MSBuildSdks/blob/master/RELEASE.md)
- [Commits](https://github.com/Microsoft/MSBuildSdks/compare/Microsoft.Build.Traversal.2.1.1...Microsoft.Build.Traversal.2.2.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

dependabot-preview[bot] · 2020-11-01 17:14:57 +00:00

6e9ed76251

Bump Microsoft.CodeAnalysis.FxCopAnalyzers from 3.0.0 to 3.3.1

Bumps [Microsoft.CodeAnalysis.FxCopAnalyzers](https://github.com/dotnet/roslyn-analyzers) from 3.0.0 to 3.3.1.
- [Release notes](https://github.com/dotnet/roslyn-analyzers/releases)
- [Changelog](https://github.com/dotnet/roslyn-analyzers/blob/master/PostReleaseActivities.md)
- [Commits](https://github.com/dotnet/roslyn-analyzers/compare/v3.0.0...v3.3.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

dependabot-preview[bot] · 2020-11-01 17:14:13 +00:00

6ff13e399a

Ensure spectator player is unsubscribed to prevent leak

Bartłomiej Dach · 2020-11-01 16:13:19 +01:00

716458344f

Merge branch 'master' into spectator-replay-watcher

Bartłomiej Dach · 2020-11-01 15:53:37 +01:00

23d9fa4dfa

Merge pull request #10647 from bdach/beatmap-import-ensure-correct

Ensure LoadOszIntoOsu returns actual imported map

Dean Herbert · 2020-11-01 23:49:34 +09:00

106bac1c6c

Add more xmldocs

Bartłomiej Dach · 2020-11-01 15:23:03 +01:00

b7696c85ad

Merge branch 'master' into shift-delete-all-selected

Dean Herbert · 2020-11-01 23:03:01 +09:00

1f8d627af4

Merge pull request #10634 from bdach/fix-leftover-selection-box-tooltip

Fix selection box action tooltips still being visible after object deletion

Dean Herbert · 2020-11-01 23:02:29 +09:00

e1b8875553

Fix inaccurate xmldoc

Bartłomiej Dach · 2020-11-01 14:39:10 +01:00

5903c3be90

Ensure LoadOszIntoOsu returns actual imported map

Bartłomiej Dach · 2020-11-01 14:25:33 +01:00

8a54fdd4e6

Extract StatisticCounter to a separate class and use it instead.

Lucas A · 2020-11-01 13:25:36 +01:00

6bfff43634

Merge branch 'master' into fix-beatmap-details-metadata-bounce

Bartłomiej Dach · 2020-10-31 17:36:40 +01:00

f3e0480e77

Merge pull request #10637 from peppy/fix-seasonal-backgrounds-nullref

Fix potential null reference when loading background

Bartłomiej Dach · 2020-10-31 17:36:16 +01:00

7d090e0d2e

Simplify test case

Bartłomiej Dach · 2020-10-31 17:01:45 +01:00

2065680e9d

Migrate existing call to new flag parameter

Bartłomiej Dach · 2020-10-31 16:08:27 +01:00

79f47953a8

Fix player restart invoking user-level pause

Bartłomiej Dach · 2020-10-31 16:08:15 +01:00

19023e7d43

Add flag parameter to allow non-user-pause via music controller

Bartłomiej Dach · 2020-10-31 16:07:54 +01:00

941e8525af

Fix potential null reference when loading background

As seen in
https://discordapp.com/channels/188630481301012481/188630652340404224/772094427342569493.
Caused due to async load of the loader, which means it may not be ready
before Next() is called.

Dean Herbert · 2020-10-31 22:51:35 +09:00

a9a3489e92

Schedule visibility update once per frame

Bartłomiej Dach · 2020-10-31 14:45:11 +01:00

007c27d3ff

Shorten show/hide code

Bartłomiej Dach · 2020-10-31 13:54:02 +01:00

d74c19e2d7

Run OnSelectionChanged() on each change

Bartłomiej Dach · 2020-10-31 13:54:02 +01:00

3322b8a7ea

Bind UpdateVisibility() directly to source of truth