38668 Commits

This Branch

This Branch

All Branches

• Fix mods not being serialised correctly in ScoreInfo
  smoogipoo · 2021-04-12 20:09:01 +09:00
  d2d7f77430
• Update resources
  Dean Herbert · 2021-04-12 19:22:07 +09:00
  905cd7c8eb
• Merge branch 'master' into legacy-spm-counter
  Dean Herbert · 2021-04-12 19:22:03 +09:00
  f139f61837
• Fix TestQuickDeleteRemovesObject failing on second run
  Dean Herbert · 2021-04-12 19:19:25 +09:00
  b4c75ba3c6
• Fix ctrl-dragging on an existing selection causing deselection of the hovered object
  Dean Herbert · 2021-04-12 19:05:23 +09:00
  cc2acf5e54
• Add TODO comment
  ekrctb · 2021-04-12 18:54:36 +09:00
  31d3607105
• Rename property
  ekrctb · 2021-04-12 18:50:25 +09:00
  359fae895f
• Avoid empty list allocation
  ekrctb · 2021-04-12 18:49:38 +09:00
  6d18b3db00
• Merge pull request #12377 from peppy/remove-empty-returns-xmldoc

  Remove empty <returns> xmldoc

  Dan Balasescu · 2021-04-12 18:25:46 +09:00
  e8c248f2b2
• Remove empty <returns> xmldoc
  Dean Herbert · 2021-04-12 17:46:14 +09:00
  b5954a55ad
• Remove #nullable true for now to suppress inspector
  ekrctb · 2021-04-12 17:13:48 +09:00
  f1b8171e38
• Rename CreateChecker -> CreateBeatmapVerifier
  Naxess · 2021-04-12 10:08:30 +02:00
  a2fc9c398f
• Move check origin from IssueTemplate to Issue

  As a result we can also make check an interface, and need to provide the check itself when constructing an issue.

  Naxess · 2021-04-12 10:08:08 +02:00
  65ebdd8f7a
• Update existing overlay containers to not block scroll input
  Dean Herbert · 2021-04-12 16:41:36 +09:00
  0eab9daf13
• Add more FramedReplayInputHandler tests
  ekrctb · 2021-04-12 16:18:35 +09:00
  3c28c09ab5
• Rewrite FramedReplayInputHandler for robustness

  This commit changes the semantics of `CurrentFrame` and `NextFrame` of the class.
  The ordering of `NextFrame.Time` and `CurrentFrame.Time` was dependent on the current direction.
  Now, it should always satisfy `CurrentFrame.Time <= CurrentTime <= NextFrame.Time` except at the start/end.
  This change, however, doesn't break existing deriving classes if the template code pattern usage of interpolation is used.
  The deriving class code can be simplified due to the elimination of nullable types. I didn't include those changes in this commit.
  
  I removed `StreamingFramedReplayInputHandlerTest` for now, as it is almost-duplicate of `FramedReplayInputHandlerTest`. I'll include more tests in later commits.
  
  This commit fixes #6150.

  ekrctb · 2021-04-12 16:18:11 +09:00
  e19e8ff2a3
• Add binding for verify mode (and move enum entry to end)
  Dean Herbert · 2021-04-12 16:15:27 +09:00
  42604afcdc
• Change Metadata into a get property
  Dean Herbert · 2021-04-12 15:52:29 +09:00
  8bf85d737c
• Tidy some remaining code
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  78bbc8f5c8
• Change some methods to get properties
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  8c31e96cdf
• Move enums out of nesting
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  f78239c7f2
• Fix formatting of colour getter
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  3551322f1d
• Colour constants to private
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  257acf9cd8
• Wrap xmldoc less and make a few fixes
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  136627b9ac
• Checker -> BeatmapVerifier
  Dean Herbert · 2021-04-12 15:29:05 +09:00
  1c553b5d48
• Merge branch 'master' into verify-tab
  Dean Herbert · 2021-04-12 15:14:37 +09:00
  14bd5bdc77
• Merge pull request #12374 from smoogipoo/fix-multi-test-failures

  Fix multiplayer test failure

  Dean Herbert · 2021-04-12 14:39:41 +09:00
  5d942e92f3
• Remove temporary input ignore
  Dean Herbert · 2021-04-12 14:29:27 +09:00
  dd1925aaed
• Merge branch 'master' into multiplayer-spectator-player-grid
  Dean Herbert · 2021-04-12 14:14:13 +09:00
  9be3163592
• Remove alt-mousewheel bindings for volume adjustment

  With the recent changes to the order of processing key bindings
  (`GlobalAction`s are handled first), having the alt-wheel bindings in here causes a
  regression as they are handled before `OnScroll` events.
  
  Specifically, this means editor alt-scroll functionality no longer works
  with the default bindings.
  
  Removing the bindings fixes this, while also still allowing alt-wheel
  adjustment of the volume via `VolumeControlReceptor`:
  
  https://github.com/ppy/osu/blob/a2f50af4243dfde95ec556859666b65e34f3007b/osu.Game/Overlays/Volume/VolumeControlReceptor.cs#L21-L26
  
  In conjunction with the special case in `OsuScrollContainer`:
  
  https://github.com/ppy/osu/blob/02d5b1352b6c9971ea83a131c0d2637e167b56b3/osu.Game/Graphics/Containers/OsuScrollContainer.cs#L103-L105

  Dean Herbert · 2021-04-12 14:00:32 +09:00
  995c244cee
• Fix multiplayer test failure
  smoogipoo · 2021-04-12 13:42:14 +09:00
  4fcddfb44b
• Merge branch 'master' into legacy-spm-counter
  Dean Herbert · 2021-04-12 12:52:52 +09:00
  e2470d757e
• Throw when getting a frame of an empty replay
  ekrctb · 2021-04-12 11:17:56 +09:00
  d6d8ea5b6b
• Extract mod setting value handling to utils class
  Salman Ahmed · 2021-04-12 03:37:03 +03:00
  fbd5195738
• Remove Xamarin.Essentials package from main project
  Christine Chen · 2021-04-11 15:51:58 -04:00
  b7e16c2fcc
• Reorder method declaration
  Salman Ahmed · 2021-04-11 15:19:51 -04:00
  419fd4470c
• Add expected output in test case rather than determining internally
  Salman Ahmed · 2021-04-11 13:18:25 -04:00
  cb947a3b27
• Make power status properties abstract
  Salman Ahmed · 2021-04-11 13:18:25 -04:00
  07ee1b4d0b
• Adjust documentation
  Salman Ahmed · 2021-04-11 13:18:25 -04:00
  3d85dc11c6
• Cache power status at base instead
  Salman Ahmed · 2021-04-11 13:18:25 -04:00
  2b947a44da
• Merge branch 'master' into mod-using-reference-equality
  Salman Ahmed · 2021-04-11 19:48:55 +03:00
  18fb9f5ac9
• Merge pull request #12367 from Joehuu/lazy-flashlight

  Add follow delay setting to osu! flashlight mod

  Dean Herbert · 2021-04-11 19:07:06 +09:00
  4853ac802c
• Merge branch 'master' into master
  Salman Ahmed · 2021-04-11 10:19:16 +03:00
  1fd4cb8963
• Add follow delay setting to osu! flashlight mod
  Joseph Madamba · 2021-04-10 23:04:15 -07:00
  a42714540b
• Fix field name and accessibility
  Naxess · 2021-04-10 15:49:57 +02:00
  dac733cced
• Remove old todo
  Naxess · 2021-04-10 15:18:15 +02:00
  7d40b01722
• Merge Check and BeatmapCheck

  We're probably not going to need GeneralChecks or BeatmapsetChecks.
  
  The verify tab is only available to a single difficulty at a time, and we already have access to the rest of the set through `IBeatmap`.

  Naxess · 2021-04-10 14:56:30 +02:00
  3289bb0379
• Improve table formatting
  Naxess · 2021-04-10 13:10:05 +02:00
  747e0f00dc
• Show table even if no issues
  Naxess · 2021-04-10 13:09:16 +02:00
  3a4f2e3d7e
• Remove todo

  Doesn't really matter in the end, as only one checker will run at a time in this case.

  Naxess · 2021-04-10 13:05:24 +02:00
  c995eca029