1
0
mirror of https://github.com/ppy/osu.git synced 2025-02-08 12:23:21 +08:00
Commit Graph

71460 Commits

Author SHA1 Message Date
Dan Balasescu
007bf87a6b
Merge pull request #31723 from peppy/fix-unstable-rate-incrementatl
Fix incremental unstable rate calculation not matching expectations
2025-01-29 23:54:59 +09:00
Dan Balasescu
ca7a36d3d6
Remove unused usings 2025-01-29 23:32:44 +09:00
Bartłomiej Dach
75ef67e959
Merge branch 'master' into two-factor-authentication-code 2025-01-29 13:15:30 +01:00
Bartłomiej Dach
9a9f42c3ff
Merge pull request #31590 from frenzibyte/fix-editor-textbox-regressions
Fix recent editor textbox regressions
2025-01-29 12:08:42 +01:00
Dean Herbert
a6814d1a8a
Make multiplayer change room settings more obvious as to what it does
"Edit" felt really weird.
2025-01-29 19:48:04 +09:00
Bartłomiej Dach
d87720da1b
Merge branch 'master' into fix-editor-textbox-regressions 2025-01-29 11:25:16 +01:00
Bartłomiej Dach
c079969e72
Merge pull request #31417 from peppy/enable-sentry-caching
Enable sentry caching to avoid sentry writing outside of game directory
2025-01-29 11:19:56 +01:00
Dean Herbert
facc9a4dc3
Fix reference hashsets getting emptied before used 2025-01-29 19:15:28 +09:00
Dean Herbert
e8d20fb402
Fix skin SourceChanged event never being unbound 2025-01-29 18:16:04 +09:00
Dean Herbert
9db8e0b7ac
Merge branch 'master' into friend-notification-samples 2025-01-29 17:43:56 +09:00
Dean Herbert
bf40f071eb
Code quality pass 2025-01-29 17:43:49 +09:00
Dean Herbert
4c83ef83ee
Update resources 2025-01-29 17:34:03 +09:00
Dean Herbert
fd1d90cbd9
Update framework
Update framework
2025-01-29 17:32:05 +09:00
Dean Herbert
d8ec3b77e4
Fix incremental unstable rate calculation not matching expectations
The `EventCount` variable wasn't factoring in that some results do not
affect unstable rate. It would therefore become more incorrect as the
play continued.

Closes https://github.com/ppy/osu/issues/31712.
2025-01-29 17:11:12 +09:00
Dean Herbert
6c4b4166ac
Add fail cases to unstable rate incremental testing 2025-01-29 17:10:05 +09:00
Dean Herbert
a3685da250
Merge branch 'master' into enable-sentry-caching 2025-01-29 11:55:23 +09:00
Bartłomiej Dach
b84a9f7820
Merge pull request #31711 from peppy/change-friend-notification-icons
Change friend online notifications' icon and colours
2025-01-28 15:38:27 +01:00
Bartłomiej Dach
99d898326c
Merge pull request #31709 from peppy/catch-od-hide
Remove "Accuracy" from osu!catch editor setup
2025-01-28 15:33:50 +01:00
Dean Herbert
a3a08832b4
Add keywords to make lighten-during-breaks setting discoverable to stable users
See https://github.com/ppy/osu/discussions/31671.
2025-01-28 21:31:51 +09:00
Dean Herbert
017d38af3d
Change friend online notifications' icon and colours
The previous choices made it seem like potentially destructive actions
were being performed. I've gone with neutral colours and more suiting
icons to attempt to avoid this.

---

Addresses concerns in
https://github.com/ppy/osu/discussions/31621#discussioncomment-11948377.

I chose this design even though it wasn't the #1 most popular because I
personally feel that using green/red doesn't work great for these.
2025-01-28 21:29:17 +09:00
Dean Herbert
1aa1137b09
Remove "Accuracy" and "Stack Leniency" from osu!catch editor setup 2025-01-28 21:22:51 +09:00
Dean Herbert
6d39ee2918
Merge pull request #31696 from bdach/do-not-bundle-explicit-beatmaps
Do not bundle explicit beatmaps
2025-01-28 20:39:21 +09:00
Dan Balasescu
a863230983
Merge pull request #31697 from bdach/corrupt-mp3s-should-not-crash-game
Catch and display user-friendly errors regarding corrupted audio files
2025-01-28 14:00:01 +09:00
Dan Balasescu
a075f76344
Merge pull request #31698 from bdach/weird-zips
Work around rare sharpcompress failure to extract certain archives
2025-01-28 13:21:58 +09:00
Bartłomiej Dach
bb8f58f6d6
Work around rare sharpcompress failure to extract certain archives
Closes https://github.com/ppy/osu/issues/31667.

See https://github.com/ppy/osu/issues/31667#issuecomment-2615483900 for
explanation.

For whatever it's worth, I see rejecting this change and telling
upstream to fix it as an equally agreeable outcome, but after I spent an
hour+ tracking this down, writing this diff was nothing in comparison.
2025-01-27 12:28:53 +01:00
Bartłomiej Dach
be9c96c041
Fix infinite loop when switching audio tracks fails on an existing beatmap
Bit ugly, but appears to work in practice...
2025-01-27 10:27:06 +01:00
Bartłomiej Dach
01ae1a58f1
Catch and display user-friendly errors regarding corrupted audio files
Addresses lack of user feedback as indicated by
https://github.com/ppy/osu/issues/31693.
2025-01-27 10:25:22 +01:00
Bartłomiej Dach
e24af4b341
Add inline comments for sets that are not marked FA but should be 2025-01-27 09:40:53 +01:00
Bartłomiej Dach
836a9e5c25
Remove explicit beatmap set from list of bundled beatmap sets 2025-01-27 09:40:20 +01:00
Salman Alshamrani
4d7b071027 Specifiy second-factor authentication code text box with Code type 2025-01-25 23:58:56 -05:00
Salman Alshamrani
c18128e974 Remove OrientationManager and the entire mobile namespace 2025-01-25 20:01:18 -05:00
Salman Alshamrani
bb7daae080 Simplify orientation locking code magnificently 2025-01-25 19:12:43 -05:00
Salman Alshamrani
ffc37cece0 Avoid extra unnecessary DI
Co-authored-by: Dean Herbert <pe@ppy.sh>
2025-01-25 19:12:42 -05:00
Salman Alshamrani
8151c3095d Revert unnecessary inheritance
Everyone is right, too much inheritance and polymorphism backfires very badly.
2025-01-25 19:12:37 -05:00
Salman Alshamrani
dac7d21302 Be explicit on nullability in RequiresPortraitOrientation
Co-authored-by: Dean Herbert <pe@ppy.sh>
2025-01-25 19:12:36 -05:00
Salman Alshamrani
129ab03ec4
Merge pull request #31664 from ThePooN/ios-non-exempt-encryption
🔧 Specify we're not using non-exempt encryption
2025-01-24 13:00:08 -05:00
ThePooN
354126b7f7 🔧 Specify we're not using non-exempt encryption 2025-01-24 18:14:55 +01:00
Bartłomiej Dach
3c763971ff
Merge pull request #31652 from peppy/beatmap-carousel-v2-split-panels
Split out beatmap and set panels in  beatmap carousel v2
2025-01-24 16:00:04 +01:00
Jamie Taylor
79df094f17
Add unique samples for friend online/offline notifications 2025-01-24 23:20:04 +09:00
Bartłomiej Dach
092c7b4253
Merge branch 'master' into beatmap-carousel-v2-split-panels 2025-01-24 15:16:23 +01:00
Bartłomiej Dach
55ab3c72f6
Remove unused field 2025-01-24 15:15:50 +01:00
Dean Herbert
82c5f37c2c
Remove selection animation on set panel 2025-01-24 22:45:08 +09:00
Bartłomiej Dach
b0136f98a9
Fix test failures 2025-01-24 14:24:16 +01:00
Bartłomiej Dach
7845c5cfb7
Merge pull request #31645 from peppy/offset-adjust-more-lenience
Make offset adjust more lenient
2025-01-24 14:01:25 +01:00
Bartłomiej Dach
daec91f61d
Refactor further to avoid weird non-virtual common method 2025-01-24 13:14:31 +01:00
Bartłomiej Dach
b04144df54
Fix behavioural change in interaction between grid & distance snap 2025-01-24 13:14:26 +01:00
Bartłomiej Dach
589035c534
Simplify code 2025-01-24 13:14:06 +01:00
Dean Herbert
a94681158d
Merge pull request #31623 from Layendan/room-context-menu
Add view in browser context menu functionality to multiplayer/playlist rooms
2025-01-24 20:31:49 +09:00
Dean Herbert
da762384f8
Fix breakage from reordering co-reliant variable sets (and guard against it) 2025-01-24 20:20:18 +09:00
Dean Herbert
175eb82ccf
Split out beatmaps and set panels into two separate classes 2025-01-24 20:10:41 +09:00