138 Commits

Author	SHA1	Message	Date
Salman Ahmed	b9859f9f21	Obsolete BeatmapInfo.MaxCombo and suppress in usages	2022-03-20 16:30:29 +03:00
Salman Ahmed	c5cc7eec79	Add explicit todo about removing BeatmapInfo.MaxCombo ... Using that property is a trap basically.	2022-03-20 05:38:14 +03:00
Dean Herbert	acf8db13ac	Store user settings to realm	2022-03-01 18:44:15 +09:00
Dean Herbert	3d3f0a89c2	Remove legacy RulesetID property from BeatmapInfo	2022-02-16 16:46:53 +09:00
Bartłomiej Dach	1b8136e3e0	Change some BeatmapInfo defaults in a backwards compatible manner	2022-01-27 21:49:37 +01:00
Dean Herbert	5288eedd31	Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID	2022-01-27 15:38:03 +09:00
Salman Ahmed	064468faad	Refactor editor saving test scene for scalability	2022-01-26 07:57:46 +03:00
Dean Herbert	deb108816c	Fix some regressions in json output (we need to make all these explicit instead)	2022-01-20 17:09:31 +09:00
Dean Herbert	3faf980fed	Avoid constructor overhead for realm BeatmapInfo parameterless constructor	2022-01-20 16:47:27 +09:00
Dan Balasescu	3e5d29ed00	Merge pull request #16505 from peppy/remove-base-difficulty-usage ... Remove all usage of `BaseDifficulty` (and access `Difficulty` instead)	2022-01-19 13:53:55 +09:00
Dean Herbert	2363130f8b	Add back BaseDifficulty with obsoletion counter to account for custom rulesets	2022-01-19 12:33:56 +09:00
Dean Herbert	3596c6ed5d	Add some missing IgnoredAttributes to reduce automapper overhead	2022-01-18 23:25:30 +09:00
Dean Herbert	7f65f3a47f	Remove all usage of BaseDifficulty (and access Difficulty instead)	2022-01-18 22:57:39 +09:00
Dean Herbert	9a43ed742b	Update automapper spec in line with v11 ... See https://docs.automapper.org/en/latest/11.0-Upgrade-Guide.html for more details.	2022-01-18 15:23:28 +09:00
Dean Herbert	381174e482	Give the placeholder ruleset better defaults to allow tests to work again	2022-01-17 14:40:00 +09:00
Dean Herbert	744084b418	Initialise all parameters is paramaterless constructor for now for added safety	2022-01-17 13:51:30 +09:00
Dean Herbert	9b33fbbee5	Ensure detached when performing model Clone operations on BeatmapInfo/ScoreInfo	2022-01-14 13:08:20 +09:00
Dean Herbert	069d6d2954	Remove pointless compatibility parameter BeatmapSetInfoID	2022-01-13 18:02:10 +09:00
Dean Herbert	eb70a1eeb7	Replace compatibility properties with direct references	2022-01-12 18:13:14 +09:00
Dean Herbert	34aa1bf21d	Sanitise and remove some usages of Detach which are no longer required	2022-01-12 17:49:11 +09:00
Dean Herbert	5f7365e8f3	Ensure scores are cleaned up alongside beatmap so they don't have a null reference	2022-01-12 17:49:11 +09:00
Dean Herbert	f24b2b1be3	Make copying detached changes to realm only exposed for BeatmapSet ... Also fixes remaining issues with the copy process.	2022-01-12 17:49:11 +09:00
Dean Herbert	f451560203	Update null allowances across beatmaps and scores	2022-01-12 17:49:11 +09:00
Dean Herbert	6033a825ed	Ensure BeatmapInfo Difficulty and Metadata is non-null	2022-01-12 17:49:11 +09:00
Dean Herbert	83ccbc1d13	Mention safety failures of Beatmap/Score constructors	2022-01-12 17:00:17 +09:00
Dean Herbert	c831e9107a	Fix BeatmapInfo.Clone potentially not cloning if already detached	2022-01-12 17:00:17 +09:00
Dean Herbert	e5af673b01	Fix incorrect BeatmapInfo.ToString implementation	2022-01-12 17:00:17 +09:00
Dean Herbert	8461eaab46	BeatmapSetInfo detach support	2022-01-12 17:00:16 +09:00
Dean Herbert	dcd69e852e	Add back settable RulesetID for now	2022-01-12 17:00:16 +09:00
Dean Herbert	2a980cc474	Fix BeatmapInfo file lookup not handling the case where no files exist ... Quite common for test scenes.	2022-01-12 17:00:16 +09:00
Dean Herbert	d7fe3584cd	Don't persist Countdown to realm for now ... It's another enum which is a pain to handle, and not actually being consumed anywhere.	2022-01-12 17:00:16 +09:00
Dean Herbert	c3df58e01c	Add required properties to make realm models backwards compatible	2022-01-12 16:39:36 +09:00
Dean Herbert	618903c217	Rename realm to become imposter classes	2022-01-12 16:39:36 +09:00
Dean Herbert	0b6c4497bd	Rename EF classes to allow for shit to hit the fan	2022-01-12 16:39:36 +09:00
Dean Herbert	8d9c37a825	Merge branch 'master' into primary-key-consistency	2021-12-08 21:34:38 +09:00
Dean Herbert	183b95cbc2	Rename BeatmapSetOnlineStatus to BeatmapOnlineStatus ... This variable is used at more than just a set level.	2021-11-24 18:42:49 +09:00
Dean Herbert	3e0e01abdb	Move bookmark parsing logic into LegacyBeatmapDecoder	2021-11-24 16:29:51 +09:00
Dean Herbert	eecf6ad558	Add IsManaged helper method to EF classes to match realm implementation	2021-11-19 21:56:06 +09:00
Dean Herbert	9207b87b76	Add back interface equality but limit to only matching types	2021-11-16 12:35:18 +09:00
Dean Herbert	0b4822b552	Remove newly added equality	2021-11-15 14:35:01 +09:00
Dean Herbert	9f7e2750a5	Merge branch 'master' into beatmap-collection-inteface-types	2021-11-12 19:41:29 +09:00
Dean Herbert	5e88d59a26	Switch BeatmapInfo.OnlineID delegation to use property getter for conformity	2021-11-12 19:06:12 +09:00
Dean Herbert	1d962648c2	Standardise implementations	2021-11-12 19:00:27 +09:00
Dean Herbert	a67e156883	Add IBeatmapInfo equality support	2021-11-12 18:11:33 +09:00
Dean Herbert	6a098a8634	Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface	2021-11-12 17:46:24 +09:00
Dean Herbert	51a353e12d	Rename BeatmapInfo.Version to DifficultyName to match underlying interface	2021-11-11 17:20:53 +09:00
Dean Herbert	ebe58cee11	Rename BeatmapInfo.StarDifficulty to StarRating to match underlying interface	2021-11-11 17:19:46 +09:00
Dean Herbert	4b1b92cde6	Stop BeatmapInfo from implementing IBeatmapOnlineInfo and remove all usages	2021-11-04 15:23:04 +09:00
Dean Herbert	84d36cbae7	Add fallback for cases where BeatmapSet may be null ... Seems to only happen in tests, but better safe than sorry.	2021-11-04 15:22:33 +09:00
Dean Herbert	a49366ff84	Remove nullability from IBeatmapInfo.Metadata	2021-11-04 14:28:39 +09:00