Naxess
304fe5cd34
Add CheckBackground to OsuBeatmapVerifier
2021-04-13 10:41:02 +02:00
Naxess
60c2494b31
Make BeatmapVerifier an interface
2021-04-13 10:40:56 +02:00
Dean Herbert
b41e3a2e7a
Remove unused using statement
2021-04-13 17:38:32 +09:00
Naxess
c8cb4286f6
Add reference for screen bounding box numbers
2021-04-13 10:35:06 +02:00
Naxess
98c25b2e71
Remove unused import
2021-04-13 10:33:08 +02:00
Salman Ahmed
36510309d1
Merge EnableUserDim and IgnoreUserSettings to one bindable
2021-04-13 10:58:56 +03:00
Dean Herbert
0932daeaa8
Force the new default on update
2021-04-13 16:50:03 +09:00
Dean Herbert
5a06db8a11
Change default editor waveform opacity to 25%
...
The previous setting felt way too high.
2021-04-13 16:48:06 +09:00
Dean Herbert
27e851c2ee
Also adjust height
2021-04-13 16:43:29 +09:00
Dean Herbert
ebf97ff48f
Update timeline ticks to use width as a differentiation method, rather than height
2021-04-13 16:29:35 +09:00
Dean Herbert
a9652b7b25
Start TimelineTestScene in a more visible place
2021-04-13 16:05:12 +09:00
ekrctb
57ba7b7cbb
Partially revert the changes of CurrentFrame and NextFrame for compatibility
...
Making those always non-null is postponed as when a replay's frame contains keypress the behavior is changed.
Previously, the key is pressed at the time of the first frame. But using non-null frames means the key is pressed at negative infinity.
However, I think the new way of always using non-null frames makes the client code so I plan to bundle the change to more breaking changes.
2021-04-13 15:55:23 +09:00
Dan Balasescu
20a432c083
Merge pull request #12392 from peppy/avoid-score-online-id-conflicts
...
Don't store online IDs from score submission responses for now
2021-04-13 15:40:03 +09:00
Dan Balasescu
20e84f14e6
Merge pull request #11328 from frenzibyte/mod-using-reference-equality
...
Fix mods using reference equality unless cast to `IMod`
2021-04-13 15:36:22 +09:00
Dean Herbert
fbc6fb8fc5
Split out common logic into private method and add inline comment for future visitors
2021-04-13 15:35:57 +09:00
Salman Ahmed
9f8af03a70
Remove irrelevant change
2021-04-13 09:28:58 +03:00
Dean Herbert
b45d7de4ec
Update asserts to use better nunit specifications
2021-04-13 15:04:01 +09:00
Dean Herbert
4837cef095
Use static for playfield centre positioning
2021-04-13 14:44:52 +09:00
Dean Herbert
273099d53c
Don't store online IDs from score submission responses for now
...
Closes remaining portion of https://github.com/ppy/osu/issues/12372 .
2021-04-13 14:31:44 +09:00
ekrctb
d0f30b7b42
Delay map completion one frame after the last judgment
...
This is a workaround of a timing issue.
KeyCounter is disabled while break time (`HasCompleted == true`).
When the last keypress is exactly at the same time the map ends, the last frame was considered in a break time while forward play but considered not in a break time while rewinding. This inconsistency made the last keypress not decremented in the key counter when a replay is rewound.
The situation regularly happens in osu!standard because the map ends right after the player hits the last hit circle. It was caught by `TestSceneGameplayRewinding`.
This commit makes the update of the map completion delayed one frame. The problematic keypress frame is now processed strictly before the map completion, and the map completion status is correctly rewound before the keypress frame.
2021-04-13 14:29:47 +09:00
Dean Herbert
4852630c93
Fix import multiple file types via drag potentially reaching the wrong importer
2021-04-13 14:03:42 +09:00
Salman Ahmed
a664efe12b
Fix history graph tooltips leaking to others
...
Since there was no check about which tooltip content came from which graph, all history graphs use the "Replays Watched" tooltip, as it is the latest created one.
2021-04-13 07:59:14 +03:00
ekrctb
38d10755cb
Merge branch 'master' into refactor-framed-replay-input-hander
2021-04-13 13:47:22 +09:00
Dean Herbert
516bd138e3
Add (previously failing) test coverage of drag from selection
2021-04-13 13:46:38 +09:00
Dean Herbert
7c975359d9
Add basic select/deselect tests
2021-04-13 13:29:37 +09:00
Dean Herbert
05d7fe289f
Rename test scene in preparation for increasing scope
2021-04-13 13:09:18 +09:00
Dean Herbert
66e74da2b7
Fix regression in quick delete mouse action blocking
2021-04-13 13:03:14 +09:00
Salman Ahmed
17c2c4e885
Fix test case filename not matching
2021-04-13 05:31:56 +03:00
Naxess
6d3f9fa9ce
Use is class instead of Equals with template index
...
Ensures ordering of `PossibleTemplates` does not affect tests.
2021-04-13 02:29:25 +02:00
Naxess
0bcc39bd36
Remove redundant space
2021-04-13 02:17:35 +02:00
Naxess
8a6dfcfae1
Add CheckOffscreenObjects tests
2021-04-13 01:22:36 +02:00
Naxess
47cf4bcf25
Add CheckBackground tests
2021-04-13 01:22:24 +02:00
Naxess
d8088777ea
Add Equals method to IssueTemplate
...
This will be useful in tests.
2021-04-13 01:21:34 +02:00
Salman Ahmed
8f84abf348
Display "replays watched" tooltip for replays subsection
2021-04-12 21:51:06 +03:00
Salman Ahmed
9679bdfed2
Merge branch 'master' into mod-using-reference-equality
2021-04-12 20:56:24 +03:00
Salman Ahmed
589e1a2a47
Add mod settings equality test
2021-04-12 20:51:24 +03:00
Salman Ahmed
92fab653e1
Take current mod settings value into account on equality comparsion
2021-04-12 20:51:13 +03:00
Naxess
d9e3276d0e
Don't update path type once immediately
2021-04-12 19:18:22 +02:00
Dean Herbert
84e1ff79a0
Merge pull request #12352 from smoogipoo/multiplayer-spectator-leaderboard
...
Implement the multiplayer spectator leaderboard
2021-04-13 01:51:14 +09:00
Naxess
19a154ddf1
Rename checkOrigin -> check
...
More consistent with `Issue.ctor`'s "template".
2021-04-12 17:28:12 +02:00
Christine Chen
f66306a81a
Remove IsLowBattery
2021-04-12 11:15:24 -04:00
Naxess
bb720c23a0
Remove check ctors and locals
2021-04-12 17:12:37 +02:00
Christine Chen
43b97fe0ad
Refactor PowerStatus (now called BatteryInfo)
2021-04-12 10:52:52 -04:00
Dean Herbert
62c1812282
Remove redundant parameter naming
2021-04-12 23:37:47 +09:00
Dean Herbert
36bd235021
Move nested classes to bottom of file
2021-04-12 23:36:10 +09:00
Naxess
6d50d01186
Make IssueTemplate.Check readonly
2021-04-12 16:23:05 +02:00
Naxess
caaaba5950
Rename Check -> ICheck
2021-04-12 16:20:53 +02:00
Naxess
008dbc7dd6
Reverse IssueType ordering
...
Reversed both in the enum and where it's displayed, so ends up the same in the end.
2021-04-12 15:49:13 +02:00
Naxess
1c69829ad4
Fix Template.Origin -> Check
2021-04-12 15:47:58 +02:00
Naxess
7c4f6d2b62
Rework template usage
...
Includes moving the origin check back to templates, constructing nested template classes in each check, and making parameterized template usage.
2021-04-12 15:47:26 +02:00
