47869 Commits

This Branch

This Branch

All Branches

• Detach score during import tests to ensure original object doesn't get managed
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  33b5fa3473
• Fix many instances of User being null in score import tests
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  463a185605
• Remove assertion of ScoreInfo.Combo being database persisted
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  d19a9a0ba3
• Mention safety failures of Beatmap/Score constructors
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  83ccbc1d13
• Fix BeatmapInfo.Clone potentially not cloning if already detached
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  c831e9107a
• Ensure Score created by GameplayState has a valid ruleset
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  5dd0bb1218
• Improve legibility of RulesetInfo.Equals
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  82259ee072
• Fix TestScenePresentScore sharing metadata/difficulty across multiple beatmaps
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  fa7dddcf3c
• Add missing Ruleset in ReplayRecorder tests
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  6251713796
• Fix incorrect access to ILive in BeatmapSkinResources tests
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  7e7784b78a
• Fix incorrect BeatmapInfo.ToString implementation
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  e5af673b01
• Update FilterMatchingTest and filter code to use ruleset's OnlineID
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  f2f1adb792
• Remove incorrect test fixture specification
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  ba4ef0926f
• Fix OnlineAvailabilityTracker referencing a value in query that could potentially be null
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  a3c70ccdfc
• Reattach detached items on delete/undelete
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  b619ff1264
• Fix multiple tests via null checks and changing ToLive to Detach

  flow

  Dean Herbert · 2022-01-12 17:00:17 +09:00
  e74a5022c9
• Better handle Statistics to avoid losing data
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  13401a8846
• Fix BeatmapDifficultyCache not working with detached beatmaps
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  76670a8faa
• Fix results screen test failures due to relation query
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  52ca649159
• Fix incorrect ordering and grouping of difficulties at song select
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  6919df18fa
• Handle ignored mappings locally in Detach configuration
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  aaefd72c69
• Detach and reattach scores to make work
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  2b8706b6ce
• Fix potential nullref when song select filters to no results
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  60d2de8a3b
• Fix rulesets being out of order
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  2d2faa72a9
• "Fix" OnlinePlayBeatmapAvailabilityTracker
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  e1f77b87de
• Update realm queries to use Filter to allow for indirect property filtering
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  de3a338d02
• BeatmapSetInfo detach support
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  8461eaab46
• Fix some remaining test failures
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  de076678fe
• Fix some null inspections
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  3811bd8520
• Fix skin lookup when there's no beatmap file available
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  667cdb2475
• Temporarily disable WorkingBeatmapCache and fix multiple invalid data flows
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  33060990b7
• Fix Max lookup methods not checking for zero beatmap count
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  0793b0f0ab
• Add back settable RulesetID for now
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  dcd69e852e
• Fix BeatmapInfo file lookup not handling the case where no files exist

  Quite common for test scenes.

  Dean Herbert · 2022-01-12 17:00:16 +09:00
  2a980cc474
• Fix invalid DI resolution of RealmFileStore
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  167c399e8a
• Fix missing BeatmapMetadata.ToString

  This is relied on by a few usages.

  Dean Herbert · 2022-01-12 17:00:16 +09:00
  99e46cd26b
• Fix invalid equality comparison in BeatmapLeaderboard
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  4295815c7d
• Replace SpectatorScreen event flow with realm subscriptions
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  86ce2256be
• Replace OnlinePlayBeatmapAvailabilityTracker event flow with realm subscriptions
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  5c0d31ed24
• Replace TopLocalRank event flow with realm subscriptions
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  6d60aa7d9c
• Remove updated/removed flow method mapping
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  fe8a5e867d
• Fix missing disposal of realm subscriptions in BeatmapCarousel
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  c9257e9ecc
• Replace ScoreDownloadTracker event flow with realm subscriptions
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  8c4836e87d
• Replace BeatmapDownloadTracker event flow with realm subscriptions
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  00e9f0d41e
• Replace BeatmapLeaderboard event flow with realm subscriptions
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  5dc497e949
• Update ToLive usages in line with recent changes
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  1f9318265e
• Make tests compile again
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  31a3161189
• Remove unused includeProtected parameter
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  db05727ec4
• Remove unnecessary re-query of beatmap set in editor menu construction
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  a3276758b8
• Inline query methods from BeatmapModelManager to BeatmapManager where possible
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  b91f309879