Dean Herbert
e47722565a
Clarify guard condition in RoomSubScreen
2023-07-19 19:39:10 +09:00
Dean Herbert
18aace177a
Fix deadlock when logging out while at the create match screen
...
Closes https://github.com/ppy/osu/issues/24275 .
2023-07-19 19:37:38 +09:00
Dean Herbert
310067b4c3
Update resources
2023-07-19 19:11:19 +09:00
Dean Herbert
eb149942e5
Add ability to toggle all free mods quickly at multiplayer song select
2023-07-19 19:08:32 +09:00
Dean Herbert
61ff3d08d4
Change depth of LegacySongProgress to allow "skinning" via health bar background
2023-07-19 17:48:19 +09:00
Dean Herbert
e283845b71
Adjust legacy skin elements to better align with skinning expectations
2023-07-19 17:45:07 +09:00
Dean Herbert
94c5b8ed32
Apply NRT to TestSceneComposerSelection
2023-07-19 17:22:25 +09:00
Dean Herbert
cf3949c9e2
Fix double-click handling when cyclic selection is enabled
...
Removes the limitations of cyclic selection as a result.
2023-07-19 17:21:20 +09:00
Dean Herbert
d33b174243
Add test coverage of beatmap editor cyclic selection
2023-07-19 17:21:20 +09:00
Dean Herbert
5ec9cd84b2
Change offset calibration control to adjust for all difficulties of the current beatmap set
2023-07-19 17:13:19 +09:00
Dean Herbert
9d46d00294
Update skin editor cyclic test to match expectations better
2023-07-19 16:56:16 +09:00
Dean Herbert
5ade093c5a
Change editor to always perform selection of closest object
2023-07-19 16:56:16 +09:00
Dean Herbert
4e4dcc9846
Add test coverage of selection preferring closest objects
2023-07-19 16:56:16 +09:00
Dean Herbert
55a41b0887
Fix overlap between header text and menu items
2023-07-19 15:13:20 +09:00
Liam DeVoe
15af85226c
adjust test for correct stable notelock
...
stable actually allows for hitobjs to be hit in the middle of sliders, as long as it doesn't interfere with the end time of the slider.
2023-07-19 02:06:29 -04:00
Dean Herbert
871056790b
Mark editor tile as non-localisable
2023-07-19 15:01:20 +09:00
Dean Herbert
7f336b8dac
Merge branch 'master' into editor-metrics
2023-07-19 15:00:51 +09:00
Dean Herbert
4a6a5b174a
Fix editor blueprints being selectable for too long when hit markers are enabled
...
Addresses https://github.com/ppy/osu/discussions/24163 .
2023-07-19 14:59:22 +09:00
Dean Herbert
b9a66ad7b3
Add test coverage of incorrect selection behaviour
2023-07-19 14:59:22 +09:00
Dean Herbert
5e2a0bd733
Fix spawning edge case when elapsed became unexpectedly negative
2023-07-19 14:10:27 +09:00
Dean Herbert
7fa95f7512
Fix #region
2023-07-19 13:52:43 +09:00
Dean Herbert
2e3d1fe950
Fix regression in time jumping behaviour
2023-07-19 13:38:04 +09:00
OliBomby
e7a9175aea
fix skin using wrong stream
2023-07-18 13:08:05 +02:00
Dean Herbert
ba237a0e3a
Convert StarFountain to use ParticleSpewer
...
More efficient
2023-07-18 20:04:52 +09:00
Dean Herbert
ccbb30cdda
Fix ParticleSpewer not correctly accounting for lower frame rates (and spawning less particles)
2023-07-18 19:52:45 +09:00
OliBomby
63dd8bd991
use base.GetFileContents to get file stream
2023-07-18 12:40:48 +02:00
OliBomby
395dd23966
Put 'Export package' and 'Export legacy package' in one nested menu
2023-07-18 12:37:37 +02:00
OliBomby
bcdf531039
truncate end time before start time
2023-07-18 12:28:35 +02:00
OliBomby
5d82190b70
Merge remote-tracking branch 'upstream/master' into legacy-export
2023-07-18 12:18:49 +02:00
OliBomby
c02684d985
truncate hit object end time
2023-07-18 12:18:43 +02:00
Dean Herbert
f4acc86df8
Adjust metrics to closer match expectations
2023-07-18 16:26:37 +09:00
Dean Herbert
49bb0b190a
Split out star constant to reuse in pool definition
2023-07-18 16:14:54 +09:00
Dean Herbert
e6e66c6aef
Remove mention of clock being nullable in IBeatSyncProvider
...
Co-authored-by: Susko3 <Susko3@protonmail.com>
2023-07-18 13:08:23 +09:00
Liam DeVoe
768d7b5e1c
correct implementation of stable notelock
2023-07-17 23:31:21 -04:00
Bartłomiej Dach
88ac53557a
Merge pull request #24236 from Joehuu/remove-android-manifest-overlay
...
Remove android manifest overlay
2023-07-17 22:12:11 +02:00
Bartłomiej Dach
551c243945
Merge pull request #24189 from peppy/discord-rpc-reconnect-fix
...
Re-enable connection retrying on discord connector
2023-07-17 19:58:37 +02:00
NiceAesth
ff529d9df7
Rename variables, fix check message formatting
2023-07-17 20:48:53 +03:00
Bartłomiej Dach
17aac0694e
Re-enable connection retrying on discord connector
2023-07-17 19:19:03 +02:00
Dean Herbert
66269be189
Merge pull request #24256 from tybug/update-download-icon
...
Use `FontAwesome.Download` for updates instead of `FontAwesome.Upload`
2023-07-17 12:25:04 +09:00
NiceAesth
b3974b34e7
Test break checks
2023-07-16 23:03:30 +03:00
NiceAesth
3888471148
Add break length and bounds checks
2023-07-16 23:03:21 +03:00
Liam DeVoe
6200e207d2
use fa_download for updates instead of fa_upload
2023-07-16 15:21:15 -04:00
Dean Herbert
a472fe6789
Merge pull request #24255 from bdach/multiplayer-disconnection-schedule-bomb
...
Fix several issues in multiplayer exit-on-disconnection flow
2023-07-17 04:04:38 +09:00
Bartłomiej Dach
7fbd47e9ee
Fix MultiplayerMatchSubScreen erroneously pushing exit dialog on API failure
...
If `IAPIProvider.State` changes from `Online` at any point when being on
an `OnlinePlayScreen`, it will be forcefully exited from. However,
`MultiplayerMatchSubScreen` had local logic that suppressed the exit in
order to show a confirmation dialog.
The problem is, that in the suppression logic,
`MultiplayerMatchSubScreen` was checking
`MultiplayerClient.IsConnected`, which is a SignalR flag, and was not
checking `IAPIAccess.State`, which is maintained separately. Due to
differing timeouts and failure thresholds, it is not impossible to have
`MultiplayerClient.IsConnected == true` but `IAPIAccess.State !=
APIState.Online`.
In such a case, the match subscreen would wrongly consider itself to be
still online and due to that, push useless confirmation dialogs, while
being in the process of being forcefully exited. This then caused the
dialog to cause a crash, as it was calling `.Exit()` on the screen which
would already have been exited by that point, by the force-exit flow.
2023-07-16 19:56:22 +02:00
Bartłomiej Dach
cd02a8a9ca
Fix PopupDialog potentially accumulating schedules during load
2023-07-16 19:43:37 +02:00
Dean Herbert
a6b1559e1f
Update DiscordRichPresence to pull in performance fix
...
See https://github.com/Lachee/discord-rpc-csharp/pull/237
2023-07-17 02:24:51 +09:00
Dean Herbert
acb51dfca3
Merge pull request #24246 from bdach/fix-exit-dialog-crash
...
Fix potential crash in confirm exit dialog while attempting to exit game
2023-07-17 01:11:07 +09:00
Dean Herbert
e25cd03e4b
Update framework
2023-07-17 00:55:25 +09:00
Bartłomiej Dach
a42992d3fd
Remove unused local variable
2023-07-16 17:10:26 +02:00
Bartłomiej Dach
d25a03984b
Fix PerformAction<T>() potentially crashing when no matching button is found
2023-07-16 16:55:20 +02:00
