774 Commits

• Merge pull request #34904 from bdach/local-rank-includes-unproven-scores

  Treat guest user scores & scores of unknown users as the local user's

  Dean Herbert · 2025-09-04 17:06:51 +09:00
  f1d06f796a
• Extract helper method for retrieving all user local scores
  Bartłomiej Dach · 2025-09-03 12:05:02 +02:00
  0bbad3e1cd
• Hide object-typed CurrentSelection and expose strongly-typed alternatives instead
  Bartłomiej Dach · 2025-09-03 10:24:25 +02:00
  4a7ee6fafc
• Simplify beatmap access in carousel panels
  Bartłomiej Dach · 2025-09-03 09:52:37 +02:00
  315eea8d9a
• Merge branch 'master' into carousel-multiple-copies-of-beatmap-clean
  Dean Herbert · 2025-09-03 15:35:03 +09:00
  566562240e
• Cancel underlying web request on local cancellation of lookup request
  Dean Herbert · 2025-09-01 18:00:52 +09:00
  9d0043d03b
• Fix cancellation token not actually being used
  Dean Herbert · 2025-09-01 18:00:52 +09:00
  0021434a62
• Fix rewind not working over grouping mode changes
  Bartłomiej Dach · 2025-08-29 14:42:32 +02:00
  4ffc262073
• Fix presenting individual beatmaps from main menu breaking

  In this case `CurrentSelection` is being set on the song select screen's
  `OnEntering()`, at which point grouping is not yet known.

  Bartłomiej Dach · 2025-08-29 13:45:27 +02:00
  2b52c1de0b
• Do not attempt to refresh group in current selection if grouping is not relevant
  Bartłomiej Dach · 2025-08-29 13:25:08 +02:00
  89492cbd81
• Fix stale group refresh logic inadvertently losing selection entirely sometimes
  Bartłomiej Dach · 2025-08-29 13:25:08 +02:00
  1bb24c923d
• Allow BeatmapCarousel.CurrentSelection to accept raw BeatmapInfos (and redirect to appropriate grouped beatmap)

  This is probably where things get a little controversial.
  
  There are some song select flows wherein song select just wants to
  ensure sanity by authoritatively setting the global beatmap. The goal is
  to change the beatmap immediately and instantly. Therefore it should
  kind of be the carousel's job to figure out its grouping complications.
  
  To that end, `CurrentSelection` is made virtual, and overridden in
  `BeatmapCarousel` to perform a sort of reconciliation logic. If an
  external component sets `CurrentSelection` to a `BeatmapInfo`, one of
  the two following things happen:
  
  - Nothing, if the current `GroupedBeatmap` is already a copy of the
    beatmap that needs to be selected, or
  
  - The carousel looks at its items, finds any first copy which matches
    the beatmap that the external consumer wanted selected, and changes
    selection to that instead.

  Bartłomiej Dach · 2025-08-29 13:25:08 +02:00
  dfed564bda
• Fix standalone beatmap panels not having the correct height
  Bartłomiej Dach · 2025-08-29 13:25:08 +02:00
  3cf0a9b9c0
• Fix changing group mode causing CurrentSelection to retain a stale GroupDefinition
  Bartłomiej Dach · 2025-08-29 13:25:08 +02:00
  107e103825
• Fix carousel selection not working

  Basically, `BeatmapCarousel.CurrentSelection`, which is
  magic-object-typed, can no longer use `BeatmapInfo` directly, it now
  must also use `GroupedBeatmap`.
  
  This spills out all the way into song select because of beatmap
  selection flows that require hookup from song select.

  Bartłomiej Dach · 2025-08-29 13:25:01 +02:00
  d4b357dfa0
• Introduce new model for "beatmaps under grouping" & allow beatmaps to appear in multiple groups

  This bypasses the immediate first issue of not being able to display
  multiple instances of a beatmap on the carousel because of model
  equality being baked into the structure. It inevitably poses a bunch of
  *other* problems, but it's a start.

  Bartłomiej Dach · 2025-08-29 13:12:12 +02:00
  a84c364e44
• Make grouping by collections and rank achieved testable without involving realm
  Bartłomiej Dach · 2025-08-29 13:12:12 +02:00
  d304a31757
• Merge branch 'master' into online-lookups-on-reenter
  Dean Herbert · 2025-08-29 19:03:41 +09:00
  3ca5e20e70
• Merge branch 'master' into carousel-multi-grouping-clean
  Bartłomiej Dach · 2025-08-29 10:41:46 +02:00
  51ed19cb99
• Apply suggested rename
  Bartłomiej Dach · 2025-08-29 09:58:56 +02:00
  526ee32268
• Fix song select not performing online lookup on re-enter

  Closes https://github.com/ppy/osu/issues/34825.
  
  Root cause is
  
  	https://github.com/ppy/osu/blob/24ec43b3b65fa3b164b7713341cd62b1e0dacc2e/osu.Game/Screens/SelectV2/SongSelect.cs#L345-L356
  
  not specifying `(..., true)`, therefore the fetch doesn't happen on
  enter if song select doesn't change the global beatmap as a side effect
  of the enter, which is the case on re-entering.

  Bartłomiej Dach · 2025-08-29 09:31:20 +02:00
  df6d6edaca
• Support beatmap sets being split apart by the active group mode in beatmap carousel
  Bartłomiej Dach · 2025-08-28 13:09:08 +02:00
  8dd131f17e
• Ensure filtering also runs after local gameplay LastPlayed changes
  Dean Herbert · 2025-08-28 19:10:20 +09:00
  7e109add96
• Merge branch 'master' into fix-difficulty-churn
  Dean Herbert · 2025-08-28 02:38:10 +09:00
  ed15e1fb88
• Fix hidden beatmap state not being reflected immediately
  Dean Herbert · 2025-08-28 02:33:18 +09:00
  8a6c857719
• Allow grouping modes that apply max aggregate to split beatmap sets apart
  Bartłomiej Dach · 2025-08-27 14:45:20 +02:00
  4030383276
• Apply in more places
  Dean Herbert · 2025-08-27 19:59:44 +09:00
  f9c1b24df4
• Fix beatmap panels locally handling mod changes unnecessarily

  The `BeatmapDifficultyCache` handles mod changes, so handling locally is
  unnecessary. By handling locally, it creates a visual issue when
  adjusting mods often. Test using Ctrl +/- at song select and observing
  that without this change, the star rating will flicker back to the
  default due to the local re-fetch.

  Dean Herbert · 2025-08-27 18:31:50 +09:00
  fda40d7fd5
• Fix beatmap carousel re-filtering when it doesn't need to

  Local rules ensure we only handle callbacks when we need to.

  Dean Herbert · 2025-08-27 18:21:19 +09:00
  be6fb9aa77
• Avoid triggering changes when add operations are empty

  Only seems to happen in tests. I think.

  Dean Herbert · 2025-08-27 18:13:13 +09:00
  0e57ee9ba6
• Work around excessive refreshes of carousel beatmap set panel backgrounds

  Closes https://github.com/ppy/osu/issues/34511 I guess.

  Bartłomiej Dach · 2025-08-26 13:27:54 +02:00
  c0fd5637de
• Fix song select favourite button potentially showing stale data from (un)favourite request callback
  Bartłomiej Dach · 2025-08-22 14:25:25 +02:00
  5292d4a04e
• Pull up online beatmap set lookup to song select level to avoid two components doing the same fetch independently
  Bartłomiej Dach · 2025-08-22 14:25:21 +02:00
  d3ae20dd88
• Merge pull request #34723 from bdach/status-updates-are-great-arent-they

  Refresh realm before performing song select refetches following an online metadata lookup

  Dean Herbert · 2025-08-22 20:25:36 +09:00
  c852e5854c
• Fix song select background being stuck in revealed state

  Closes https://github.com/ppy/osu/issues/34731.
  
  The failure scenario here is as follows:
  
  - User holds down left mouse button for >200ms to reveal the background.
  - User presses down another mouse button and releases it in <200ms.
  - User releases left mouse button. Song select does not return.
  
  The timing here is key because what is happening here is that the second
  mouse button press is overwriting the `revealingBackground` scheduled
  delegate. Releasing that same mouse button within 200ms leads to that
  scheduled delegate being cancelled and cleared, and thus the release of
  left mouse wrongly decides there is nothing left to do.
  
  One thing I'm not entirely sure about is the release behaviour even with
  this change; as things stand, the first release of any mouse button will
  bring song select back, even if it was not the button that was initially
  held down to reveal the background. That's probably easily fixed if
  deemed required, but I'm most interested in fixing the bad breakage.

  Bartłomiej Dach · 2025-08-21 11:31:37 +02:00
  a7f1795f98
• Merge pull request #34710 from LumpBloom7/SSV2-beatmap-panel-missing-ruleset-icon

  Use fallback icon in `PanelBeatmap` if ruleset is not found

  Dean Herbert · 2025-08-19 17:48:17 +09:00
  35ab30e83f
• Merge pull request #34725 from bdach/bpm-grouping-off-by-one-once-more

  Fix BPM grouping mode not defining a group for 290 - 300 BPM range

  Bartłomiej Dach · 2025-08-18 13:32:16 +02:00
  4c10d941b3
• Fix BPM grouping mode not defining a group for 290 - 300 BPM range

  closes https://github.com/ppy/osu/issues/34724

  Bartłomiej Dach · 2025-08-18 10:49:07 +02:00
  322f7220f8
• Refresh realm before performing song select refetches following an online metadata lookup

  Probably closes https://github.com/ppy/osu/issues/34716
  
  Can't see any other cause, can reproduce the issue on master using
  manual db modifications via realm studio and it is not a consistent
  reproduction, so seems like an open-and-shut lack of refresh.

  Bartłomiej Dach · 2025-08-18 09:48:32 +02:00
  a393b3c6b1
• Restore isHovered check to FooterButtonRandom.OnMouseUp
  person4268 · 2025-08-17 18:48:08 -04:00
  4a65c531e7
• Use fallback icon if ruleset is not found
  Derrick Timmermans · 2025-08-17 16:11:42 +02:00
  a1fb7acef3
• Merge pull request #33558 from frenzibyte/ssv2-crash

  Fix song select crashing on beatmap with two difficulties of same online ID

  Bartłomiej Dach · 2025-08-15 08:50:51 +02:00
  0e5900add9
• Merge pull request #34640 from bdach/multiple-tag-filters

  Add support for specifying multiple user tag filters at once

  Dean Herbert · 2025-08-15 02:39:47 +09:00
  734043fb0d
• Also ensure that ordering doesn't matter
  Dean Herbert · 2025-08-14 21:14:35 +09:00
  7a1cad7312
• Merge branch 'master' into ssv2-crash
  Salman Alshamrani · 2025-08-14 14:09:54 +03:00
  347d621437
• Fix tags popover search functionality not always working

  This is super haphazard in the first place but I'm going to look past
  that for now.
  
  Basically, due to the order of operation, the tags could be initialised
  via `updateTags()` before the perform search action was initialised,
  leading to clicks doing nothing.

  Dean Herbert · 2025-08-14 19:43:03 +09:00
  6c4c2c1a6a
• Remove TODO comment
  Salman Alshamrani · 2025-08-14 12:38:04 +03:00
  693c39c23b
• Fix FilterCriteria only being able to support one tag filter at once

  Other textual keyword filters also worked like that, wherein if you did
  `artist=a artist=b` the second filter would overwrite the second, but in
  those cases the query is against a single field, so attempting to put
  multiple search criteria in conjunction on a single field is kind of
  nonsensical, so it was sort of fine to do that.
  
  Which is not the case for user tags, which are multi-valued.

  Bartłomiej Dach · 2025-08-13 10:24:54 +02:00
  3fb1880466
• Merge pull request #34625 from peppy/fix-song-select-event-feedback

  Fix selection being finalised immediately on beatmap updates arriving

  Bartłomiej Dach · 2025-08-12 14:57:01 +02:00
  734dea1be4
• Fix selection being finalised immediately on beatmap updates arriving
  Dean Herbert · 2025-08-12 20:22:37 +09:00
  4c734c2a0e