17625 Commits

• Merge pull request #34911 from bdach/fix-no-report-in-playlists

  Fix not being able to report users from playlists chat

  Dean Herbert · 2025-09-04 17:08:08 +09:00
  3fcc8d45cb
• Merge pull request #34904 from bdach/local-rank-includes-unproven-scores

  Treat guest user scores & scores of unknown users as the local user's

  Dean Herbert · 2025-09-04 17:06:51 +09:00
  f1d06f796a
• Fix not being able to report users from playlists chat

  Reported internally.

  Bartłomiej Dach · 2025-09-04 09:45:32 +02:00
  be365dfdc5
• Merge branch 'master' into argon-judgement-counter
  Bartłomiej Dach · 2025-09-03 13:01:57 +02:00
  dac534e22a
• Extract helper method for retrieving all user local scores
  Bartłomiej Dach · 2025-09-03 12:05:02 +02:00
  0bbad3e1cd
• Merge pull request #34842 from bdach/carousel-multiple-copies-of-beatmap-clean

  Allow beatmaps to show up multiple times in the carousel if grouping criteria requires it

  Dean Herbert · 2025-09-03 18:47:25 +09:00
  19d194476f
• Hide object-typed CurrentSelection and expose strongly-typed alternatives instead
  Bartłomiej Dach · 2025-09-03 10:24:25 +02:00
  4a7ee6fafc
• Simplify beatmap access in carousel panels
  Bartłomiej Dach · 2025-09-03 09:52:37 +02:00
  315eea8d9a
• Merge pull request #34892 from bdach/shift-click-beatmap-card

  Download online beatmap / present local beatmap on shift-clicking beatmap cards

  Dean Herbert · 2025-09-03 16:19:48 +09:00
  1e50e36a64
• Merge pull request #34891 from bdach/multi-spectator-player-fail

  Adjust fail handling in multiplayer spectator player to permit showing F rank

  Dean Herbert · 2025-09-03 15:40:20 +09:00
  48e4844fbb
• Merge branch 'master' into carousel-multiple-copies-of-beatmap-clean
  Dean Herbert · 2025-09-03 15:35:03 +09:00
  566562240e
• Add menu tip exposing new behaviour
  Dean Herbert · 2025-09-03 15:27:29 +09:00
  19361666a1
• Merge pull request #34880 from minetoblend/fix/editor-player-crash

  Fix crash when trying to test map in the editor

  Dean Herbert · 2025-09-03 02:31:42 +09:00
  f414dd70f5
• Use better guard (and reword subsequent comment)

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2025-09-02 12:42:07 +02:00
  4ed72efeae
• Adjust fail handling in multiplayer spectator player to match multiplayer player

  Closes https://github.com/ppy/osu/issues/34884.

  Bartłomiej Dach · 2025-09-02 12:38:34 +02:00
  5c6bbfcc6a
• Move solo spectator-specific fail logic to SoloSpectatorPlayer
  Bartłomiej Dach · 2025-09-02 12:25:42 +02:00
  9354547e15
• Use SingleOrDefault() instead of LastOrDefault()

  `LastOrDefault()` is arbitrary, and I hope this doesn't matter for
  anything, because if it does, then that's utterly *horrifying*.

  Bartłomiej Dach · 2025-09-02 08:08:23 +02:00
  903d91b697
• Add one more comment
  Bartłomiej Dach · 2025-09-02 08:08:22 +02:00
  b0dcd06b38
• Merge pull request #34887 from smoogipoo/fix-editor-leak
  Dean Herbert · 2025-09-02 11:31:14 +09:00
  9422fe52d1
• Fix editor memory leak
  Dan Balasescu · 2025-09-02 09:21:31 +09:00
  cac136d3c6
• Move null check after loop over nested hitobjects
  Marvin Schürz · 2025-09-01 13:13:28 +02:00
  ffb6ae2066
• Fix mismatch in cutoff time check between preventMissOnPreviousHitObjects and markPreviousObjectsHit
  Marvin Schürz · 2025-09-01 13:05:22 +02:00
  385529ec78
• Add basic spacing between participants in list
  Dean Herbert · 2025-09-01 19:52:29 +09:00
  cf471066bf
• Adjust sizing of room panels and other elements to make things fit better on mobile layouts
  Dean Herbert · 2025-09-01 19:52:29 +09:00
  659480fa3f
• Reduce size of online play screen's header
  Dean Herbert · 2025-09-01 19:40:39 +09:00
  209ba76b21
• Revert moving markPreviousObjectsHit into LoadAsyncComplete

  Running that there caused a test failure due to modifying drawables' transforms outside the update thread

  Marvin Schürz · 2025-09-01 12:10:12 +02:00
  060854f23a
• Prevent npr in tests due to drawable ruleset not being available
  Marvin Schürz · 2025-09-01 11:12:19 +02:00
  689cc27e68
• Move markPreviousObjectsHit into LoadAsyncComplete
  Marvin Schürz · 2025-09-01 11:11:26 +02:00
  da7e256302
• Recursively update hit results for nested drawables
  Marvin Schürz · 2025-09-01 11:10:30 +02:00
  9827f9f189
• Cancel underlying web request on local cancellation of lookup request
  Dean Herbert · 2025-09-01 18:00:52 +09:00
  9d0043d03b
• Fix cancellation token not actually being used
  Dean Herbert · 2025-09-01 18:00:52 +09:00
  0021434a62
• Merge branch 'master' into pinned-rooms
  Dean Herbert · 2025-09-01 16:01:50 +09:00
  4e976cff6a
• Fix crash when marking previous objects as hit
  marvin · 2025-08-30 19:36:17 +02:00
  d6b4c2958d
• Fix rewind not working over grouping mode changes
  Bartłomiej Dach · 2025-08-29 14:42:32 +02:00
  4ffc262073
• Fix presenting individual beatmaps from main menu breaking

  In this case `CurrentSelection` is being set on the song select screen's
  `OnEntering()`, at which point grouping is not yet known.

  Bartłomiej Dach · 2025-08-29 13:45:27 +02:00
  2b52c1de0b
• Do not attempt to refresh group in current selection if grouping is not relevant
  Bartłomiej Dach · 2025-08-29 13:25:08 +02:00
  89492cbd81
• Fix stale group refresh logic inadvertently losing selection entirely sometimes
  Bartłomiej Dach · 2025-08-29 13:25:08 +02:00
  1bb24c923d
• Allow BeatmapCarousel.CurrentSelection to accept raw BeatmapInfos (and redirect to appropriate grouped beatmap)

  This is probably where things get a little controversial.
  
  There are some song select flows wherein song select just wants to
  ensure sanity by authoritatively setting the global beatmap. The goal is
  to change the beatmap immediately and instantly. Therefore it should
  kind of be the carousel's job to figure out its grouping complications.
  
  To that end, `CurrentSelection` is made virtual, and overridden in
  `BeatmapCarousel` to perform a sort of reconciliation logic. If an
  external component sets `CurrentSelection` to a `BeatmapInfo`, one of
  the two following things happen:
  
  - Nothing, if the current `GroupedBeatmap` is already a copy of the
    beatmap that needs to be selected, or
  
  - The carousel looks at its items, finds any first copy which matches
    the beatmap that the external consumer wanted selected, and changes
    selection to that instead.

  Bartłomiej Dach · 2025-08-29 13:25:08 +02:00
  dfed564bda
• Fix standalone beatmap panels not having the correct height
  Bartłomiej Dach · 2025-08-29 13:25:08 +02:00
  3cf0a9b9c0
• Fix changing group mode causing CurrentSelection to retain a stale GroupDefinition
  Bartłomiej Dach · 2025-08-29 13:25:08 +02:00
  107e103825
• Fix carousel selection not working

  Basically, `BeatmapCarousel.CurrentSelection`, which is
  magic-object-typed, can no longer use `BeatmapInfo` directly, it now
  must also use `GroupedBeatmap`.
  
  This spills out all the way into song select because of beatmap
  selection flows that require hookup from song select.

  Bartłomiej Dach · 2025-08-29 13:25:01 +02:00
  d4b357dfa0
• Introduce new model for "beatmaps under grouping" & allow beatmaps to appear in multiple groups

  This bypasses the immediate first issue of not being able to display
  multiple instances of a beatmap on the carousel because of model
  equality being baked into the structure. It inevitably poses a bunch of
  *other* problems, but it's a start.

  Bartłomiej Dach · 2025-08-29 13:12:12 +02:00
  a84c364e44
• Make grouping by collections and rank achieved testable without involving realm
  Bartłomiej Dach · 2025-08-29 13:12:12 +02:00
  d304a31757
• Merge branch 'master' into online-lookups-on-reenter
  Dean Herbert · 2025-08-29 19:03:41 +09:00
  3ca5e20e70
• Merge branch 'master' into carousel-multi-grouping-clean
  Bartłomiej Dach · 2025-08-29 10:41:46 +02:00
  51ed19cb99
• Apply suggested rename
  Bartłomiej Dach · 2025-08-29 09:58:56 +02:00
  526ee32268
• Fix song select not performing online lookup on re-enter

  Closes https://github.com/ppy/osu/issues/34825.
  
  Root cause is
  
  	https://github.com/ppy/osu/blob/24ec43b3b65fa3b164b7713341cd62b1e0dacc2e/osu.Game/Screens/SelectV2/SongSelect.cs#L345-L356
  
  not specifying `(..., true)`, therefore the fetch doesn't happen on
  enter if song select doesn't change the global beatmap as a side effect
  of the enter, which is the case on re-entering.

  Bartłomiej Dach · 2025-08-29 09:31:20 +02:00
  df6d6edaca
• Merge pull request #34808 from peppy/fix-difficulty-churn

  Fix beatmap carousel triggering full filters more often than it needs to

  Bartłomiej Dach · 2025-08-28 14:26:25 +02:00
  3eaa5314ac
• Support beatmap sets being split apart by the active group mode in beatmap carousel
  Bartłomiej Dach · 2025-08-28 13:09:08 +02:00
  8dd131f17e
• Ensure filtering also runs after local gameplay LastPlayed changes
  Dean Herbert · 2025-08-28 19:10:20 +09:00
  7e109add96