37 Commits

• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix BeatmapInfoWedge test potentially failing due to quick initial load

  Was doing a comparison of previous vs new content after explicitly doing
  a load in a previous step.

  Dean Herbert · 2022-07-02 13:03:14 +09:00
  1a14808c39
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix test failure due to async-loading of content
  Salman Ahmed · 2022-05-20 19:08:41 +03:00
  1f17652c1d
• Apply rate multiplier outside BPM rounding
  Salman Ahmed · 2022-05-20 18:04:12 +03:00
  84a3cee452
• Add failing test case
  Salman Ahmed · 2022-05-20 17:53:28 +03:00
  de8aedf348
• Remove song source from main wedge display

  This was definitely added at someone's request, since I wouldn't have
  put it here. But it's displayed below in the details section already and
  also not displayed in the updated "wedge" in the new design.
  
  See https://github.com/ppy/osu/discussions/17537 for discussion.

  Dean Herbert · 2022-03-30 17:59:40 +09:00
  bc0b982102
• Merge pull request #16505 from peppy/remove-base-difficulty-usage

  Remove all usage of `BaseDifficulty` (and access `Difficulty` instead)

  Dan Balasescu · 2022-01-19 13:53:55 +09:00
  3e5d29ed00
• Remove all usage of AuthorString
  Dean Herbert · 2022-01-18 23:30:40 +09:00
  67bf95bc91
• Remove all usage of BaseDifficulty (and access Difficulty instead)
  Dean Herbert · 2022-01-18 22:57:39 +09:00
  7f65f3a47f
• Fix intermittent test failures in TestScenBeatmapInfoWedge due to async load

  https://github.com/ppy/osu/runs/4358685294?check_suite_focus=true
  
  Occurs due to the wedge content also reloading on ruleset change, which
  wasn't being accounted for. In a fail case, the content would change
  during the "select beatmap" step's async load wait, causing incorrect
  results.
  
  https://github.com/ppy/osu/blob/51a353e12db189f9958228d30fe045b8460c6b92/osu.Game/Screens/Select/BeatmapInfoWedge.cs#L70

  Dean Herbert · 2021-11-30 12:32:09 +09:00
  a73919917c
• Rename BeatmapSetOnlineStatus to BeatmapOnlineStatus

  This variable is used at more than just a set level.

  Dean Herbert · 2021-11-24 18:42:49 +09:00
  183b95cbc2
• Rename BeatmapInfo.Version to DifficultyName to match underlying interface
  Dean Herbert · 2021-11-11 17:20:53 +09:00
  51a353e12d
• Rename BeatmapInfo.StarDifficulty to StarRating to match underlying interface
  Dean Herbert · 2021-11-11 17:19:46 +09:00
  ebe58cee11
• Add failing test case
  Bartłomiej Dach · 2021-08-22 19:16:43 +02:00
  e4a8f72167
• Add visual test slider for changing star difficulty in beatmap wedge
  Salman Ahmed · 2021-08-17 05:46:14 +03:00
  eb6c6830bc
• Merge branch 'master' into add-missing-author-links
  Dean Herbert · 2021-05-07 14:32:44 +09:00
  165f443ab5
• Rename Container to DisplayedContent
  Dean Herbert · 2021-05-06 02:14:04 +09:00
  fe9ade6754
• Removed unnecessary class for wrapping
  Denrage · 2021-05-05 18:50:49 +02:00
  b6b9a69601
• Remove unnecessary redirection property to Container.Info
  Dean Herbert · 2021-05-05 21:07:49 +09:00
  4ef901d08d
• Refactored background of BeatmapInfoWedge
  Denrage · 2021-04-21 15:46:11 +02:00
  0dfd0bb59d
• Moved Info and Background into own container
  Denrage · 2021-04-21 15:43:29 +02:00
  9fba87f67a
• splitted updateable part of wedge
  Denrage · 2021-04-20 10:37:52 +02:00
  505a117862
• Fixed Tests
  Denrage · 2021-04-19 19:24:58 +02:00
  c73bbf0aa7
• Make labels disappear on null beatmap/no hitobjects
  smoogipoo · 2021-02-25 23:36:02 +09:00
  01a4815412
• Fix failing tests doing reference comparisons between string and LocalisedString
  Dean Herbert · 2021-02-25 17:49:54 +09:00
  3802cb29a4
• Apply changes to UI components overriding functions with changing signatures
  Dean Herbert · 2021-02-22 19:01:42 +09:00
  1fd76ea3fb
• Resolve more CA1805 inspections
  Bartłomiej Dach · 2020-11-01 20:51:23 +01:00
  164370bc7d
• Revert changes to make HitObject abstract
  Dean Herbert · 2020-02-25 19:07:15 +09:00
  a047456354
• Fix hitobjects with unknown lifetimes by enforcing non-null judgement

  We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
  due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
  CreateJudgement() must be implemented and return a non-null judgement.
  
  This fixes BananaShower and JuiceStreams in osu!catch.
  
  This also makes HitObject abstract and cleans up convert HitObject implementations.

  Dean Herbert · 2020-02-23 13:49:06 +09:00
  ffc7eaa3f2
• Fix CI errors
  Joehu · 2019-09-24 16:48:22 -07:00
  102dbd85bd
• Update beatmap info wedge tests
  Joehu · 2019-09-24 16:23:36 -07:00
  cc6030ca14
• Add truncation test
  Joehu · 2019-09-24 16:21:08 -07:00
  8efba255c3
• Update VisibilityContainer usage in line with framework
  Dean Herbert · 2019-06-11 15:13:58 +09:00
  609a82bc94
• Centralise and update WorkingBeatmap creation in test cases
  Dean Herbert · 2019-05-31 14:40:53 +09:00
  f33a5bc54c
• Rename test cases to test scenes inline with the framework change
  Roman Kapustin · 2019-05-14 22:37:25 +03:00
  459a285cd8