osu-lazer

Merge branch 'master' into stable-hitwindow-tests

Bartłomiej Dach · 2025-04-17 11:40:50 +02:00

2eb3bfa232

Merge pull request #32770 from bdach/replay-stability-tests

Add test cases for lazer-specific replay instability due to truncation issue

Dean Herbert · 2025-04-17 18:33:27 +09:00

66802d2a97

Add theoretically-valid-but-practically-not commented-out test cases

Bartłomiej Dach · 2025-04-17 10:36:04 +02:00

a82bb5c2f6

Merge pull request #32819 from peppy/song-select-v2-unrelated-changes

Apply various minor refactors (split out from song select v2 ongoing work)

Bartłomiej Dach · 2025-04-16 14:54:53 +02:00

81fb058c9a

Add animated fade when online status pill has an unknown status

Dean Herbert · 2025-04-16 19:41:50 +09:00

07d0c7443c

Disable masking of Carousel

The default for carousels should be unmasked as their usage generally
sees them overflowing outside their main usage area (see `bleed`
variables).

Dean Herbert · 2025-04-16 19:41:49 +09:00

376b4e8929

Add global screen margin for new screen designs

Dean Herbert · 2025-04-16 19:41:49 +09:00

1cca936e28

Avoid adding arbitrary background in SongSelectComponentsTestScene

Dean Herbert · 2025-04-16 19:41:49 +09:00

4c1f4a512c

Make some test methods static for future reuse

Dean Herbert · 2025-04-16 19:41:49 +09:00

2ac1b89037

Add keywords for converted setting

Dean Herbert · 2025-04-16 19:41:48 +09:00

6021d85e63

Merge pull request #32757 from smoogipoo/playlist-completion-icon

Add display to show completed playlist items

Dean Herbert · 2025-04-16 19:41:12 +09:00

435f03745f

Use full namespace isntead of weird using statement

Dean Herbert · 2025-04-16 19:40:47 +09:00

6fe1695d39

Merge pull request #32818 from peppy/rename-everything

Rename song select v2 classes and namespaces

Dean Herbert · 2025-04-16 19:36:10 +09:00

3d72644cd3

Rename song select v2 classes and namespaces

This aims to bring some conformity to naming to make it easier to
understand component structure for new components.

Renames are pulled out of the song select v2 changes and are more
relevant there due to many new classes being added.

- `V2` suffix is dropped, with v2 components being moved to a relevant V2 namespace.
- Related classes have a prefix of the area they are used.
- Experimenting with using partial/nested classes in the song select v2 implementation.
  Not committing to this yet but want to see how it plays out.
- Moved base carousel components to a generic namespace to avoid confusion with actual beatmap carousel implementation.

Dean Herbert · 2025-04-16 18:34:53 +09:00

0aff50fbf5

Merge pull request #32815 from peppy/global-shear

Change global shear definition to be a `Vector2`

Dean Herbert · 2025-04-16 18:34:39 +09:00

572bc6d8b4

Merge pull request #32816 from bdach/oops

Fix local leaderboards not showing when starting game offline

Bartłomiej Dach · 2025-04-16 11:17:57 +02:00

054f8a04b7

Merge pull request #32814 from peppy/beatmap-store-thread-safety

Fix thread safety when calling `BeatmapStore.GetBeatmapSets`

Bartłomiej Dach · 2025-04-16 11:17:02 +02:00

f8af848764

Change global shear definition to be a Vector2

Saves having this defined in 20+ places. If we ever make any changes to
shear, it's 100% going to need to be applied to every usage (there will
never be a case of multiple different shears in the game).

Also fixes a mismatching definition in `ShearedNub`.

Dean Herbert · 2025-04-16 18:01:08 +09:00

7a8e96f322

Fix local leaderboards not showing when starting game offline

Broke in https://github.com/ppy/osu/pull/32494. Oops.

Bartłomiej Dach · 2025-04-16 10:27:33 +02:00

cf2f6d7233

Add failing test

Bartłomiej Dach · 2025-04-16 10:27:05 +02:00

64b9d4642a

Merge pull request #32494 from bdach/yet-another-leaderboard-rewrite-attempt

Extract leaderboard fetch logic from song select beatmap leaderboard drawable

Dean Herbert · 2025-04-16 16:06:07 +09:00

57a81658f8

Fix thread safety when calling BeatmapStore.GetBeatmapSets

While usually we'd handle this locally by moving bind operations to
`LoadComponent`, this component was explicitly made to be used in
asynchronous scenarios (to allow cases like song select to coexist with
realm without adding huge compliexities to the classes locally).

So I think it makes sense to hide this as an implementation detail. The
locked segments should all be quite fast to run so I do not see a
performance issue with lock contention here.

Dean Herbert · 2025-04-16 15:53:20 +09:00

e8af0dabea

Fix code quality once more

Bartłomiej Dach · 2025-04-16 08:35:35 +02:00

8273583fd0

Add test cases covering correct legacy replay playback with respect to hitwindow treatment

This continues on https://github.com/ppy/osu/pull/32770 via adding test
cases which cover treatment of hit windows in stable in osu!, taiko, and
mania. The test cases are exportable to beatmap `.osu` files and replay
`.osr` files for stable crosscheck by setting `ExportLocation` on the
test scene classes to a non-null path.

For the most part, osu! and taiko ground truth matches previous findings
- hit windows in those rulesets are floored to the nearest integer.
The real "star" of this diff is mania, because:

- The hit windows in mania depend on:
  - overall difficulty (as expected)
  - whether Score V2 is active
  - if Score V2 is not active, the hit windows also depend on whether
    the map was converted from another ruleset or not

- Regardless of all aforementioned factors, mania hitwindows are *not
  symmetrical*. Due to what *appears* to be a straight-up bug, it is
  *not possible to achieve a MEH / 50 hit result when hitting late*.
  There is specific code that coerces late hits beyond 100 hit window
  range to full misses:

     https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameplayElements/HitObjectManagerMania.cs#L737-L751

Note that despite the fact that I'm PRing these test cases, none of this
is a promise that all of stable behaviours will be returning unchanged
when I PR something to actually do something about this and the other
issue of replay instability. This is just coverage, to be used for
awareness of what's still broken. The extent of how much stable is going
to be humored here going forward will be subject to negotiation.

Bartłomiej Dach · 2025-04-15 13:22:06 +02:00

82b2a92894

Merge pull request #32772 from frenzibyte/beatmap-statistic-bars

Introduce numeric data in beatmap object count statistics

Bartłomiej Dach · 2025-04-14 13:32:31 +02:00

9e112bc16b

Add extra comments regarding notation

Bartłomiej Dach · 2025-04-14 13:13:21 +02:00

9cfba9008f

Don't include spinner types in note sums

Dean Herbert · 2025-04-14 19:21:36 +09:00

3d47a2b5b2

Merge pull request #32802 from smoogipoo/fix-doubled-condition

Combine "spinnable time" conditions

Bartłomiej Dach · 2025-04-14 12:15:36 +02:00

434a0392dd

Rename new property to better explain visual-only usage

Dean Herbert · 2025-04-14 18:38:04 +09:00

f05a50f4e1

Combine "spinnable time" conditions

Dan Balasescu · 2025-04-14 17:45:15 +09:00

80d9f742da

Merge pull request #32799 from peppy/middle-click-closes-channels

Add support for closing chat channels with middle click

Bartłomiej Dach · 2025-04-14 09:17:52 +02:00

b214539929

Merge pull request #32759 from peppy/status-pill-improvements

Allow showing "unknown" state on status pill

Bartłomiej Dach · 2025-04-14 09:03:12 +02:00

cd3aa18213

Add support for closing chat channels with middle click

Closes https://github.com/ppy/osu/issues/32797.

Dean Herbert · 2025-04-14 15:30:40 +09:00

f4cb3a7fb3

Merge pull request #32796 from Rudicito/fix-spin-per-minute-showing-early

Fix "spins per minute" shows up early (fix #31173)

Dan Balasescu · 2025-04-14 15:16:26 +09:00

5f5be132c1

Fix "spins per minute" shows up early #31173

Make isSpinnableTime public in SpinnerRotationTracker and use it to set Tracking in OsuModSpunOut.

Tracking was previously set to true, causing the "spins per minute" to appear immediately when the spinner appeared.

Rudi Herouard · 2025-04-13 23:35:44 +02:00

7cdbc2c20a

Merge pull request #32771 from frenzibyte/improve-group-card-1

Improve group panel design

Dean Herbert · 2025-04-13 16:03:16 +09:00

84ab5a5fa6

Remove unnecessary assert

Dean Herbert · 2025-04-13 15:34:59 +09:00

f79f427547

Remove localisation support for now

The plural handling doesn't cover other languages so it's a bit
pointless to localise in this manner.

Dean Herbert · 2025-04-13 15:31:40 +09:00

76b94884b8

Improve group panel test scene