72490 Commits

This Branch

This Branch

All Branches

• Fix test
  Dan Balasescu · 2025-03-27 17:49:21 +09:00
  2cfb06bcde
• Fix several issues with multiplayer & playlists room join error logging

  This is in response to
  https://osu.ppy.sh/community/forums/topics/2058708?n=5, wherein the user
  is having a problem with joining multiplayer, but I have basically no
  diagnosing capabilities, because the logs are all
  
      2025-03-26 18:57:57 [error]: Failed to join multiplayer room:
      2025-03-26 18:58:40 [error]: Failed to join multiplayer room:
      2025-03-26 18:58:41 [error]: Failed to join multiplayer room:
      2025-03-26 18:58:41 [error]: Failed to join multiplayer room:
  
  which appears to originate from
  
  https://github.com/ppy/osu/blob/c82eaafe98d96b9f49a4a7f168ef5c484e67d76f/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerLoungeSubScreen.cs#L91
  
  Now, as far as I can tell, there are two possibilities here:
  
  1. The exception's `Message` is null or empty. That's not exactly great
     or typical, but sure, this could possibly happen - in which case the
     error logging is silently eating whatever little relevant detail
     there is left to use.
  
  2. The exception is *actually* `null` itself, and we're in the X Files.
  
  This PR is intending to defend against (1).
  
  In examining the logging further, I also spotted the following issues:
  
  - In the single path that specifies a custom failure handler (which is
    `DrawableLoungeRoom` which handles joining a passworded room), the
    custom failure handler being present means that the error would be
    presented to the user, but it would not be logged. At all.
  
  - In playlists, if the exception for whatever reason had an empty
    message, an empty notification would get posted. And in general to me
    it feels a bit dodgy to be directly presenting exception notifications
    to users without any preamble, hence the added "Failed to open
    playlist" prefix.

  Bartłomiej Dach · 2025-03-27 08:52:33 +01:00
  1c4ecba950
• Merge pull request #32571 from smoogipoo/refactor-mp-availability

  Refactor online play beatmap availability, add multiplayer-specific implementation

  Bartłomiej Dach · 2025-03-26 13:52:07 +01:00
  c82eaafe98
• Merge pull request #32579 from bdach/allow-tagging-if-local-score-present

  Allow tagging already played beatmaps without playing another time

  Dean Herbert · 2025-03-26 19:32:53 +09:00
  e09e38be58
• Remove unused local
  Dean Herbert · 2025-03-26 19:10:14 +09:00
  90bc2318e1
• Merge pull request #32530 from frenzibyte/song-select-v2-aqumarine-mod-select

  Change mod select colour scheme to aquamarine in new song select

  Dean Herbert · 2025-03-26 14:48:13 +09:00
  f0b38a45d8
• Merge pull request #32567 from peppy/fix-christmas-music-oh-no

  Fix christmas menu track potentially playing out of season

  Dan Balasescu · 2025-03-26 14:41:31 +09:00
  a14623a4ab
• Merge pull request #32585 from frenzibyte/teams-external-page

  Open teams page externally when clicking team flags

  Dan Balasescu · 2025-03-26 14:12:02 +09:00
  84174eb4da
• Open teams page externally when clicking team flags
  Salman Alshamrani · 2025-03-25 21:47:22 -04:00
  28f3d9cec9
• Inline method calls to make multiple enumerations explicit
  Dean Herbert · 2025-03-25 22:25:56 +09:00
  f36bc51520
• Merge pull request #32578 from bdach/fix-fountains-loop-alt

  Fix menu star fountains getting stuck looping sounds when leaving menu

  Dean Herbert · 2025-03-25 22:21:36 +09:00
  7de67434a0
• Allow tagging already played beatmaps without playing another time

  Addresses
  https://github.com/ppy/osu/discussions/32568#discussioncomment-12610577.
  
  No changes in criteria (yet?), just allowing locally imported plays to
  count the same way as full beatmap completion does.
  
  The test scene is a bit rough / semi-manual but dealing with score
  imports is a bit of a pain in general. The way to semi-manually test
  with the test scene is to import a subset of scores, then recreate the
  statistics panel, and observe behaviour. I'm not sure it's worth it to
  be putting subscriptions in there, so the full recreation of the panel
  is necessary.

  Bartłomiej Dach · 2025-03-25 14:16:26 +01:00
  40d20f4e10
• Fix menu star fountains getting stuck looping sounds when leaving menu

  - Alternative to / closes https://github.com/ppy/osu/pull/32565
  - Closes https://github.com/ppy/osu/issues/32516

  Bartłomiej Dach · 2025-03-25 13:19:17 +01:00
  d908464f99
• Reduce spacing in new beatmap carousel
  Dean Herbert · 2025-03-25 17:21:35 +09:00
  31487545d0
• Remove unnecessary conditionals
  Dean Herbert · 2025-03-25 17:13:13 +09:00
  68cdb60bee
• Merge pull request #32540 from frenzibyte/mod-rich-tooltip

  Display mod tooltips in rich form

  Dean Herbert · 2025-03-25 16:44:43 +09:00
  6dbd6a7e7b
• Merge pull request #32566 from peppy/fix-double-placeholders

  Fix overlapping placeholders in beatmap info leaderboard

  Dan Balasescu · 2025-03-25 16:43:37 +09:00
  6b9313a93f
• Remove pointless left-over code
  Dean Herbert · 2025-03-25 16:43:22 +09:00
  1bb85bab89
• Make test headless
  Dan Balasescu · 2025-03-25 16:19:46 +09:00
  0392af3d4b
• Remove unnecessary ruleset store
  Dan Balasescu · 2025-03-25 16:08:13 +09:00
  b83a69b029
• Partial classes
  Dan Balasescu · 2025-03-25 16:05:33 +09:00
  5793ad4a63
• Add tests for multiplayer implementation
  Dan Balasescu · 2025-03-25 16:03:56 +09:00
  a1894c9193
• Adjust tests to add tracker to hierarchy
  Dan Balasescu · 2025-03-25 15:41:03 +09:00
  bc2b7aae1c
• Split tracker into per-system implementations
  Dan Balasescu · 2025-03-25 14:56:12 +09:00
  53ece9396a
• Fix christmas menu track potentially playing out of season

  Closes https://github.com/ppy/osu/issues/32502.

  Dean Herbert · 2025-03-25 14:48:51 +09:00
  0d8f328fe6
• Fix overlapping placeholders in beatmap info leaderboard

  Closes https://github.com/ppy/osu/issues/32508.

  Dean Herbert · 2025-03-25 14:27:24 +09:00
  9630002a68
• Refactor tracker to be a bit more stateless

  Removes storage of `selectedBeatmap` that was referenced through
  multiple class-level methods.
  
  To expound a bit, this structure felt better (or otherwise passing
  `APIBeatmap` through methods) alongside removal of the `#nullable
  disable`, otherwise each method would check `selectedBeatmap != null`.

  Dan Balasescu · 2025-03-25 14:23:05 +09:00
  72b56146ee
• Merge pull request #32428 from evilldev/show-full-rank

  Show full rank in extended results screen

  Dean Herbert · 2025-03-25 01:18:19 +09:00
  1b0c60cff5
• Merge pull request #32551 from smoogipoo/basic-freestyle-validation

  Validate freestyle selection post-selection

  Bartłomiej Dach · 2025-03-24 14:08:20 +01:00
  d0cdacea79
• Merge pull request #32550 from peppy/taiko-hit-animations

  Fix taiko legacy skins playing scale animations even when skins contain animations

  Bartłomiej Dach · 2025-03-24 13:41:09 +01:00
  3e297bdb9d
• Merge branch 'master' into show-full-rank
  Bartłomiej Dach · 2025-03-24 12:56:20 +01:00
  c631e7a1c5
• Fix inconsistent formatting
  Bartłomiej Dach · 2025-03-24 12:30:03 +01:00
  334b1e85bc
• Add extra test coverage
  Bartłomiej Dach · 2025-03-24 12:28:46 +01:00
  f6dd2e4ac2
• Fix code quality
  Bartłomiej Dach · 2025-03-24 12:28:40 +01:00
  130d0c8b70
• Merge pull request #32460 from smoogipoo/refactor-match-footer

  Refactor multiplayer match footer

  Bartłomiej Dach · 2025-03-24 12:14:57 +01:00
  fdcf40d4a6
• Validate freestyle selection post-selection
  Dan Balasescu · 2025-03-24 17:38:43 +09:00
  303d0c56c3
• Merge pull request #32532 from frenzibyte/sheared-dropdown

  Implement sheared dropdowns

  Dean Herbert · 2025-03-24 16:34:42 +09:00
  5b191dad8f
• Fix taiko legacy skins playing scale animations even when skins contain animations

  Closes https://github.com/ppy/osu/issues/32477.
  
  Can be tested using
  https://drive.google.com/drive/folders/1HUCsTL_iqCGPCyruSSfdSoxL19EQuy_a.

  Dean Herbert · 2025-03-24 16:14:32 +09:00
  bb998ad687
• Apply shearing to dropdown menu as well

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Alshamrani · 2025-03-24 02:18:11 -04:00
  4cd631f9f9
• Merge pull request #32495 from bdach/some-more-activities

  Adjust user activity updates

  Dan Balasescu · 2025-03-24 12:53:12 +09:00
  6d7e94f58e
• Merge pull request #32546 from frenzibyte/fix-external-resource-lookup

  Fix images embedded in comments not displaying

  Dan Balasescu · 2025-03-24 12:36:16 +09:00
  89de22c5af
• Apply better fix for background bleeding

  Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>

  Salman Alshamrani · 2025-03-23 22:27:51 -04:00
  b2c9a572fa
• Fix images embedded in comments not displaying
  Salman Alshamrani · 2025-03-23 21:38:36 -04:00
  655c799c58
• Add failing test case
  Salman Alshamrani · 2025-03-23 21:38:36 -04:00
  b3d572029f
• Add extra margin below description text
  Salman Alshamrani · 2025-03-23 13:46:19 -04:00
  54eb0b33b0
• Update mod preset tooltip design accordingly
  Salman Alshamrani · 2025-03-23 13:43:38 -04:00
  623e705704
• Introduce rich mod tooltip
  Salman Alshamrani · 2025-03-23 13:43:26 -04:00
  9b55325526
• Change SettingDescription to differentiate between settings and values
  Salman Alshamrani · 2025-03-23 13:43:26 -04:00
  6e635f124a
• Adjust user activity updates

  - Changed copy of the multiplayer spectator activity to be
    ruleset-agnostic, thus I guess closing
    https://github.com/ppy/osu/issues/32307 maybe? There is still the
    ruleset icon in discord RPC but that one is taken from the game-global
    ruleset so it's a bit more involved to fix.
  
  - Added new activities for daily challenge screens, therefore partially
    addressing https://github.com/ppy/osu/discussions/29200. I didn't add
    skin editor because (a) it's not easy to make work because skin editor
    isn't a screen and (b) I'm not sure we want that to begin with? Kind
    of a weird one.
  
  I've tested backwards compatibility; old server will raise exceptions
  that then will be logged as unobserved by the clients when receiving the
  new statuses, and an old client, when given one of the new statuses by a
  new server, seems to completely ignore it. Seems pretty acceptable to
  me.

  Bartłomiej Dach · 2025-03-23 11:50:59 +01:00
  429819e68b
• Merge pull request #32531 from frenzibyte/footer-v2-fix-mod-button

  Fix mod select footer overlapping with mod unranked indicator

  Dean Herbert · 2025-03-23 17:48:56 +09:00
  589c8aba4b