41836 Commits

This Branch

This Branch

All Branches

• Merge pull request #13790 from PercyDan54/remove-redundant-arg

  Remove redundant arguments

  Dean Herbert · 2021-07-06 14:00:59 +09:00
  2cd1bde2bf
• Bump redundant argument default value inspection severity to warning
  Bartłomiej Dach · 2021-07-05 21:02:40 +02:00
  af02a1efcb
• Remove unused constant
  Bartłomiej Dach · 2021-07-05 20:35:14 +02:00
  686dd2b5ce
• Revert & disable case with two contradicting inspections

  Leaving the `false` default value without the suppression triggers
  `RedundantArgumentDefaultValue`, while removing it triggers
  `BaseMethodCallWithDefaultParameter`.
  
  Disable the former, because a single redundant parameter is less bad
  than silent breakage if the default value of `propagateChildren` in the
  base method ever changes.

  Bartłomiej Dach · 2021-07-05 20:21:44 +02:00
  8e102280b7
• Remove redundant arguments
  PercyDan54 · 2021-07-05 23:52:39 +08:00
  e1c646b9b2
• Merge pull request #13789 from PercyDan54/disable-inspections

  Disable IDE0057 and IDE0042 inspection

  Dean Herbert · 2021-07-06 00:41:01 +09:00
  c7f03dd9f7
• Suppress IDE0042
  PercyDan54 · 2021-07-05 23:36:15 +08:00
  a4545051f2
• Suppress IDE0057
  PercyDan54 · 2021-07-05 23:36:10 +08:00
  fdfdfeecab
• Merge pull request #13747 from ekrctb/catcher-flip

  Don't flip catcher plate contents when catcher changes direction

  Dean Herbert · 2021-07-06 00:02:23 +09:00
  01961fe4f9
• Fix default skin catcher not flipping catcher plate

  When legacy beatmap skin is present but catcher is not provided, it was using the legacy setting (always false).

  ekrctb · 2021-07-05 20:05:08 +09:00
  d247b8042e
• Merge pull request #13784 from peppy/fix-incorrect-filename

  Fix remaining incorrect filename

  Dean Herbert · 2021-07-05 20:02:56 +09:00
  991db4611e
• Merge pull request #13780 from peppy/disable-foreign-keys

  Disable foreign key enforcing at an sqlite level

  Dan Balasescu · 2021-07-05 19:08:10 +09:00
  28faa8c330
• Merge pull request #13781 from peppy/fix-multi-spec-test-failures

  Fix master clock becoming incorrectly paused when all spectator players are too far ahead

  Dan Balasescu · 2021-07-05 19:01:51 +09:00
  2398859b66
• Fix remaining incorrect filename
  Dean Herbert · 2021-07-05 18:56:59 +09:00
  cd2916f778
• Merge pull request #13782 from peppy/fix-incorrect-filename

  Fix incorrect filename

  Dan Balasescu · 2021-07-05 18:53:41 +09:00
  bf4be2dfc7
• Fix incorrect filename
  Dean Herbert · 2021-07-05 18:20:04 +09:00
  7645da7d37
• Fix master clock becoming incorrectly paused when all spectator players are too far ahead
  Dean Herbert · 2021-07-05 17:45:08 +09:00
  229bba14e6
• Disable foreign key enforcing at an sqlite level
  Dean Herbert · 2021-07-05 15:41:48 +09:00
  1e4beddd2d
• Merge pull request #13778 from Henry-YSLin/fix-unimplemented-mod-test

  Use a mock ruleset and mod to test unimplemented mods in mod select overlay

  Dean Herbert · 2021-07-05 13:54:14 +09:00
  b7180f16c5
• Merge pull request #13774 from LumpBloom7/fix-incorrect-first-window

  Fix nested HitWindows not being considered if parent HitWindow is empty

  Dan Balasescu · 2021-07-05 13:54:00 +09:00
  8f82ceefe8
• Merge pull request #13756 from PercyDan54/playlist-empty-romanised

  Fix playlist item displays empty string if no unicode title is present

  Dan Balasescu · 2021-07-05 13:53:50 +09:00
  6b76c54aee
• Merge pull request #13767 from peppy/fix-realm-refresh-race

  Fix thread safety of realm `Refresh` operation

  Dan Balasescu · 2021-07-05 13:53:29 +09:00
  b82afaddc1
• Remove an unused local variable
  Henry Lin · 2021-07-05 09:52:13 +08:00
  3c37140426
• Change the test for unimplemented mod to use a mock ruleset and mod
  Henry Lin · 2021-07-05 09:51:24 +08:00
  bfb603cfeb
• Move previousContext assign within lock to make things look safer

  Not an actual requirement, but no harm.

  Dean Herbert · 2021-07-05 10:49:56 +09:00
  f510ef9153
• Merge pull request #13757 from peppy/fix-import-optimisation

  Fix incorrect `base` call causing import optimisation to not work

  Dan Balasescu · 2021-07-05 10:26:52 +09:00
  b6542a835b
• Merge branch 'master' into playlist-empty-romanised
  Dan Balasescu · 2021-07-05 10:20:33 +09:00
  5f10edee39
• Fix inspection (create a new ruleset every time)
  smoogipoo · 2021-07-05 10:13:01 +09:00
  cc877f88e2
• Avoid using single letter variable names
  Derrick Timmermans · 2021-07-04 23:24:17 +02:00
  216e52d6d0
• Apply changes to tests
  Derrick Timmermans · 2021-07-04 23:23:24 +02:00
  1facdcf483
• Add basic tests
  Derrick Timmermans · 2021-07-04 22:51:35 +02:00
  6d2ffe3a94
• Fix typo causing nested windows to be ignored
  Derrick Timmermans · 2021-07-04 21:50:58 +02:00
  32b068fbdc
• Merge pull request #13746 from ekrctb/move-caught-object-vertical-offset

  Move caught object stack vertical offset logic

  Bartłomiej Dach · 2021-07-04 18:10:34 +02:00
  0fb16cb55f
• Merge branch 'master' into move-caught-object-vertical-offset
  Bartłomiej Dach · 2021-07-04 17:26:24 +02:00
  ff56a554f3
• Merge pull request #13765 from peppy/fix-initial-volume-display-when-zero

  Fix volume metre not correctly showing volume when initially zero

  Bartłomiej Dach · 2021-07-04 16:55:24 +02:00
  f3cd0be230
• Add more test case
  PercyDan54 · 2021-07-04 22:34:31 +08:00
  356f5dceef
• Merge branch 'master' into fix-initial-volume-display-when-zero
  Bartłomiej Dach · 2021-07-04 16:16:01 +02:00
  5e148b273e
• Merge pull request #13766 from peppy/fix-zero-hit-score-submit

  Don't attempt to submit score when nothing has been hit

  Bartłomiej Dach · 2021-07-04 16:10:55 +02:00
  a7de3dd81c
• Add test
  PercyDan54 · 2021-07-04 22:09:23 +08:00
  44d540eb53
• Merge branch 'master' into fix-zero-hit-score-submit
  Bartłomiej Dach · 2021-07-04 15:31:38 +02:00
  c143a50b73
• Merge pull request #13762 from peppy/remove-lazer-references

  Remove some mentions of "lazer"

  Bartłomiej Dach · 2021-07-04 15:01:56 +02:00
  d5fa972215
• Ensure tests with no token have at least one hit

  Because submission can be prevented by both not having been issued a
  correct submission token, and by not actually registering any hits in
  gameplay, ensure that tests that don't receive a token register at least
  one hit, to avoid potentially having test cases that test the "no token"
  flow pass erroneously because they never had any hits in the first
  place.

  Bartłomiej Dach · 2021-07-04 14:34:52 +02:00
  19f02dc3d9
• Mention GetForWrite() as another alternative to Context accesses
  Bartłomiej Dach · 2021-07-04 12:08:15 +02:00
  3291f15dcc
• Mention alternatives to Context when not on update thread in xmldoc
  Bartłomiej Dach · 2021-07-04 12:07:34 +02:00
  b89521314f
• Update tests in line with thread safety check
  Dean Herbert · 2021-07-04 17:59:39 +09:00
  3ec7dc3bb9
• Add test coverage of new scenarios
  Dean Herbert · 2021-07-04 17:27:02 +09:00
  2a74b1c539
• Check count as well (statistics can be populated with zero counts)
  Dean Herbert · 2021-07-04 16:41:09 +09:00
  7a710ceffe
• Fix thread safety of realm Refresh operation

  Due to the lack of locking, there was a chance the the update thread
  `context` was retrieved just before the `flushContexts` call, followed
  by `.Refresh()` being run while the blocking behaviour was invoked.
  
  This can be seen in test failures such as
  https://ci.appveyor.com/project/peppy/osu/builds/39859786/tests.
  
  As an aside, I tried multiple different methods to avoid `lock()` on the
  update thread but they felt flaky. The overhead of lock when there's no
  contention is reportedly around 30-50ns, so likely not of concern. We
  can address it at a later point if it becomes one.

  Dean Herbert · 2021-07-04 16:24:43 +09:00
  567e9f33a9
• Don't attempt to submit score when nothing has been hit
  Dean Herbert · 2021-07-04 15:16:18 +09:00
  ef82528309
• Fix volume metre not correctly showing volume when initially zero

  Closes https://github.com/ppy/osu/issues/13761.

  Dean Herbert · 2021-07-04 14:56:17 +09:00
  149a200f34