3362 Commits

• Refactor hit windows class structure to reduce rigidity

  This change pulls back a significant degree of overspecialisation and
  rigidity in the class structure of `HitWindows` to make subsequent
  changes to hit windows, whose purpose is to improve replay playback
  accuracy, possible to do cleanly.
  
  Notably:
  
  - `HitWindows` is full abstract now. In a few use cases, and as a
    reference for ruleset implementors, `DefaultHitWindows` is provided as
    a separate class instead.
  
    This fixes the weirdness wherein `HitWindows` always declared 6 fields
    for result types but some of them would never be set to a non-zero
    value or read.
  
  - `HitWindow.GetRanges()` is deleted because it is overspecialised and
    prevents being able to adjust hitwindows by ±0.5ms cleanly which will
    be required later.
  
    The fallout of this is that the assertion that used `GetRanges()` in
    the `HitWindows` ctor must use something else now, and the closest
    thing to it was `GetAllAvailableWindows()`, which didn't return
    the miss window - so I made it return the miss window and fixed the
    one consumer that didn't want it (bar hit error meter) to skip it.
  
  - Diff also contains some clean-up around `DifficultyRange` to unify
    handling of it.

  Bartłomiej Dach · 2025-06-25 08:40:12 +02:00
  8b542e5442
• Switch to IconPills, add storyboard icon
  StanR · 2025-06-22 13:45:07 +05:00
  25eb9914a4
• Merge pull request #33402 from bdach/preview-point-validity

  Fix track not looping if specified preview point exceeds duration of track

  Dan Balasescu · 2025-06-05 13:59:26 +09:00
  cf297ae743
• Ensure valid ruleset for gameplay
  Dean Herbert · 2025-06-04 15:45:40 +09:00
  c73ef15ebf
• Fix track not looping if specified preview point exceeds duration of track

  By falling back to the default of 40% of track duration in such cases.
  
  Also added a safety for the restart point exceeding acceptable bounds in
  case of a non-zero offset.
  
  Closes https://github.com/ppy/osu/issues/33308.

  Bartłomiej Dach · 2025-06-03 14:55:05 +02:00
  511c1d835b
• Fix BeatmapSetInfo missing GetHashCode implentation

  Causing dictionary lookups to fail when expecting equality
  implementation to work.

  Dean Herbert · 2025-05-26 19:32:31 +09:00
  f3782acddd
• Remove redundant public specfications in interfaces

  Rider EAP being noisy about this now (smoogi will be happy :D).

  Dean Herbert · 2025-05-26 17:14:41 +09:00
  cb0592d711
• Make BeatmapDifficultyCache's returned bindable non-nullable
  Dean Herbert · 2025-05-25 22:27:37 +09:00
  6500be3f2d
• Merge branch 'master' into carousel-grouping
  Dean Herbert · 2025-05-23 19:03:09 +09:00
  0a5fbb35c5
• Fix nominations count system not updated to newer API structure
  Salman Alshamrani · 2025-05-21 17:35:13 +03:00
  bd2851c386
• Merge pull request #33191 from peppy/fix-aggressive-diffcalc

  Reduce difficulty calculation churn overheads when using keyboard to iterate quickly at song select

  Dan Balasescu · 2025-05-21 20:48:14 +09:00
  662cbfcc48
• Resolve inspections
  Dan Balasescu · 2025-05-21 20:00:05 +09:00
  f967091aad
• Add property to allow disabling status pill animation
  Salman Alshamrani · 2025-05-21 00:37:08 +09:00
  c565b76b6e
• Add very basic transition for DifficultyIcon colour changes
  Dean Herbert · 2025-05-20 22:12:03 +09:00
  d9c376067d
• Add animation to star rating display in new carousel

  Also matches the animation speed of `StarRatingDisplay` with
  `StarCounter` as they are regularly displayed together.

  Dean Herbert · 2025-05-19 16:30:58 +09:00
  eb29c45513
• Start with known star rating for no-mod-no-convert rather than zero

  This makes displays look better, even if it's incorrect momentarily.

  Dean Herbert · 2025-05-19 16:18:54 +09:00
  01edee123f
• Add debounce to difficulty calculation operations in churn scenarios
  Dean Herbert · 2025-05-19 16:16:33 +09:00
  192a1642d4
• Add grouping support for most modes
  Salman Alshamrani · 2025-05-18 01:28:56 +03:00
  82923e6769
• Improve logging around import-as-update flow

  - It was logging success before actually succeeding.
  - It appears in practice that this code can somehow actually nullref.
    Unfortunately logs provided in that instance were not enough to
    pinpoint what (because of lack of line numbers). I'm hoping that by
    logging as error, and therefore to sentry, we can actually retrieve
    this information so that there's no need to work blind.

  Bartłomiej Dach · 2025-05-07 12:53:40 +02:00
  588c171978
• Improve star rating colour animations to match
  Dean Herbert · 2025-04-23 17:04:53 +09:00
  f6d7e29396
• Define constant for difficulty colour cutoff
  Dean Herbert · 2025-04-23 16:57:41 +09:00
  3f719125e6
• Update song select panel metrics in line with standard specifications and apply minor adjustments
  Salman Alshamrani · 2025-04-17 08:21:32 -04:00
  9e2a05a1fb
• Add animated fade when online status pill has an unknown status
  Dean Herbert · 2025-04-16 19:41:50 +09:00
  07d0c7443c
• Merge pull request #32772 from frenzibyte/beatmap-statistic-bars

  Introduce numeric data in beatmap object count statistics

  Bartłomiej Dach · 2025-04-14 13:32:31 +02:00
  9e112bc16b
• Rename new property to better explain visual-only usage
  Dean Herbert · 2025-04-14 18:38:04 +09:00
  f05a50f4e1
• Introduce numeric value in beatmap hit count statistics
  Salman Alshamrani · 2025-04-12 00:14:53 +09:00
  85556e0c3e
• Avoid performing colour fades when pill is not visible in the first place
  Dean Herbert · 2025-04-11 21:19:26 +09:00
  4b9873f03e
• Fix some incorrect/lacking comments
  Dean Herbert · 2025-04-11 21:14:56 +09:00
  c4cfd3a148
• Allow displaying "unknown" status in status pill
  Dean Herbert · 2025-04-10 23:42:29 +09:00
  57033fc180
• Fix status pill animating from zero height
  Dean Herbert · 2025-04-10 20:11:04 +09:00
  69035ef48f
• Fix code quality
  Bartłomiej Dach · 2025-04-10 07:47:31 +02:00
  fb326c6afd
• Remove manual handling of autosize now that we are using fixed width display
  Dean Herbert · 2025-04-10 01:46:44 +09:00
  962edbdf78
• Fix StarRatingDisplay not using fixed width text
  Dean Herbert · 2025-04-09 19:38:58 +09:00
  0c7c791fb5
• Include beatmap details in logs when load fails

  See
  https://github.com/ppy/osu/discussions/32682#discussioncomment-12760059
  for ambiguous logs.

  Dean Herbert · 2025-04-08 15:33:43 +09:00
  d31ffd9014
• Define constant for maximum mania key count
  Bartłomiej Dach · 2025-04-02 09:59:44 +02:00
  36539f1947
• Merge pull request #32596 from bdach/fix-bogus-daily-challenge-lookup

  Fix daily challenge not querying beatmap properly

  Dan Balasescu · 2025-03-27 21:25:47 +09:00
  b414ed0e42
• Use alternative method of fixing issue of improper beatmap query in daily challenge (and expand to other online play modes)
  Bartłomiej Dach · 2025-03-27 09:33:35 +01:00
  f73601535d
• Remove loading spinner and fade out icon instead
  Dean Herbert · 2025-03-26 19:33:20 +09:00
  2b471919e9
• Improve input handling in beatmap card buttons

  This is in response to feedback in
  https://osu.ppy.sh/community/forums/topics/2056547?n=1.
  
  Upon examining the button further, there was indeed some rather weird...
  almost hysteresis in how the button behaved with respect to the area on
  the screen that activated it. Because of the following scourge of a
  method that continues to haunt us to this day:
  
  https://github.com/ppy/osu/blob/31487545d0d17c4337d4b4cc5d4afb3ba1dae838/osu.Game/Graphics/Containers/OsuClickableContainer.cs#L24-L25
  
  the button would effectively only be activated by 80% of its drawable
  area when it was not hovered, because of the scale applied to the
  `content` container which `Container.Content` redirected to.
  
  This is resolved here by various rearrangements of paddings and sizes
  such that the clickable area of any of the buttons of the card is always
  the full top or bottom half of the button area.
  
  Also included are some cosmetic touch-ups which happened to be
  convenient like folding the loading spinner into the base
  `BeatmapCardIconButton`, adding loading support for the favourite
  button, using BDL more, and resolving some "virtual member call in
  constructor" inspections.

  Bartłomiej Dach · 2025-03-25 12:59:37 +01:00
  199bcd7fdb
• Avoid multiple enumerations of beatmaps
  Dean Herbert · 2025-03-20 01:50:16 +09:00
  149e160964
• Fix DifficultySpectrumDisplay churning drawables

  Was causing so much GC that song select (v2) was grinding to a halt.

  Dean Herbert · 2025-03-19 19:31:57 +09:00
  63fcde5538
• Remove unnecessary customisation settings in DifficultySpectrumDisplay
  Dean Herbert · 2025-03-19 19:31:57 +09:00
  cfb14fbca6
• Re-fetch status of any beatmaps stuck in qualified status

  Best we do this rather than leaving it up to users to fix their broken
  beatmaps.
  
  https://github.com/ppy/osu/discussions/32406
  https://github.com/ppy/osu/discussions/32431

  Dean Herbert · 2025-03-19 14:35:43 +09:00
  76f286a01b
• Fix tests
  Bartłomiej Dach · 2025-03-18 14:18:00 +01:00
  efe1416aa3
• Fix editor crashing if beatmap does not have a mode explicitly specified in the .osu

  Closes https://github.com/ppy/osu/issues/32440.
  
  Probably another "regression" from
  https://github.com/ppy/osu/pull/32315.
  
  Trying very hard not to type out any hyperbolic rants here.

  Bartłomiej Dach · 2025-03-18 12:05:36 +01:00
  87a8281b29
• Move BeatmapVersion from BeatmapInfo to IBeatmap

  Closes https://github.com/ppy/osu/issues/32420.
  
  The failure cause here is that in editor the beatmap version for the
  beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
  probably a regression from https://github.com/ppy/osu/pull/32315, but
  like... can we universally agree that calling that change "a regression"
  in any capacity is dumb? Like what was that code *doing* playing dumb
  reference games and copying stuff into an arbitrary instance that could
  get or not get used later on? And now you have a 50/50 chance of
  accessing the *correct* model's field, depending on whether you go via
  `BeatmapInfo` or `Beatmap.BeatmapInfo`?
  
  Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
  since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
  and materialised" beatmap, fixes this issue.
  
  I probably should have done this as part of
  https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
  for the better too because this change has rather large chances of
  breaking stuff so maybe better to examine it in isolation (via diffcalc
  runs or whatever).
  
  For added humour points, you'd say that the field on `BeatmapInfo` was
  not `[Ignore]`d, so this is a realm schema change, right? No. As far as
  I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
  a listed column` on `Beatmap` models.
  
  I'm also not gonna get into the fact that I think `EditorBeatmap` doing
  dumb games with juggling two `BeatmapInfo` references since
  https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
  have the mental capacity to hotfix this by going down that train of
  thought.

  Bartłomiej Dach · 2025-03-17 15:04:48 +01:00
  91f3be5fea
• Use reference check rather than Guid comparison
  Dean Herbert · 2025-03-12 17:18:30 +09:00
  16afd5f117
• Fix default beatmap not being correctly set after aborting new beatmap creation

  Closes https://github.com/ppy/osu/issues/32337.

  Dean Herbert · 2025-03-12 14:01:11 +09:00
  65cdcb4696
• Merge pull request #32221 from bdach/user-tags-visual

  Add visual component for assigning user tags to beatmaps

  Dean Herbert · 2025-03-12 11:37:47 +09:00
  ad04b5b1af
• Merge pull request #32329 from peppy/local-cache-nuke

  Ensure qualified beatmaps are never looked up on stale cache source

  Bartłomiej Dach · 2025-03-11 11:16:13 +01:00
  a2966d93cc