h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-06-02 19:00:10 +08:00
Code Issues Releases Wiki Activity

Avoid multiple enumerations of beatmaps

Browse Source
This commit is contained in:
Dean Herbert
2025-03-20 01:50:16 +09:00
Unverified
parent 63fcde5538
commit 149e160964
1 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Beatmaps/Drawables/DifficultySpectrumDisplay.cs
+7 -10
View File
@@ -1,7 +1,6 @@
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.
using System.Collections.Generic;
using System.Linq;
using osu.Framework.Allocation;
using osu.Framework.Extensions.LocalisationExtensions;
@@ -84,7 +83,7 @@ namespace osu.Game.Beatmaps.Drawables
}
group.Alpha = 1;
group.Beatmaps = rulesetGrouping;
group.Beatmaps = rulesetGrouping.ToArray();
group.Collapsed = collapsed;
}
}
@@ -93,14 +92,13 @@ namespace osu.Game.Beatmaps.Drawables
{
public readonly int RulesetId;
private IEnumerable<IBeatmapInfo> beatmaps = [];
private IBeatmapInfo[] beatmaps = [];
public IEnumerable<IBeatmapInfo> Beatmaps
public IBeatmapInfo[] Beatmaps
{
get => beatmaps;
set
{
beatmaps = value;
beatmaps = value.OrderBy(bi => bi.StarRating).ToArray();
updateDisplay();
}
}
@@ -159,23 +157,22 @@ namespace osu.Game.Beatmaps.Drawables
private void updateDisplay()
{
countText.Alpha = collapsed ? 1 : 0;
countText.Text = beatmaps.Count().ToLocalisableString(@"N0");
countText.Text = beatmaps.Length.ToLocalisableString(@"N0");
var orderedBeatmaps = beatmaps.OrderBy(bi => bi.StarRating).ToArray();
var dots = this.OfType<DifficultyDot>().ToArray();
for (int i = 0; i < max_difficulties_before_collapsing; i++)
{
var dot = dots[i];
if (collapsed || i >= orderedBeatmaps.Length)
if (collapsed || i >= beatmaps.Length)
{
dot.Alpha = 0;
continue;
}
dot.Alpha = 1;
dot.StarDifficulty = orderedBeatmaps[i].StarRating;
dot.StarDifficulty = beatmaps[i].StarRating;
}
}
}