Bartłomiej Dach
2c0a5b7ef5
Fix missing tiny droplet not triggering fail with perfect on
...
Stable does this:
46cd3a10af/osu
!/GameplayElements/HitObjectManagerFruits.cs#L98-L102
I'd rather not say what I think about it doing that, since it's likely
to be unpublishable, but to approximate that, just make it so that
only the "default fail condition" is beholden to the weird ebbs
and flows of what the ruleset wants. This appears to fix the problem
case and I'm hoping it doesn't break something else but I'm like 50/50
on it happening anyway at this point. Just gotta add tests add nauseam.
2024-02-14 14:21:48 +01:00
Bartłomiej Dach
f53bce8ff7
Fix catch health processor allowing fail on tiny droplet
...
Closes https://github.com/ppy/osu/issues/27159 .
In today's episode of "just stable things"...
2024-02-14 09:02:33 +01:00
Bartłomiej Dach
3d8d0f8430
Update test expectations for catch
2024-02-14 08:37:20 +01:00
Bartłomiej Dach
16d893d40c
Fix draining processor failing gameplay on bonus misses and ignore hits
2024-02-13 13:06:19 +01:00
Bartłomiej Dach
d07ea8f5b1
Add failing test coverage for mania
2024-02-13 13:06:19 +01:00
Bartłomiej Dach
441a7b3c2f
Add precautionary taiko test coverage
2024-02-13 13:06:19 +01:00
Bartłomiej Dach
86801aa51d
Add failing test coverage for osu!
2024-02-13 13:06:04 +01:00
Bartłomiej Dach
1eb04c5190
Add failing test coverage for catch
2024-02-13 11:47:38 +01:00
Dan Balasescu
833997bf1d
Merge pull request #27143 from bdach/more-stringent-metadata-checks
...
Use more stringent checks when applying online metadata
2024-02-13 17:10:52 +09:00
Dan Balasescu
60e0eea9bc
Merge pull request #27112 from Stoppedpuma/alias-author-creator
...
Add aliases "author" and "mapper" for creator results
2024-02-13 08:35:49 +09:00
Dan Balasescu
d3e005d4a2
Merge pull request #27116 from tsunyoku/only-compute-flashlight-when-necessary
...
Only compute flashlight in osu! difficulty calculations when required
2024-02-13 08:25:59 +09:00
Bartłomiej Dach
5d81d83fb2
Merge branch 'master' into alias-author-creator
2024-02-12 18:02:42 +01:00
Bartłomiej Dach
96711eb185
Add test coverage
2024-02-12 18:02:34 +01:00
Bartłomiej Dach
e5e0b0e385
Add test coverage for correct setting of beatmap set status
2024-02-12 12:08:51 +01:00
Bartłomiej Dach
138fea8c38
Only apply set-level metadata after all difficulties have been processed
2024-02-12 12:08:51 +01:00
Bartłomiej Dach
133e61a1b2
Add another test for even more failure
2024-02-12 12:08:51 +01:00
Bartłomiej Dach
87702b3312
Only check online matching when determining whether to save online metadata
...
After https://github.com/ppy/osu/pull/23362 I'm not sure the
`LocallyModified` check is doing anything useful. It was confusing me
really hard when trying to parse this logic, and it can misbehave (as
`None` will also pass the check).
2024-02-12 12:07:20 +01:00
Bartłomiej Dach
4f0ae4197a
Refuse to apply online metadata in the most dodgy scenarios
2024-02-12 11:43:41 +01:00
Bartłomiej Dach
834db989f7
Add more test coverage for more failure
2024-02-12 11:43:41 +01:00
Bartłomiej Dach
80b14f1aae
Add test coverage for beatmap confusion scenarios
2024-02-12 11:43:15 +01:00
Stoppedpuma
ca0819cf7a
Alias "mapper" as well
2024-02-11 20:28:16 +01:00
Dean Herbert
7bc571dd51
Merge pull request #27132 from EVAST9919/beatmap-panel-texture-alloc
...
Fix huge allocation overhead during beatmap texture creation in song-select screen
2024-02-12 01:43:31 +08:00
Andrei Zavatski
5e692345de
Don't convert pixel data to array
2024-02-11 17:44:54 +03:00
Dean Herbert
33d4e8f821
Merge pull request #23822 from bdach/refactor-metadata-lookup-sources
...
Refactor metadata lookup flows
2024-02-11 20:37:45 +08:00
Dean Herbert
1df38b54a1
Merge branch 'master' into refactor-metadata-lookup-sources
2024-02-11 20:10:41 +08:00
Dean Herbert
7dba21fdac
Move init method to bottom of file
2024-02-11 20:05:58 +08:00
Dan Balasescu
2ab318771e
Merge pull request #27117 from tsunyoku/remove-linq-from-difficulty-hit-object
...
Replace linq usage in `Previous` and `Next` on `DifficultyHitObject` with more direct computation
2024-02-11 18:13:58 +09:00
Dean Herbert
b0420f7ed9
Merge pull request #27115 from bdach/contributing-guidelines-do-not-release-ever
...
Add note to never run release config to contributing guidelines
2024-02-10 23:45:24 +08:00
tsunyoku
901b82384d
replace linq usage in Previous
and Next
with more direct computation
2024-02-10 15:42:55 +00:00
Bartłomiej Dach
bd04377643
Tell people to not run in release harder
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-02-10 16:42:19 +01:00
tsunyoku
c5f392c17d
only compute flashlight in osu! difficulty calculations when required
2024-02-10 15:25:03 +00:00
Bartłomiej Dach
4b847b68a2
Merge pull request #27056 from kongehund/deselect-slider-adds-control-point-bug
...
Fix deselecting slider adding control points
2024-02-10 16:01:27 +01:00
Bartłomiej Dach
d991873028
Add note to never run release config to contributing guidelines
...
See https://discord.com/channels/188630481301012481/188630652340404224/1205886296439136286
for the latest instance of this, but this really keeps happening. Maybe
someone will read this and stop themselves from making the same mistake.
One can dream.
2024-02-10 15:57:12 +01:00
Bartłomiej Dach
6954a185c4
Merge branch 'master' into deselect-slider-adds-control-point-bug
2024-02-10 15:35:03 +01:00
Bartłomiej Dach
6894f17b23
Add test coverage
2024-02-10 15:34:12 +01:00
Dean Herbert
32bfd875d9
Merge pull request #26930 from Susko3/suggest-update-only-if-available
...
Suggest to update only if the latest release is available for the current platform
2024-02-10 22:08:56 +08:00
Bartłomiej Dach
4a516cbccd
Merge pull request #27077 from peppy/log-fire-and-forget-better
...
Improve exception logging of unobserved exceptions via `FireAndForget`
2024-02-10 13:43:50 +01:00
Bartłomiej Dach
bd226859fb
Merge pull request #27106 from Joehuu/match-profile-icons
...
Fix profile current location and interests icons not matching web
2024-02-10 13:36:05 +01:00
Bartłomiej Dach
c3f0d3ad5c
Merge branch 'master' into match-profile-icons
2024-02-10 13:08:42 +01:00
Bartłomiej Dach
ae5f108f01
Add visual test coverage of user profile info section
2024-02-10 13:08:26 +01:00
Dean Herbert
90854b5961
Merge pull request #27113 from smoogipoo/room-score-metadata
...
Add additional gameplay metadata to room score request
2024-02-10 16:59:02 +08:00
Dan Balasescu
bfeb90c1b6
Add additional gameplay metadata to room score request
2024-02-10 17:20:17 +09:00
Stoppedpuma
7c04e8bfba
Alias author to creator
...
Allows "author" to show the results of "creator"
2024-02-10 07:48:24 +01:00
Dean Herbert
01501f3b82
Merge branch 'master' into refactor-metadata-lookup-sources
2024-02-10 14:43:51 +08:00
Joseph Madamba
ed2362b63d
Fix icon family and weight not transferring to text conversion
2024-02-09 14:31:38 -08:00
Joseph Madamba
666c57da50
Fix profile current location and interests icons not matching web
2024-02-09 14:31:37 -08:00
Dean Herbert
0ebea77392
Merge pull request #27095 from turbedi/net_8-order
...
Use new LINQ Order{Descending} instead of OrderBy{Descending} when possible
2024-02-09 11:15:37 +08:00
Berkan Diler
6adf0ac01e
Use new LINQ Order() instead of OrderBy() when possible
2024-02-08 18:01:00 +01:00
Dan Balasescu
7f3646f2d1
Merge pull request #27069 from bdach/populate-legacy-total-score-when-converting
...
Populate `TotalScoreInfo` when converting `SoloScoreInfo` to `ScoreInfo`
2024-02-08 01:33:31 +09:00
Dean Herbert
0d7e82ab8d
Improve exception logging of unobserved exceptions via FireAndForget
...
Coming from https://github.com/ppy/osu/issues/27076 , where the log
output makes finding where the exception arrived for nigh impossible.
2024-02-08 00:25:11 +08:00