50430 Commits

This Branch

This Branch

All Branches

• Expose required classes/properties for mocking
  Dean Herbert · 2022-04-13 17:02:33 +09:00
  2bb0d9e6d3
• Merge pull request #17790 from huoyaoyuan/remove-binary-serialization

  Remove usages of binary serialization

  Dan Balasescu · 2022-04-13 11:00:23 +09:00
  567d755794
• Merge pull request #17792 from peppy/multi-match-footer-test-remove

  Fix `MultiplayerMatchFooter` test crash due to missing `PopoverContainer`

  Dan Balasescu · 2022-04-13 10:53:27 +09:00
  abf7954a9c
• Merge pull request #17789 from peppy/rank-range-pill-test-refactor

  Refactor `TestSceneRankRangePill` to not depend on `TestMultiplayerClient`

  Dan Balasescu · 2022-04-13 10:46:00 +09:00
  76517cecab
• Reword comment to read clearer

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-04-13 09:36:44 +09:00
  d73be7f177
• Merge pull request #17791 from peppy/gameplay-chat-display-test-refactor

  Refactor `GameplayChatDisplay` test scene to not require `MultiplayerTestScene` inheritance

  Bartłomiej Dach · 2022-04-12 21:11:07 +02:00
  9719b443a1
• Nest one more container to fix popover not being dismissable
  Bartłomiej Dach · 2022-04-12 20:54:54 +02:00
  63e2a84d7f
• Fix MultiplayerMatchFooter test crash due to missing PopoverContainer

  Clicking the countdown button would crash. I did consider removing the
  test altogether but maybe it'll be useful in the future?

  Dean Herbert · 2022-04-12 23:01:39 +09:00
  ef7ab12b40
• Refactor GameplayChatDisplay test scene to not require MultiplayerTestScene inheritance
  Dean Herbert · 2022-04-12 22:56:48 +09:00
  1ebbef88ec
• Remove unused binary serialization related code.
  Huo Yaoyuan · 2022-04-12 20:29:13 +08:00
  80e312dbbc
• Remove usages of BinaryFormatter.
  Huo Yaoyuan · 2022-04-12 20:28:14 +08:00
  bf677ad0ac
• Refactor TestSceneRankRangePill to not depend on TestMultiplayerClient
  Dean Herbert · 2022-04-12 19:39:24 +09:00
  20eca9bf6a
• Merge pull request #17776 from frenzibyte/dangerous-dialog-button-bounds

  Fix dialog dangerous button being clickable at edges

  Dean Herbert · 2022-04-12 15:40:50 +09:00
  e901857610
• Merge pull request #17767 from peppy/multiplayer-gameplay-leaderboard-test-improvements

  Refactor multiplayer gameplay leaderboard tests to remove reliance on `Test` implementations

  Dan Balasescu · 2022-04-12 11:19:53 +09:00
  94e2a90af2
• Also expand match score component when leaderboard is (in test)
  Dean Herbert · 2022-04-12 10:49:57 +09:00
  a0e3a2102a
• Merge pull request #17773 from peppy/fix-skin-duplication

  Fix skins getting duplicated when importing after export

  Bartłomiej Dach · 2022-04-11 22:52:32 +02:00
  0eb0b5b456
• Fix dialog dangerous button being clickable at edges
  Salman Ahmed · 2022-04-11 21:05:37 +03:00
  bad30d9e60
• Add failing test case
  Salman Ahmed · 2022-04-11 21:04:55 +03:00
  74dfa79f17
• Fix skins getting duplicated when importing after export

  Closes #17614.

  Dean Herbert · 2022-04-12 00:29:19 +09:00
  82939b0556
• Add failing test coverage of skin import after exporting from lazer
  Dean Herbert · 2022-04-12 00:29:15 +09:00
  4ab6c11079
• Add test coverage of spectator requests
  Dean Herbert · 2022-04-11 19:27:14 +09:00
  09d560c93e
• Tidy up base implementation
  Dean Herbert · 2022-04-11 19:19:45 +09:00
  6a61fd95eb
• Update existing multiplayer leaderboard tests to use new mocked implementation
  Dean Herbert · 2022-04-11 19:15:57 +09:00
  b52f070fdb
• Split out base implementation of MultiplayerGameplayLeaderboard test
  Dean Herbert · 2022-04-11 19:15:46 +09:00
  0ccac24f76
• Merge pull request #17765 from peppy/fix-multiplayer-room-type

  Fix `MultiplayerTestScene` not setting match type correctly

  Dan Balasescu · 2022-04-11 19:12:57 +09:00
  a7eb5d71f1
• Expose mocked members as virtual on Multiplayer and SpectatorClient
  Dean Herbert · 2022-04-11 19:04:15 +09:00
  34457b4742
• Fix MultiplayerTestScene not actually setting match type correctly
  Dean Herbert · 2022-04-11 17:57:05 +09:00
  abb42a54fd
• Merge pull request #17764 from smoogipoo/fix-playlist-results-screen-test

  Fix incorrect cursor parameterisation in test scene

  Dean Herbert · 2022-04-11 16:10:20 +09:00
  5cfafee83c
• Fix incorrect cursor parameterisation in test scene
  Dan Balasescu · 2022-04-11 15:40:28 +09:00
  d1de516b11
• Merge pull request #17762 from peppy/fix-unobserved-exceptions

  Avoid throwing unobserved exception when `PerformancePointsCounter` requests timed attributes

  Dan Balasescu · 2022-04-11 14:50:12 +09:00
  37976c569a
• Merge pull request #17761 from peppy/fix-drawable-room-null-reference

  Fix potential crash in `DrawableRoom` due to lack of null check on post-lookup beatmap

  Dan Balasescu · 2022-04-11 14:50:01 +09:00
  489f064b13
• Fix potential crash in DrawableRoom due to lack of null check on post-lookup beatmap
  Dean Herbert · 2022-04-11 13:44:34 +09:00
  2b74dbca28
• Add test coverage of DrawableRoom actually showing post-retrieval text
  Dean Herbert · 2022-04-11 13:44:34 +09:00
  779f7390b7
• Avoid throwing unobserved exception when PerformancePointsCounter requests timed attributes
  Dean Herbert · 2022-04-11 13:30:21 +09:00
  19b655d75b
• Merge pull request #17743 from smoogipoo/fix-particle-spewer-nan

  Fix ParticleSpewer outputting NaN values in vertices

  Dean Herbert · 2022-04-09 23:06:14 +09:00
  f2e67d00cc
• Fix ParticleSpewer outputting NaN in vertices
  Dan Balasescu · 2022-04-09 22:29:55 +09:00
  d482ab0287
• Merge pull request #17731 from peppy/fix-highlight-null-ref
  Salman Ahmed · 2022-04-08 20:20:03 +03:00
  2022.409.0 2702f7b9f9
• Perform Show() at the bottom of the method

  Probably not affecting behaviour, but makes more sense.

  Salman Ahmed · 2022-04-08 19:28:04 +03:00
  134d9b5ddf
• Add quick test coverage
  Salman Ahmed · 2022-04-08 19:21:37 +03:00
  34adc1d410
• Fix potential null reference when attempting to highlight a message before overlay has been displayed
  Dean Herbert · 2022-04-09 00:31:00 +09:00
  57fb8616b8
• Make HighlightMessage implicitly show chat overlay
  Dean Herbert · 2022-04-09 00:30:28 +09:00
  ae1e126837
• Merge pull request #17728 from smoogipoo/fix-breaking-assert

  Remove some incorrectly-firing asserts

  Dean Herbert · 2022-04-08 22:58:57 +09:00
  53484eb7de
• Remove some incorrectly-firing asserts
  Dan Balasescu · 2022-04-08 21:44:44 +09:00
  9ea6f9b1fe
• Merge pull request #17725 from peppy/multiplayer-hotifx

  Avoid multiplayer crashes when events arrive in unexpected order

  Dan Balasescu · 2022-04-08 20:23:37 +09:00
  62f5409191
• Merge pull request #17726 from peppy/update-framework

  Update framework

  Dan Balasescu · 2022-04-08 19:48:24 +09:00
  1f5e435bb3
• Merge pull request #17724 from peppy/fix-disconnect-assert-issue

  Fix potential assert failure due to `Room` access from disconnection event

  Dan Balasescu · 2022-04-08 19:44:20 +09:00
  e6e475118f
• Update framework
  Dean Herbert · 2022-04-08 18:09:57 +09:00
  ea4ca6d2ad
• Avoid multiplayer crashes when events arrive in unexpected order

  Intended to be a temporary fix for
  https://github.com/ppy/osu/issues/17713 while a more permanent solution
  is established. A proper fix is actually quite simple, but updating the
  test to work with it is... *slightly* more complicated.
  
  This hotfix will mean that if a `UserJoined` event arrives during the
  unobserved window during room join (of the local user), the local user
  still won't see the joining user, but the game won't crash as a result.

  Dean Herbert · 2022-04-08 17:55:47 +09:00
  5c571996d8
• Fix potential assert failure due to Room access from disconnection event
  Dean Herbert · 2022-04-08 17:41:03 +09:00
  6bb8243212
• Merge pull request #17703 from peppy/fix-storyboard-fallback-animation-frame-count-weirdness

  Fix `DrawableStoryboardAnimation` to handle skin fallback frame count similar to stable

  Dan Balasescu · 2022-04-08 17:01:17 +09:00
  975bb8cc2a