76115 Commits

This Branch

This Branch

All Branches

• Merge pull request #36116 from frenzibyte/new-settings/form-visuals

  Prepare form controls for use in settings

  Dean Herbert · 2025-12-25 03:16:12 +09:00
  2acc2a84db
• Merge pull request #36118 from bdach/zip-magic
  Dean Herbert · 2025-12-25 02:29:18 +09:00
  64d16776be
• Merge pull request #36121 from smoogipoo/mp-fix-availability-tracker

  Fix potentially incorrect online play beatmap availability

  Dean Herbert · 2025-12-24 20:32:46 +09:00
  2d06c2b1a6
• Reduce code duplication

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2025-12-24 19:30:04 +09:00
  81f03957d8
• Fix tests
  Dan Balasescu · 2025-12-24 16:53:08 +09:00
  ecaf3e05d4
• Fix tournament screens not having colour provider cached
  Salman Alshamrani · 2025-12-24 02:22:59 -05:00
  2d85fe8133
• Fix potentially incorrect online play beatmap availability
  Dan Balasescu · 2025-12-24 15:08:37 +09:00
  0af07b97c5
• Update switch button visuals
  Salman Alshamrani · 2025-12-23 20:18:59 -05:00
  033a73e969
• Merge pull request #36101 from bdach/guest-difficulty-export

  Add explicit menu item for exporting guest difficulties from editor

  Dean Herbert · 2025-12-24 00:45:19 +09:00
  1340e18d93
• Make setter protected to fix build error
  Salman Alshamrani · 2025-12-23 06:31:26 -05:00
  95cf050298
• Expose constant for max decimal digits display
  Salman Alshamrani · 2025-12-23 06:14:48 -05:00
  fa32be37d6
• Seal tooltip text overrides
  Salman Alshamrani · 2025-12-23 06:11:05 -05:00
  e4d7bc3896
• Add explanatory note
  Salman Alshamrani · 2025-12-23 06:11:05 -05:00
  520baf6c50
• Revert unintended change
  Salman Alshamrani · 2025-12-23 06:11:05 -05:00
  a1d4d44151
• Fix tests not having colour providers
  Salman Alshamrani · 2025-12-23 05:58:57 -05:00
  a3a5b2ca92
• Make sound playback consistent across all disabled controls
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  cb32d2da3e
• Add label and tooltip formatting to form sliders
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  4ee7e6f787
• Add right margin to form dropdown chevron
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  c2c1fa4d4c
• Use switch button for form checkbox controls
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  339aad42a7
• Update "disabled" visual feedback of form controls
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  a2872ee870
• Add extra form controls in test scene
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  c6a8d9a150
• Merge pull request #36081 from bdach/esdfiopj

  Fix cursor scale affecting trail spacing

  Dean Herbert · 2025-12-23 19:48:34 +09:00
  6eec2b0ff8
• Merge pull request #36047 from bdach/reveal-other-difficulties-thing

  Add ability to view other beatmaps in set when difficulties are split apart

  Dean Herbert · 2025-12-23 19:43:47 +09:00
  0999e3f048
• Merge pull request #36056 from peppy/fix-stacking-woes

  Fix osu! stacking not matching stable in very specific edge cases

  Bartłomiej Dach · 2025-12-23 08:45:40 +01:00
  71386fe465
• Use sane initial value for cursor scale to avoid infinite loops
  Bartłomiej Dach · 2025-12-23 08:43:07 +01:00
  f58e4e4862
• Fix replay files potentially getting misclassified as zip archives

  Resolves https://github.com/ppy/osu/discussions/36107.
  
  The replay linked in the aforementioned discussion happens to contain
  the magic sequence for ZIP headers in the binary stream (50 4b 05 06)
  which led to it getting classified as a ZIP with no entries and
  completely bogus everything in the header at
  
  	https://github.com/ppy/osu/blob/c8b18acd4dd1d98170a069240b6666cea3d5da07/osu.Game/Database/ImportTask.cs#L51-L56
  
  and then finally dying of
  
  	2025-12-23 07:26:45 [error]: [?????] Model creation of replay-osu_2040232_4828629841.osr failed.
  	2025-12-23 07:26:45 [error]: System.InvalidOperationException: Sequence contains no matching element
  	2025-12-23 07:26:45 [error]: at System.Linq.ThrowHelper.ThrowNoMatchException()
  	2025-12-23 07:26:45 [error]: at System.Linq.Enumerable.First[TSource](IEnumerable`1 source, Func`2 predicate)
  	2025-12-23 07:26:45 [error]: at osu.Game.Scoring.ScoreImporter.CreateModel(ArchiveReader archive, ImportParameters parameters)
  	2025-12-23 07:26:45 [error]: at osu.Game.Database.RealmArchiveModelImporter`1.importFromArchive(ArchiveReader archive, ImportParameters parameters, CancellationToken cancellationToken)
  
  at
  
  	https://github.com/ppy/osu/blob/554961036e23615b35eb6b66b341b10924664c4d/osu.Game/Scoring/ScoreImporter.cs#L46

  Bartłomiej Dach · 2025-12-23 08:23:23 +01:00
  95233fc638
• Merge branch 'master' into esdfiopj
  Dean Herbert · 2025-12-23 02:33:08 +09:00
  2ed37ecbbc
• Merge pull request #36080 from bdach/form-slider-bar-disabled

  Fix disabled form slider bars being half-baked

  Dean Herbert · 2025-12-23 02:26:34 +09:00
  554961036e
• Merge branch 'master' into form-slider-bar-disabled
  Dean Herbert · 2025-12-22 23:44:33 +09:00
  dbcc7cc09d
• Merge pull request #36055 from frenzibyte/new-settings/item

  Implement new settings item component

  Dean Herbert · 2025-12-22 22:55:53 +09:00
  d9dad4c3a8
• Adjust colour of inactive slider bar
  Dean Herbert · 2025-12-22 22:06:39 +09:00
  0787345a84
• Add explicit menu item for exporting guest difficulties from editor

  A few facts of life:
  
  - Guest difficulties are at this point a staple of mapping.
  
  - People are very much used to flinging `.osu`s around (because there's
    no better alternative).
  
  - Currently there are two ways to get an `.osu` out of lazer. You can:
  
    - Export the beatmap as "compatibility" to an `.osz`, then
      transmogrify the `.osz` to a `.zip`, then extract the `.zip`, then
      pluck out the `.osu`. This is the "correct" way to make sure stable
      works, but is also stupidly arcane.
  
    - Use "edit externally" to mount the beatmap files to disk, then
      copy-paste out the `.osu`. This is the *wrong* way to make sure
      stable works, because the mounting process exposes the raw "for
      editing" format with features stable doesn't support, but it the
      actual easy one.
  
  - Reports about guest difficulties exported from lazer "working wrong on
    stable" are prevalent. Probably mostly because of the preceding point.
  
  What this PR does is introduce a *third* method to export an `.osu`,
  which is designed to be both the easiest one yet *and* correct. I am
  hoping this will curb the complaints until support for direct submission
  of guest difficulties is added - which I still hope to see, but it will
  be a significant effort *client-side* (the server side has been ready
  for years now).
  
  And yes, you will notice that much of the code added in
  `LegacyBeatmapExporter` related to manipulation of the path is
  copy-pasted from `LegacyExporter`. I don't care enough to invent
  protected / abstract / whatever else OOP faff for something that may not
  survive review and is mostly a weird semi-temporary wart.

  Bartłomiej Dach · 2025-12-22 11:36:23 +01:00
  3712093158
• Move disable to better place
  Bartłomiej Dach · 2025-12-22 10:04:29 +01:00
  df524d68fd
• Add another failing test
  Bartłomiej Dach · 2025-12-22 10:04:18 +01:00
  daaea093f0
• Merge pull request #36021 from tsunyoku/rank-mania-cover

  Set `Ranked` to `true` for `ManiaModCover`

  Dean Herbert · 2025-12-22 13:45:21 +09:00
  469aa7b303
• Fix cursor scale affecting trail spacing

  Closes https://github.com/ppy/osu/issues/36061.
  
  Regressed in https://github.com/ppy/osu/pull/35802.
  
  It's either this or revert of aforementioned pull. I dunno.

  Bartłomiej Dach · 2025-12-19 14:27:55 +01:00
  e094eefafb
• Address review concerns
  Bartłomiej Dach · 2025-12-19 13:59:26 +01:00
  4cce6aa123
• Remove now-redundant tests

  They all pass along with the last stacking threshold fix, so I see no
  reason to keep them in.

  Bartłomiej Dach · 2025-12-19 13:16:14 +01:00
  bba4329ab5
• Fix yet another incorrect threshold check in stacking code
  Bartłomiej Dach · 2025-12-19 13:16:12 +01:00
  25ba3f2dc6
• Fix disabled form slider bars being half-baked

  In order of severity:
  
  - You could actually click on the textbox portion of a disabled textbox,
    focus it, select text, input stuff, and commit, which would die
    on the spot.
  
  - The slider part had no visual indication that it's not interactable
    anymore.

  Bartłomiej Dach · 2025-12-19 12:17:46 +01:00
  ecc51d4701
• Add failing test
  Bartłomiej Dach · 2025-12-19 12:17:06 +01:00
  32454caaa9
• Fix stack threshold being calculated in a different way than stable
  Bartłomiej Dach · 2025-12-19 10:19:20 +01:00
  0f53886784
• Add extended conversion mapping coverage for more failing cases

  Some are not immediately relevant to the stacking issue because they
  fail both before and after it, just less so after the stacking issue
  (half-)fix, and as such have been commented out for the time being.

  Bartłomiej Dach · 2025-12-19 10:19:20 +01:00
  f598d8b108
• Improve revert button animation
  Salman Alshamrani · 2025-12-19 02:27:04 -05:00
  f273163e58
• Merge pull request #36060 from peppy/collection-dialog-improve

  Improve manage collections dialog usability

  Bartłomiej Dach · 2025-12-19 07:53:45 +01:00
  6de1f0cd4d
• Add explanatory note for ClearTransforms usage
  Salman Alshamrani · 2025-12-18 20:04:02 -05:00
  c475b4bc4b
• Simplify classic default flow
  Salman Alshamrani · 2025-12-18 20:03:38 -05:00
  276757315f
• Rename property to have consistent name
  Salman Alshamrani · 2025-12-18 20:01:36 -05:00
  a82d0c3b51
• Use menu item labels as filter terms instead
  Salman Alshamrani · 2025-12-18 19:48:42 -05:00
  4fee1547e3
• Add tooltip to revert-to-default button
  Salman Alshamrani · 2025-12-18 18:56:18 -05:00
  a4215e0442