h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-31 01:50:20 +08:00
Code Issues Releases Wiki Activity

Fix yet another incorrect threshold check in stacking code

Browse Source
This commit is contained in:
Bartłomiej Dach
2025-12-19 13:11:07 +01:00
Unverified
parent 0f53886784
commit 25ba3f2dc6
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game.Rulesets.Osu.Tests/OsuBeatmapConversionTest.cs
+1 -1
View File
@@ -27,7 +27,7 @@ namespace osu.Game.Rulesets.Osu.Tests
[TestCase("multi-segment-slider")]
[TestCase("nan-slider")]
[TestCase("1124896")]
// [TestCase("1341554")] TODO: investigate later
[TestCase("1341554")]
[TestCase("2593923")]
// [TestCase("2730824")] TODO: investigate later
// [TestCase("4235513")] TODO: investigate later
osu.Game.Rulesets.Osu/Beatmaps/OsuBeatmapProcessor.cs
+4 -1
View File
@@ -151,7 +151,10 @@ namespace osu.Game.Rulesets.Osu.Beatmaps
double endTime = objectN.GetEndTime();
if (objectI.StartTime - endTime > stackThreshold)
// truncation to integer is required to match stable
// compare https://github.com/peppy/osu-stable-reference/blob/08e3dafd525934cf48880b08e91c24ce4ad8b761/osu!/GameplayElements/HitObjectManager.cs#L1725
// - both quantities being subtracted there are integers
if ((int)objectI.StartTime - (int)endTime > stackThreshold)
// We are no longer within stacking range of the previous object.
break;