Bartłomiej Dach
15feb17da8
Change difficulty cache storage type to nullable
...
The recent changes related to adding support for working beatmap load
cancellation exposed a flaw in the beatmap difficulty cache. With the
way the difficulty computation logic was written, any error in the
calculation process (including beatmap load timeout, or cancellation)
would result in a 0.00 star rating being permanently cached in memory
for the given beatmap.
To resolve, change the difficulty cache's return type to nullable.
In failure scenarios, `null` is returned, rather than
`default(StarDifficulty)` as done previously.
2021-11-20 17:00:50 +01:00
Salman Ahmed
8b28bf31f6
Separate SignalR workaround types away from resolver
2021-11-20 15:11:02 +03:00
Dean Herbert
b1fcb840a9
Merge pull request #15581 from frenzibyte/update-ios-native-linking
...
Update iOS native references and linker flags in line with framework changes
2021-11-20 19:14:52 +09:00
Dean Herbert
0da4be6f7c
Merge branch 'master' into update-ios-native-linking
2021-11-20 18:47:01 +09:00
Salman Ahmed
f1bcd5ed22
Merge pull request #15689 from peppy/update-dependencies
2021-11-20 12:38:22 +03:00
Salman Ahmed
a8a2ffde42
Sync iOS transitive dependency versions with game
2021-11-20 12:11:09 +03:00
Dean Herbert
50e18ccebb
Update dependencies in mobile props files
2021-11-20 15:14:06 +09:00
Dean Herbert
5afc7c80f6
Merge pull request #15687 from peppy/update-dependencies
...
Update all dependencies
2021-11-20 14:05:36 +09:00
Dean Herbert
e0629ba81c
Update all dependencies
2021-11-20 13:31:10 +09:00
Salman Ahmed
0342923408
Fix SignalR messagepack formatter potentially initializing on iOS
2021-11-19 20:04:31 +03:00
Salman Ahmed
96a5136c53
Update framework
2021-11-19 17:56:07 +03:00
Salman Ahmed
eb1a9aca8d
Merge branch 'master' into update-ios-native-linking
2021-11-19 16:08:18 +03:00
Salman Ahmed
eb1bcf941f
Sync DiffPlex dependency version with game project
2021-11-19 16:07:52 +03:00
Salman Ahmed
5d252f6fc0
Add rider autogenerated .idea files for iOS solution filter
2021-11-19 16:07:52 +03:00
Dan Balasescu
d397524878
Merge pull request #15676 from peppy/multiplayer-incorrect-beatmap-error
...
Show better error message when selecting an unavailable beatmap during multiplayer room creation
2021-11-19 18:59:46 +09:00
Dan Balasescu
de0e8ad822
Merge branch 'master' into multi-queueing-modes
2021-11-19 18:58:15 +09:00
Dan Balasescu
a6444a8a64
Merge pull request #15677 from peppy/multiplayer-song-select-error-parsing
...
Only show user displayable portion of server errors when selecting a song in multiplayer
2021-11-19 18:57:51 +09:00
Dan Balasescu
4c8c34b43f
Use full name for round robin
2021-11-19 18:42:34 +09:00
Dan Balasescu
4e625b78e2
Update queue mode names
2021-11-19 18:28:43 +09:00
Dean Herbert
54facb79d6
Merge pull request #15680 from smoogipoo/nunit-blame
...
Run nunit in blame mode
2021-11-19 17:24:28 +09:00
Dan Balasescu
f3f8ac2c43
Use single
2021-11-19 16:36:32 +09:00
Dan Balasescu
abb8b0de47
Also mutate multiplayer room playlist on callbacks
2021-11-19 16:35:45 +09:00
Dan Balasescu
215c179b92
Run nunit in blame mode
2021-11-19 16:16:20 +09:00
Dean Herbert
59e763467f
Move StoragePath implementation to an extension method
2021-11-19 16:08:38 +09:00
Dan Balasescu
1aa7f681cf
Merge pull request #15678 from peppy/fix-another-test-nullref
...
Fix potential null reference in `FadeAccessibleBackground` test class
2021-11-19 16:03:27 +09:00
Dan Balasescu
12e1142b07
Rename settings section
2021-11-19 15:47:40 +09:00
Dan Balasescu
a922ce2fd9
Remove unnecessary nameofs
2021-11-19 15:45:45 +09:00
Dan Balasescu
a6a786b167
Remove namespacing of queue tests
2021-11-19 15:43:11 +09:00
Dean Herbert
6e5918a100
Add slight scale to icon buttons
2021-11-19 15:28:03 +09:00
Dean Herbert
741c27c1f2
Always populate action to make button behave better in testing scenarios
2021-11-19 15:27:38 +09:00
Dean Herbert
5034cb1025
Merge branch 'master' into beatmap-card/download-button
2021-11-19 14:59:42 +09:00
Dean Herbert
0c289bf8e5
Remove pointless namespace
2021-11-19 14:46:53 +09:00
Dean Herbert
6dc6ca1bbb
Fix potential null reference in FadeAccessibleBackground test class
2021-11-19 14:03:07 +09:00
Dean Herbert
284e554cbf
Only show user displayable portion of server errors when seleting a song in multiplayer
2021-11-19 13:58:03 +09:00
Dan Balasescu
c6c6b04f2b
Merge pull request #15624 from Darius-Wattimena/fix-plate-clearing-missing-last-banana
...
Fix banana showers not clearing the plate when missing the last banana
2021-11-19 13:30:21 +09:00
Dean Herbert
c901a4fd7e
Show better error message when selecting an unavailable beatmap during multiplayer room creation
2021-11-19 13:28:42 +09:00
Dean Herbert
77c0b8dfa9
Fix stray typo
2021-11-19 13:27:06 +09:00
Dean Herbert
cb2547a6be
Merge branch 'master' into multi-queueing-modes
2021-11-19 13:20:57 +09:00
Dan Balasescu
33294ffda6
Merge branch 'master' into fix-plate-clearing-missing-last-banana
2021-11-19 11:42:57 +09:00
Dan Balasescu
6ebe54b183
Merge pull request #15494 from Tollii/beatmap-cancellation-token
...
Add support for cancellation tokens for beatmap difficulty calculation
2021-11-19 10:54:32 +09:00
Bartłomiej Dach
0eaf450204
Make field readonly
2021-11-18 22:50:41 +01:00
Bartłomiej Dach
8a1d6757af
Merge branch 'master' into beatmap-card/download-button
2021-11-18 22:37:35 +01:00
Bartłomiej Dach
412abf30d9
Refactor buttons again to work with latest design guidelines
2021-11-18 22:34:40 +01:00
Bartłomiej Dach
761d1e45f2
Use lime background on right side of card to signify downloaded sets
2021-11-18 21:36:41 +01:00
Darius Wattimena
38edeac710
Moved the logic to the bottom as placeCaughtObject is otherwise not called yet
2021-11-18 20:24:40 +01:00
Darius Wattimena
9685892b94
Added an extra unit test when actually catching the last banana to also clear the plate
2021-11-18 20:23:42 +01:00
Darius Wattimena
cfedbb92c1
Added a unit test to cover clearing of the plate when missing the last banana
2021-11-18 20:07:03 +01:00
Darius Wattimena
95891bc655
Moved clear plate logic to Catcher class
2021-11-18 20:03:41 +01:00
Dan Balasescu
2a5ecad771
Merge pull request #15670 from Joehuu/fix-score-panel-animation
...
Fix score panels sometimes jumping when toggling statistics fast
2021-11-19 01:18:22 +09:00
Dean Herbert
bf8507c7b9
Only apply default timeout when debugger not attached
2021-11-18 23:26:45 +09:00
