67993 Commits

This Branch

This Branch

All Branches

• Add loading segments and tidy things up
  Dean Herbert · 2024-07-10 18:34:46 +09:00
  27ab54882b
• Improve UX and styling of external edit screen
  Dean Herbert · 2024-07-10 18:34:45 +09:00
  74aa05fa6e
• Add sub screen to limit user interactions
  Dean Herbert · 2024-07-10 18:34:45 +09:00
  118162c631
• Add basic flow for mounting beatmaps for external editing
  Dean Herbert · 2024-07-10 18:29:51 +09:00
  d3c66e2404
• Merge pull request #28789 from peppy/fix-deletes-reappearing

  Fix deleted beatmap sets potentially reappearing due to pending update requests

  Bartłomiej Dach · 2024-07-10 09:14:10 +02:00
  95783bd6c2
• Merge pull request #28682 from frenzibyte/footer-v2-overlay-content

  Add implementation for `ScreenFooter` to house footer content of sheared overlays

  Dean Herbert · 2024-07-10 15:08:00 +09:00
  4fe3f39d22
• Merge pull request #28740 from bdach/daily-challenge/better-results

  Improve results displays in daily challenge screen

  Dean Herbert · 2024-07-10 14:17:21 +09:00
  cd9973b6f9
• Merge pull request #28796 from Joehuu/fix-preview-persisting-after-leaving

  Fix preview track persisting to play after entering multi/playlists gameplay

  Dean Herbert · 2024-07-10 14:07:49 +09:00
  9c1dcbcdda
• Rename method to match provided argument
  Dean Herbert · 2024-07-10 14:00:15 +09:00
  f281019358
• Migrate ShearedOverlayContainer to NRT
  Dean Herbert · 2024-07-10 13:54:27 +09:00
  4e1240c349
• Fix preview track persisting to play after leaving multi/playlists room
  Joseph Madamba · 2024-07-09 14:36:24 -07:00
  8c81ba3357
• Add similar special case for insert after removal
  Dean Herbert · 2024-07-09 20:44:55 +09:00
  123d3d2ff8
• Add failing test case showing editor save then delete failure
  Dean Herbert · 2024-07-09 20:41:22 +09:00
  0e2e44a2f5
• Merge branch 'master' into footer-v2-overlay-content
  Salman Ahmed · 2024-07-09 13:41:44 +03:00
  b17af86491
• Merge pull request #28786 from Joehuu/sort-direction-caret-transition

  Add caret transition to beatmap listing sort tab items

  Bartłomiej Dach · 2024-07-09 10:52:11 +02:00
  13c8370823
• Fix deleted beatmap sets potentially reappearing due to pending update requests
  Dean Herbert · 2024-07-09 17:08:26 +09:00
  920c0e4d25
• Ensure beatmap set is always detached when updating

  Slight performance improvement by doing the detach as early as possible.

  Dean Herbert · 2024-07-09 17:08:25 +09:00
  63b4327978
• Merge pull request #28787 from peppy/adjust-editor-fades

  Adjust editor transparent tweens to be less "flashy"

  Bartłomiej Dach · 2024-07-09 10:08:14 +02:00
  877ade3053
• Merge pull request #28785 from peppy/fix-realm-callbacks

  Ensure realm subscriptions always fire initial callback with null `ChangeSet`

  Dan Balasescu · 2024-07-09 16:52:38 +09:00
  e734cdfee5
• Adjust editor transparent tweens to be less "flashy"

  Touched on in https://github.com/ppy/osu/discussions/28581.
  
  After a bit more usage of the editor I do agree with this and think that
  making the fades a bit more gentle helps a lot.

  Dean Herbert · 2024-07-09 16:16:19 +09:00
  aadcc5384d
• Inhibit original callback from firing when sending initial changeset
  Dean Herbert · 2024-07-09 16:05:58 +09:00
  ee9e329db3
• Ensure realm subscriptions always fire initial callback with null ChangeSet

  We expect this to be the case, but it turns out that it [may be
  coalesced](https://www.mongodb.com/docs/realm-sdks/dotnet/latest/reference/Realms.IRealmCollection-1.html#Realms_IRealmCollection_1_SubscribeForNotifications_Realms_NotificationCallbackDelegate__0__Realms_KeyPathsCollection_):
  
  > Notifications are delivered via the standard event loop, and so can't
  > be delivered while the event loop is blocked by other activity. When
  > notifications can't be delivered instantly, multiple notifications may
  > be coalesced into a single notification. This can include the
  > notification with the initial collection.
  
  Rather than struggle with handling this locally every time, let's fix
  the callback at our end to ensure we receive the initial null case.
  
  I've raised concern for the API being a bit silly with realm
  (https://github.com/realm/realm-dotnet/issues/3641).

  Dean Herbert · 2024-07-09 15:47:43 +09:00
  2423bbb776
• Add failing test showing realm not sending through null ChangeSet
  Dean Herbert · 2024-07-09 15:47:43 +09:00
  c8b9c117cd
• Add caret transition to beatmap sort tab items
  Joseph Madamba · 2024-07-08 16:46:35 -07:00
  cd968d4185
• Merge pull request #28769 from peppy/carousel-realm-simplification

  Simplify realm model tracking in `BeatmapCarousel` (and fix hard delete handling)

  Dean Herbert · 2024-07-09 01:40:10 +09:00
  c100d1ab65
• Merge pull request #28780 from huoyaoyuan/net8.0/new-api

  Use Environment.IsPrivilegedProcess and remove Mono.Posix.NETStandard

  Dan Balasescu · 2024-07-09 01:29:12 +09:00
  64e527852c
• Use Environment.IsPrivilegedProcess
  Huo Yaoyuan · 2024-07-09 00:04:29 +08:00
  ae78c13684
• Merge pull request #28776 from bdach/fix-composer-disappearing

  Fix composer disappearing when undoing change to control points

  Dan Balasescu · 2024-07-09 00:54:38 +09:00
  9c2a0576fb
• Ensure other lists are cleared when realm is reset
  Dean Herbert · 2024-07-08 23:59:20 +09:00
  9a61adc4bc
• Merge pull request #28771 from frenzibyte/sorted-breaks

  Fix breaks not showing unless already ordered in the beatmap file

  Bartłomiej Dach · 2024-07-08 16:46:50 +02:00
  4dd20ccf79
• Fix composer disappearing when undoing change to control points

  As mentioned in https://github.com/ppy/osu/issues/28752.
  Regressed in https://github.com/ppy/osu/pull/28444.

  Bartłomiej Dach · 2024-07-08 16:28:54 +02:00
  275b959c02
• Add failing test case
  Bartłomiej Dach · 2024-07-08 16:28:33 +02:00
  449d50a46a
• Merge branch 'master' into sorted-breaks
  Bartłomiej Dach · 2024-07-08 15:59:32 +02:00
  877b5768fc
• Pass comparer in all usages for consistency
  Bartłomiej Dach · 2024-07-08 15:58:21 +02:00
  0d22c9a9c6
• Enforce IBeatmap.Breaks to be sorted chronologically
  Salman Ahmed · 2024-07-08 16:06:38 +03:00
  b33e54d064
• Add failing test case
  Salman Ahmed · 2024-07-08 16:06:34 +03:00
  da4067d059
• Merge pull request #28772 from OliBomby/time-accurate

  Fix CurrentTimeAccurate being inaccurate

  Bartłomiej Dach · 2024-07-08 14:50:13 +02:00
  baff790b4c
• Merge branch 'master' into time-accurate
  Bartłomiej Dach · 2024-07-08 14:19:57 +02:00
  2cad8d3684
• Merge pull request #28770 from bdach/really-now

  Fix editor playback control not removing correct adjustment

  Dan Balasescu · 2024-07-08 20:45:17 +09:00
  5cae005027
• Fix incorrect changes around success callback refactor
  Bartłomiej Dach · 2024-07-08 13:36:30 +02:00
  d5158d1035
• Fix CurrentTimeAccurate being inaccurate if seeking smoothly in the same frame and a transform is already active
  OliBomby · 2024-07-08 13:30:11 +02:00
  2822ba2377
• Fix editor playback control not removing correct adjustment

  Closes https://github.com/ppy/osu/issues/28768.
  
  great job past me 🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦

  Bartłomiej Dach · 2024-07-08 13:21:42 +02:00
  0fe2c45e1d
• Add failing test case
  Bartłomiej Dach · 2024-07-08 13:21:38 +02:00
  6433f29651
• Merge pull request #28762 from frenzibyte/change-chevron-display

  Change display of "expanded" chevrons in many UI components to use scale instead of rotation

  Dean Herbert · 2024-07-08 20:05:59 +09:00
  c0a1696538
• Coalesce beatmap updates
  Dean Herbert · 2024-07-08 20:05:18 +09:00
  8f271170e9
• Simplify tracking of hidden beatmaps

  Handling a few extra events is preferrable to keeping a second realm
  subscription live.

  Dean Herbert · 2024-07-08 20:05:18 +09:00
  1095137a5b
• Simplify tracking of beatmap sets in BeatmapCarousel
  Dean Herbert · 2024-07-08 20:05:18 +09:00
  151c448535
• Add failing test for beatmap set hard deletion
  Dean Herbert · 2024-07-08 20:05:17 +09:00
  e51d510ea3
• Fix sizing / padding of collection dropdown header
  Dean Herbert · 2024-07-08 19:32:28 +09:00
  910153c2e0
• Merge pull request #28765 from bdach/editor-menu-max-height

  Fix editor menus overflowing off screen

  Dan Balasescu · 2024-07-08 19:13:30 +09:00
  b2bdb67a3e