44241 Commits

Author	SHA1	Message	Date
Shin Morisawa	8ff86d560f	Merge branch 'master' into master	2024-10-14 17:48:04 +09:00
Bartłomiej Dach	120eb9adea	Merge pull request #30261 from peppy/faster-quick-retry ... Decrease the time it takes to quick retry by ~650 ms	2024-10-14 10:24:35 +02:00
Shin Morisawa	90a08b8a68	Fix Beatmap Delete Dialog	2024-10-14 09:55:28 +09:00
Dean Herbert	53671ad11e	Only update beatmaps which actually had offsets ... Without this every beatmap gets a write and it reloads the whole of song select, basically.	2024-10-14 00:35:18 +09:00
Dean Herbert	868a7db9e9	Start preparing player earlier when quick retrying ... Should help with https://github.com/ppy/osu/issues/9039.	2024-10-13 22:29:00 +09:00
Artemis Rosman	e4f9c861ba	Add functionality to mass reset offsets	2024-10-13 00:50:45 +11:00
Dan Balasescu	2de1955892	Merge pull request #30218 from bdach/daily-challenge-conclusion-offline ... Do not show daily challenge conclusion notification on disconnection	2024-10-12 18:14:22 +09:00
Bartłomiej Dach	968835bb44	Do not show daily challenge conclusion notification on disconnection ... Closes https://github.com/ppy/osu/issues/30194.	2024-10-11 14:18:19 +02:00
Bartłomiej Dach	9d1eb842a7	Add failing test	2024-10-11 14:16:24 +02:00
Bartłomiej Dach	4a16341a94	Fix crash when switching tracks back and forth with shuffle on	2024-10-11 12:45:14 +02:00
Bartłomiej Dach	47cb696b69	Fix switching direction when changing tracks with shuffle on restarting the same track ... Closes https://github.com/ppy/osu/issues/30190.	2024-10-11 12:40:45 +02:00
Dan Balasescu	616c2aeefc	Merge pull request #30206 from minetoblend/fix/selection-box-buttons-stuck ... Fix SelectionBox buttons freezing when button is triggered via key event	2024-10-11 12:02:58 +09:00
Marvin Schürz	af55585dc8	Make TriggerAction public	2024-10-10 20:50:47 +02:00
Marvin Schürz	fc7ad96fcd	Move circle flash to TriggerAction	2024-10-10 20:20:02 +02:00
Marvin Schürz	9cc6ee2ebc	Fix SelectionBox buttons freezing when button is triggered via key event	2024-10-10 20:14:11 +02:00
Dean Herbert	14ecd56913	Merge pull request #30195 from bdach/advanced-stats-stupid-shenanigans ... Fix crashes when attempting to change from a custom ruleset with mods selected to another	2024-10-11 00:57:28 +09:00
Bartłomiej Dach	938c3d78ce	Fix argon song progress bar tooltip showing during active gameplay ... Closes https://github.com/ppy/osu/issues/30197. Pretty bad one, might be worth a hotfix...	2024-10-10 14:36:28 +02:00
Bartłomiej Dach	687bdad389	Remove no-longer-required cache-over hack ... This is now removable after `AdvancedStats` has been weaned off the global mods bindable. I think this is a win all things considered?	2024-10-10 14:22:20 +02:00
Bartłomiej Dach	f1842d781e	Decouple AdvancedStats from global mods ... Closes https://github.com/ppy/osu/issues/30163. If I'm to be blunt, the decoupled stuff in song select makes my head spin. I spent a solid 20 minutes thinking how I was going to fix this one but then finally realised that generally most of the cause there was the fact that `AdvancedStats` was seeing the new rulesets *before* the "ensure global selected mods are valid for current ruleset" logic, and so decided to just _delay_ that until the decoupled transfer thingamajig happens. I was honestly considering combining `BeatmapInfo`, `Ruleset`, and `Mods` into one property on `AdvancedStats`. I figured I'd rather not push my luck and try the baseline version first, but I honestly think that direction is going to be required at some point to properly corral all of the decoupled madness taking place in song select.	2024-10-10 14:22:16 +02:00
Bartłomiej Dach	baa64d1486	Migrate MusicController to Live<T> to fix broken migrations instead	2024-10-09 11:59:04 +02:00
Bartłomiej Dach	081d87fe6d	Revert 'Fix any and all migration attempts dying on MusicController' ... This reverts commit 310eec69fc. Way to try and "fix" stuff and screw stuff up even harder instead, me. Great job, well done.	2024-10-09 11:55:59 +02:00
Dean Herbert	270c4c4f12	Merge pull request #30151 from bdach/migration-is-completely-fucked ... Fix several breakages with migration operation	2024-10-09 14:24:34 +09:00
Dean Herbert	d836dba982	Rename and xmldoc RealmResetEmptySet	2024-10-09 14:18:34 +09:00
Dean Herbert	48dacd1c15	Remove unused property	2024-10-09 13:45:35 +09:00
Dean Herbert	7ccb770009	Update framework	2024-10-09 12:36:51 +09:00
Bartłomiej Dach	b811b9baf6	Fix DetachedBeatmapStore special condition for detecting resets from blocking all operations failing on empty databases ... See https://discord.com/channels/188630481301012481/188630652340404224/1293309912591368244.	2024-10-08 23:16:17 +02:00
Bartłomiej Dach	1633cbdb66	Fix OsuGameBase.Migrate() eating exception messages for breakfast ... Whomst've thought this was an ok thing to do? How did this pass review? Let's leave these as rhetorical questions right now. Huge chances are I'd implicate myself with at least one of them.	2024-10-08 23:16:17 +02:00
Bartłomiej Dach	310eec69fc	Fix any and all migration attempts dying on MusicController ... I'm not sure why this was "fine" for as long as it apparently was, but what `MusicController` was doing was completely incorrect and playing with fire (accessing raw managed realm objects), which went wrong somewhere around - admittedly - https://github.com/ppy/osu/pull/29917, likely because that one started *storing* these raw managed realm objects to fields, and you know what will happen to those after you do a migration and recycle realms. To attempt to circumvent this, (ab)use `DetachedBeatmapStore` instead. Which does necessitate moving it to `OsuGameBase`, but it's the simplest way out I can see. I guess the alternative would be to faff around with `Live<T>` but it's ugly and I'm attempting to fix this relatively quick right now.	2024-10-08 23:16:10 +02:00
Dean Herbert	b1be31cd6a	Switch back to last tool after using grid tool, rather than always select tool	2024-10-08 17:34:51 +09:00
Dean Herbert	682023e130	Merge branch 'master' into grids-4	2024-10-08 16:26:42 +09:00
Dean Herbert	b658d9a681	Merge pull request #30073 from peppy/updates-outside-of-gameplay-only-2 ... Avoid updates (and update notifications) from appearing in more gameplay cases	2024-10-08 15:17:09 +09:00
OliBomby	076c8dec5a	Revert "Use new place grid icon" ... This reverts commit db10202642.	2024-10-07 19:06:32 +02:00
Dean Herbert	a02cda6528	Update resources	2024-10-08 01:51:56 +09:00
OliBomby	db10202642	Use new place grid icon	2024-10-07 16:51:53 +02:00
Bartłomiej Dach	84d6467e48	Merge branch 'master' into taikostatacc	2024-10-07 14:15:29 +02:00
OliBomby	7b998219d7	move grid placement tool to left toolbox	2024-10-07 12:04:14 +02:00
Dan Balasescu	aee5f0ebf5	Fix incorrect condition	2024-10-07 19:01:25 +09:00
OliBomby	d7526be243	Merge remote-tracking branch 'upstream/master' into grids-4	2024-10-07 11:56:35 +02:00
Bartłomiej Dach	f30ac5d996	Merge branch 'master' into no-combo-scaling	2024-10-07 11:50:58 +02:00
Dan Balasescu	6e659e156e	Refactoring for correctness	2024-10-07 17:50:23 +09:00
OliBomby	0a7d2395d2	fix tooltip in SettingsButton	2024-10-07 10:43:24 +02:00
Dan Balasescu	8dece70097	Merge branch 'master' into updates-outside-of-gameplay-only-2	2024-10-07 17:41:42 +09:00
Dean Herbert	11fc811e2f	Fix delete dialogs having generic "Caution" header text ... Regressed in https://github.com/ppy/osu/pull/28363.	2024-10-07 16:46:53 +09:00
Dean Herbert	75f15ccaba	Maybe fix compilation? Fuck knows if this is correct.	2024-10-07 16:04:24 +09:00
Dean Herbert	1ab02b93b3	Merge branch 'master' into grids-4	2024-10-07 15:42:23 +09:00
Dean Herbert	5c826be652	Merge pull request #29860 from bdach/fix-nudging ... Only allow seek to next/previous object via keybinding if there is no selection	2024-10-07 15:36:19 +09:00
Dan Balasescu	944f8f5f67	Merge pull request #30078 from CloneWith/update/progresshover ... Add progress tooltip for ArgonSongProgressBar	2024-10-07 15:20:50 +09:00
Dean Herbert	6e4eed657c	Fix weird mouse position handling and don't return true to event	2024-10-07 14:32:31 +09:00
Dean Herbert	b5cc45bdda	Simplify format code (and adjust formatting slightly)	2024-10-07 14:26:42 +09:00
Bartłomiej Dach	1854e1c2f9	Merge branch 'master' into form-slider-bar-transfer-value-on-commit	2024-10-07 07:21:23 +02:00