4237 Commits

• Merge branch 'master' into no-combo-scaling
  apollo-dw · 2022-10-24 02:17:39 +01:00
  23d0c03fc8
• Change distance snap to never account for slider velocity

  This is a nuanced detail that was implemented incorrectly from the
  outset. When mapping, generally a mapper chooses the distance spacing
  with no regard to the SV. It has always been common to have a lower
  or higher distance spacing than SV, but with the way the lazer editor
  has worked, the SV was multiplied into the distance snap grid display,
  incorectly changing its spacing depending on the "reference object"
  (which is usually the previous hitobject chronologically).

  Dean Herbert · 2022-10-21 21:51:24 +09:00
  7dc03097ff
• Merge pull request #20809 from peppy/fix-taiko-broken-drum-roll-ticks

  Fix taiko drum roll ticks sometimes overflowing outside the drum roll itself

  Dan Balasescu · 2022-10-21 12:56:14 +09:00
  703a8afb11
• Fix incorrect fallback logic

  Regressed when attempting to share implementation of binary search.

  Dean Herbert · 2022-10-20 23:08:44 +09:00
  5c13c443ff
• Refactor implementation to support hitobjects nested multiple levels deep
  Dean Herbert · 2022-10-20 22:30:30 +09:00
  26860a903e
• Fix nested objects in overlapping scrolling hit object container ruleset not using correct reference time
  Dean Herbert · 2022-10-18 16:15:21 +09:00
  d237c818f6
• Standardise control point search logic in OverlappingScrollAlgorithm

  Was using a very local algorithm which I cannot guarantee is correct.
  I'd rather it just use the one used everywhere else.

  Dean Herbert · 2022-10-18 16:01:05 +09:00
  ec3761ced9
• Adjust paddings to feel better now that backgrounds are visible of toolboxes
  Dean Herbert · 2022-10-18 14:38:45 +09:00
  860214c22a
• Fix osu! editor padding being applied to toolboxes

  The result of https://github.com/ppy/osu/pull/20739 and https://github.com/ppy/osu/pull/20738 having unintended side effects when applied together.

  Dean Herbert · 2022-10-18 14:32:00 +09:00
  6a7f6c76ff
• Merge pull request #20593 from ekrctb/catch-editor-height

  Allow arbitrary height catch editor

  Dean Herbert · 2022-10-18 12:10:49 +09:00
  ccbac08985
• Merge branch 'master' into hide-mouse-on-keyboard-input
  Salman Ahmed · 2022-10-14 22:26:30 +03:00
  ba72f13f54
• Change background colour to a lighter tint to avoid clash with slider bars
  Dean Herbert · 2022-10-14 19:38:27 +09:00
  32c3e35762
• Add background behind editor toolbox groups
  Dean Herbert · 2022-10-13 16:36:19 +09:00
  4d99c7002b
• Update xmlodc and add nullability attributes
  Salman Ahmed · 2022-10-13 00:16:42 +03:00
  4fb156ef4e
• Remove default invisible cursor container from rulesets
  Salman Ahmed · 2022-10-12 17:50:47 +03:00
  7a6ecaff0d
• Improve flashlight display on break periods
  Salman Ahmed · 2022-10-11 17:16:57 +03:00
  84fdd2e107
• Rename various cursor symbols

  - `IProvideCursor.MenuCursor` -> `IProvideCursor.Cursor`
   - `MenuCursor` -> `MenuCursorContainer

  Salman Ahmed · 2022-10-11 16:21:01 +03:00
  9b45a9cf76
• Implement hold "sliding" samples in osu!mania
  Dean Herbert · 2022-10-11 16:31:37 +09:00
  f060e6a780
• Merge pull request #20606 from sw1tchbl4d3r/barline_generator_improvements

  Barline generator improvements

  Dean Herbert · 2022-10-11 01:31:30 +09:00
  5a43cb6bb2
• Make currentEffectPoint non-nullable
  sw1tchbl4d3 · 2022-10-10 15:34:29 +02:00
  5a4196fd51
• Make effect point search more efficient
  sw1tchbl4d3 · 2022-10-10 14:00:26 +02:00
  d389808427
• Switch DefinitelyBigger to AlmostBigger to account for fp errors
  sw1tchbl4d3 · 2022-10-10 09:39:40 +02:00
  eae32ca483
• Remove non-smoke key bindings on "Relax" mod instead
  Salman Ahmed · 2022-10-09 17:14:16 +03:00
  2d4f390372
• Respect OmitFirstBarLine effect
  sw1tchbl4d3 · 2022-10-07 20:38:32 +02:00
  63ffaa6929
• Move endTime to next timing point
  sw1tchbl4d3 · 2022-10-07 20:34:31 +02:00
  903c8612c8
• Merge branch 'master' into adjust-flashlight
  Dan Balasescu · 2022-10-07 14:45:30 +09:00
  bce20e0a59
• Extract combo scale to virtual function
  Dan Balasescu · 2022-10-07 14:26:19 +09:00
  7385ef3e1b
• Allow changing scrolling speed in catch editor

  Scroll speed is not saved and doesn't affect gameplay.
  It is purely a feature for a better visualization.
  It is currently bind to scroll speed increase/decrease.
  Default F3/F4 crashes with editor shortcuts so it has to be changed.

  ekrctb · 2022-10-06 18:06:16 +09:00
  9247ff3e0a
• Fix scrolling nested hit object lifetime not set
  ekrctb · 2022-10-04 15:17:14 +09:00
  1cccd03480
• Add test for scrolling hit object lifetime
  ekrctb · 2022-10-04 15:17:11 +09:00
  781f5420b0
• Compute lifetime from entry in scrolling container
  ekrctb · 2022-10-04 15:12:28 +09:00
  5d80950eaf
• Adjust flashliht scaling to match classic
  Dan Balasescu · 2022-10-03 18:38:29 +09:00
  deae7cff60
• Add ability to adjust flashlight smoothness
  Dan Balasescu · 2022-10-03 18:24:56 +09:00
  0df217d85c
• Merge pull request #20509 from o-dasher/cleanup-setting-sources

  Removes unnecessary setting sources specifications

  Dan Balasescu · 2022-09-28 17:55:42 +09:00
  1890a66b28
• Merge pull request #20510 from sw1tchbl4d3r/high_bpm_judgements

  Clamp `LifetimeStart` of `HitObject`s to their judgement windows

  Dan Balasescu · 2022-09-28 17:49:35 +09:00
  cbed268ac9
• Clamp LifetimeStart of HitObject's to their judgement windows
  sw1tchbl4d3 · 2022-09-27 16:54:24 +02:00
  0cffbb7562
• Removes unnecessary setting sources specifications
  o-dasher · 2022-09-27 09:25:58 -04:00
  f3e25eacad
• Avoid performing a realm write if there are no changes pending in RulesetConfigManager
  Dean Herbert · 2022-09-26 14:55:23 +09:00
  c4887269f7
• Cleanup all other leftover binding instantiation
  o-dasher · 2022-09-25 16:02:40 -04:00
  feadac1f79
• Cleanup mod bindings
  o-dasher · 2022-09-25 15:49:22 -04:00
  537796c3a1
• Improve exception when attempting to call DrawableHitObject.ClearInternal
  Dean Herbert · 2022-09-22 14:44:03 +09:00
  78625fda7d
• Fix when flashlight shrinking takes place
  O Thiago · 2022-09-18 18:59:17 -04:00
  a4e9c7711c
• Revert changes

  This reverts commit beef3b418a.
  
  Revert "Use linq expression for handling breaks"
  
  This reverts commit 8464a1941b.
  
  Revert "renames variables to make more logical sense"
  
  This reverts commit 3b87ecf56c.
  
  Revert "Removes overhead when not combo based size"
  
  This reverts commit ac4229e3d4.

  O Thiago · 2022-09-18 18:57:53 -04:00
  407b104116
• Removes overhead when not combo based size
  O Thiago · 2022-09-18 00:38:01 -04:00
  ac4229e3d4
• renames variables to make more logical sense
  O Thiago · 2022-09-18 00:19:40 -04:00
  3b87ecf56c
• Use linq expression for handling breaks
  O Thiago · 2022-09-17 23:49:23 -04:00
  8464a1941b
• Simplifies size calculation
  O Thiago · 2022-09-17 23:41:23 -04:00
  beef3b418a
• Rename CreateLegacySkinProvider to CreateSkinTransformer and apply to all skins
  Dean Herbert · 2022-09-15 20:18:10 +09:00
  c7f8f948b9
• Merge pull request #20319 from peppy/remove-ef-migration

  Remove all entity framework code and migrations

  Dan Balasescu · 2022-09-15 19:15:23 +09:00
  96a89f4fca
• Remove all EF models
  Dean Herbert · 2022-09-15 16:59:36 +09:00
  28b15e232d