68633 Commits

This Branch

This Branch

All Branches

• Remove legacy non-pooled pathway to DrawableJudgement
  Dean Herbert · 2024-08-13 21:03:00 +09:00
  2221c4891f
• Add log output when judgements aren't being pooled
  Dean Herbert · 2024-08-13 20:57:23 +09:00
  bb0c9e2497
• Never call prepareDrawables from unsafe context

  I can't mentally figure out *what* is causing the issue here, but in the
  case where `prepareDrawables` is called from
  `JudgementBody.OnSkinChanged` (only happens in a non-pooled scenario),
  things go very wrong.
  
  I think a smell test is enough for anyone to agree that the flow was
  very bad. Removing this call doesn't seem to cause any issues.
  
  `runAnimation` should always be called in `PrepareForUse` (both pooled
  and non-pooled scenarios) so things should still always be in a correct
  state.
  
  Closes #29398.

  Dean Herbert · 2024-08-13 20:57:20 +09:00
  d74ac57092
• Merge pull request #29402 from peppy/fix-recommender-test

  Fix occasional test failures in `TestSceneBetmapRecommendations`

  Dan Balasescu · 2024-08-13 18:25:01 +09:00
  50601544b3
• Fix occasional test failures in TestSceneBetmapRecommendations

  The game was being constructed befor the API was setup, which could mean
  depending on test execution ordering and speed, the recommendations
  array would not be filled.
  
  Easy to reproduce by `[Solo]`ing `TestCorrectStarRatingIsUsed`.
  
  See https://github.com/ppy/osu/runs/28689915929#r0s0.

  Dean Herbert · 2024-08-13 17:28:16 +09:00
  14a00621f8
• Merge pull request #29401 from CloneWith/patch/wiki-locale

  Automatically use in-game language for wiki pages

  Dan Balasescu · 2024-08-13 17:18:29 +09:00
  513a666847
• Fix another test

  The last two PRs didn't interact well together.

  Dan Balasescu · 2024-08-13 17:18:11 +09:00
  58354e3e68
• Revert "Make ManiaAction start at 1"

  This reverts commit 952a73b005.

  Dean Herbert · 2024-08-13 16:38:56 +09:00
  4f37643780
• Enable NRT while we're here
  Dan Balasescu · 2024-08-13 16:08:06 +09:00
  3f02869bcc
• Make ManiaAction start at 1
  Dean Herbert · 2024-08-13 15:51:33 +09:00
  952a73b005
• Merge pull request #29342 from cl8n/remove-mania-action-special

  Remove "Special" `ManiaAction`s for center columns

  Dan Balasescu · 2024-08-13 15:36:36 +09:00
  4b4f0ecf7d
• Merge pull request #29388 from cl8n/fix-mania-replay

  Fix error on parsing osu!mania replays with 18 or more keys

  Dan Balasescu · 2024-08-13 15:29:53 +09:00
  cd76f474d8
• Reload wiki page on language change
  CloneWith · 2024-08-13 13:34:11 +08:00
  ca91726190
• Use key offsets instead of cast
  Dan Balasescu · 2024-08-13 14:03:26 +09:00
  12a1889fac
• Merge github.com:ppy/osu into patch/wiki-locale
  CloneWith · 2024-08-13 11:51:14 +08:00
  64468bce6d
• Get in-game locale for wiki pages
  CloneWith · 2024-08-13 11:50:33 +08:00
  7cbb4ab6f1
• Merge pull request #29372 from ArijanJ/song-progress-optional-time

  Add option to hide song progress time/text

  Dean Herbert · 2024-08-13 00:57:15 +09:00
  16f6e26c2e
• Merge pull request #29394 from peppy/fix-song-select-context-menu-click

  Fix context menus sometimes not being clickable at song select

  Bartłomiej Dach · 2024-08-12 14:31:30 +02:00
  acc7757582
• Fix context menus sometimes not being clickable at song select

  Closes https://github.com/ppy/osu/issues/21602.

  Dean Herbert · 2024-08-12 20:31:20 +09:00
  b567ab2a39
• Merge pull request #29363 from peppy/fix-daily-challenge-notification-spam

  Fix daily challenge notification spam

  Bartłomiej Dach · 2024-08-12 12:18:38 +02:00
  92bd123ebc
• Merge pull request #29368 from nekodex/daily-challenge-intro-sfx

  Add sound design for daily challenge intro animation

  Dean Herbert · 2024-08-12 18:28:03 +09:00
  8b635deef8
• Change notification interval to 30 minutes
  Bartłomiej Dach · 2024-08-12 11:24:59 +02:00
  96bd374b18
• Clean up some naming weirdness
  Bartłomiej Dach · 2024-08-12 11:23:36 +02:00
  54a1d79136
• Fix tests
  Bartłomiej Dach · 2024-08-12 11:19:02 +02:00
  041c70e4eb
• Move disposal method to more expected location
  Bartłomiej Dach · 2024-08-12 10:46:58 +02:00
  306e84c7ac
• Merge branch 'master' into daily-challenge-intro-sfx
  Bartłomiej Dach · 2024-08-12 10:38:30 +02:00
  298c40250c
• Merge pull request #29347 from peppy/daily-challenge-intro-audio-auto-download

  Start playing the daily challenge track during the intro (and automatically download)

  Bartłomiej Dach · 2024-08-12 10:36:14 +02:00
  7b51ec8509
• Fix mouseX legacy replay parsing for high key counts in mania
  clayton · 2024-08-11 09:45:43 -07:00
  9620c58751
• Update mania replay decode test to include 18K keypress
  clayton · 2024-08-11 09:45:42 -07:00
  2233602184
• Fix one more inspectcode warning
  ArijanJ · 2024-08-10 09:45:30 +02:00
  fed5b9d747
• Fix double blank line
  ArijanJ · 2024-08-09 23:08:22 +02:00
  d01e76d9db
• Add option to hide song progress time/text
  ArijanJ · 2024-08-09 22:50:37 +02:00
  2dee8bef7e
• Merge branch 'master' into daily-challenge-intro-sfx
  Dean Herbert · 2024-08-10 02:22:48 +09:00
  df43263e38
• Update resources
  Dean Herbert · 2024-08-10 02:08:02 +09:00
  c29b40ae65
• Merge pull request #29350 from frenzibyte/fix-ios-again

  Remove `iPhone`/`iPhoneSimulator` platform configurations and fix iOS build workflow

  Dan Balasescu · 2024-08-10 01:28:04 +09:00
  dbd2e2e91f
• Merge branch 'master' into daily-challenge-intro-audio-auto-download
  Dean Herbert · 2024-08-10 01:21:43 +09:00
  d2c1d83567
• Merge branch 'master' into fix-ios-again
  Dan Balasescu · 2024-08-10 01:06:41 +09:00
  b569824ad5
• Merge pull request #29367 from peppy/update-framework

  Update framework

  Dan Balasescu · 2024-08-10 01:06:16 +09:00
  4dc779a262
• Update framework
  Dean Herbert · 2024-08-10 00:11:39 +09:00
  81777f22b4
• Add sound design for daily challenge intro animation
  Jamie Taylor · 2024-08-09 23:05:33 +09:00
  c6fa348d82
• Update framework
  Dean Herbert · 2024-08-09 22:50:56 +09:00
  3896a081a5
• Merge pull request #29346 from peppy/move-mute-button

  Move mute button to master volume circle

  Dean Herbert · 2024-08-09 21:16:47 +09:00
  bb7cea2417
• Hack around the border looking ugly

  This is an o!f issue because borders are applied into the individual
  sprites of the container via masking, rather than being isolated to the
  container itself. In this case, it'll be applied to the "flash" sprite,
  which is using additive blending, causing further issues.

  Dan Balasescu · 2024-08-09 19:55:57 +09:00
  179a3ad8dd
• Make icon smaller
  Dean Herbert · 2024-08-09 19:29:23 +09:00
  fa9a835eb5
• Merge pull request #29362 from peppy/dont-truncate-floating-point-positioning

  Fix hit object coordinates being truncated to `int` values

  Dan Balasescu · 2024-08-09 19:10:24 +09:00
  104942ccf6
• Merge pull request #29366 from peppy/editor-inspector-during-placement

  Show object inspector values during placement

  Dan Balasescu · 2024-08-09 19:03:10 +09:00
  dc3e6c1e6b
• Add temporary debug code for multiplayer test failures
  Dean Herbert · 2024-08-09 18:43:37 +09:00
  3e634a14a4
• Merge pull request #29365 from peppy/fix-chat-test-rng

  Fix occasionally `ChatOverlay` test failures due to RNG usage

  Dan Balasescu · 2024-08-09 18:27:20 +09:00
  1082ffec9d
• Show object inspector values during placement
  Dean Herbert · 2024-08-09 18:02:37 +09:00
  8fdd94090b
• Make ID retrieval global to all tests and fix multiple other usages
  Dean Herbert · 2024-08-09 17:46:51 +09:00
  c8a7727199