Naxess
ad78aec1ef
Refresh IssueList on changes in VisibilitySection
2021-05-12 01:30:45 +02:00
Naxess
1bb7d412da
Add IssueList filtering based on those bindables
2021-05-12 01:29:46 +02:00
Naxess
2e4399f0c1
Add VisibilitySection and its bindables in IssueList
2021-05-12 01:27:21 +02:00
Naxess
01b8794757
Add abstract Section class
...
Similar to `Section` in the timing screen, but does not make use of checkboxes, nor specific to control points.
So there's a lot of things that differ, hence new class instead of factoring that out.
2021-05-12 01:26:12 +02:00
Naxess
1de35f880b
Separate IssueList into own class
2021-05-12 01:23:31 +02:00
Naxess
d3c1ec55ee
Take IssueList in IssueSettings constructor
...
We'll be using this for bindables later.
2021-05-12 01:22:32 +02:00
Naxess
97bd482d4d
Factor out load from settings into new Settings class
2021-05-12 01:21:38 +02:00
Naxess
3e1b6b3b34
Simplify verifier run call args
...
Uses the resolved working beatmap instead of resolving it every time.
Also uses the EditorBeatmap itself as playable beatmap, as it is of type `IBeatmap` already, and `.PlayableBeatmap` forwards everything anyway.
2021-04-20 13:34:12 +02:00
Naxess
496df411a7
Remove now unused import
2021-04-20 02:39:11 +02:00
Naxess
0e6b66f457
Merge branch 'master' into bg-audio-quality-checks
2021-04-20 02:36:13 +02:00
Naxess
8656176ab8
Add the playable beatmap as check argument
...
This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor.
So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`.
This should be preferred over `workingBeatmap.Beatmap`.
2021-04-20 01:31:51 +02:00
Dean Herbert
e143afb598
Split out rounded content screen from SetupScreen for use in other places
2021-04-19 14:28:32 +09:00
Naxess
ef65c8910f
Fix resolved fields
2021-04-18 01:15:13 +02:00
Naxess
448574e7e6
Use WorkingBeatmap instead of IBeatmap
...
This lets us access things like the background, track, etc. which are necessary for quality and filesize checks.
Also improves the structure of the `CheckBackgroundTest` class in the process.
2021-04-17 17:33:53 +02:00
Dean Herbert
21e8e5fbca
Move common table layout logic into EditorTable abstract class
2021-04-13 23:26:19 +09:00
Dean Herbert
0edc1a850d
Split out common EditorTable base class
2021-04-13 23:05:58 +09:00
Dean Herbert
464fc02875
Fix some styling issues with the verify screen layout
2021-04-13 19:55:17 +09:00
Dean Herbert
03ba04e8ce
Split out general checks into its own verifier class (and remove static usage)
2021-04-13 19:50:22 +09:00
Naxess
60c2494b31
Make BeatmapVerifier an interface
2021-04-13 10:40:56 +02:00
Naxess
008dbc7dd6
Reverse IssueType ordering
...
Reversed both in the enum and where it's displayed, so ends up the same in the end.
2021-04-12 15:49:13 +02:00
Naxess
1c69829ad4
Fix Template.Origin -> Check
2021-04-12 15:47:58 +02:00
Naxess
a2fc9c398f
Rename CreateChecker -> CreateBeatmapVerifier
2021-04-12 10:08:30 +02:00
Naxess
65ebdd8f7a
Move check origin from IssueTemplate to Issue
...
As a result we can also make check an interface, and need to provide the check itself when constructing an issue.
2021-04-12 10:08:08 +02:00
Dean Herbert
8bf85d737c
Change Metadata into a get property
2021-04-12 15:52:29 +09:00
Dean Herbert
3551322f1d
Fix formatting of colour getter
2021-04-12 15:52:18 +09:00
Dean Herbert
1c553b5d48
Checker -> BeatmapVerifier
2021-04-12 15:29:05 +09:00
Naxess
7d40b01722
Remove old todo
2021-04-10 15:18:15 +02:00
Naxess
747e0f00dc
Improve table formatting
2021-04-10 13:10:05 +02:00
Naxess
3a4f2e3d7e
Show table even if no issues
2021-04-10 13:09:16 +02:00
Naxess
c995eca029
Remove todo
...
Doesn't really matter in the end, as only one checker will run at a time in this case.
2021-04-10 13:05:24 +02:00
Naxess
6d3cf78e4a
Add issue selection
...
This mainly helps with keeping track of which issue was clicked, since doing so switches tab.
2021-04-10 13:04:39 +02:00
Naxess
d1007ff26a
Move components to more appropriate spot
2021-04-10 13:02:22 +02:00
Naxess
43174b708c
Remove visibility settings
...
Can look into this later, not really important for a first iteration.
2021-04-10 12:58:40 +02:00
Naxess
bab36e529a
Update UI with new components
2021-04-07 14:38:43 +02:00
Naxess
b24ce66a0d
Add check/issue classes
2021-04-07 14:35:33 +02:00
Naxess
d58ef5310b
Add verify tab
...
Currently empty, but works.
2021-03-28 17:36:22 +02:00
