Dean Herbert
1dbcb5ab63
Add test coverage of intro fail scenario
2022-01-30 18:51:16 +09:00
Dean Herbert
04dbb5d3c6
Disallow setting "NoScores" externally as it is handled internally
2022-01-30 16:18:19 +09:00
Dean Herbert
acc1199add
Consolidate flows of Set operations, either result or error
2022-01-30 16:16:00 +09:00
Dean Herbert
c401629dd8
Also refactor placeholder logic to make more sense
2022-01-30 10:50:32 +09:00
Salman Ahmed
3ec193d47e
Fix spectator clock container incorrectly starting catch-up clock
2022-01-30 01:46:10 +03:00
Salman Ahmed
4f4f60248f
Add failing test case
2022-01-30 01:46:10 +03:00
Dean Herbert
b434e29a7c
Move loading hide operation inside early return to ensure not hidden too early
...
It should only be hidden after the async load completes.
2022-01-30 03:10:15 +09:00
Dean Herbert
dad9cc9315
Ensure Reset/Scores_Set run inline where possible
2022-01-30 03:06:29 +09:00
Dean Herbert
06660ff960
Fix null beatmap in test scene
2022-01-30 03:02:56 +09:00
Dean Herbert
9b573fbc2b
Add missing entries to switch statement and guard against out of range
2022-01-30 02:58:53 +09:00
Dean Herbert
d21464ea61
Fix assertions to work in both directions
2022-01-30 02:54:51 +09:00
Dean Herbert
d3cb910cf8
Convert inline math to not so inline to make operation more explicit
2022-01-30 02:37:01 +09:00
Dean Herbert
3d771c0fc7
Remove unnecessary loading hide call from PlaceholderState_Set and add more assertiveness
2022-01-30 02:34:31 +09:00
Dean Herbert
51acf79935
Change test exposure to property instead of method
2022-01-30 02:29:51 +09:00
Dean Herbert
9861c50b33
Remove pointless tests that no longer show anything valid
2022-01-30 00:03:22 +09:00
Dean Herbert
a915b9cd30
Fix occasional failures in TestSceneDeleteLocalScore
2022-01-29 23:58:57 +09:00
Dean Herbert
6f54f8ad78
Add more safety around CancellationToken usage
2022-01-29 23:58:57 +09:00
Dean Herbert
d0b74a91fb
Fix edge cases with score drawable loading
2022-01-29 23:58:57 +09:00
Dean Herbert
0293d95f82
Simplify IsOnlineScope usage
2022-01-29 23:58:57 +09:00
Dean Herbert
daea13f491
Simplify flow of cancellation token
2022-01-29 23:58:57 +09:00
Dean Herbert
3d59bab7c6
Remove fetch callback logic completely
2022-01-29 23:58:57 +09:00
Dean Herbert
13f445ddd5
Move score update code into own method
2022-01-29 23:58:57 +09:00
Dean Herbert
c48e9f2bbd
Remove more unnecessary schedule/cancel logic
2022-01-29 23:58:57 +09:00
Dean Herbert
a700ad3849
Remove scoresLoadedOnce weirdness
2022-01-29 23:58:57 +09:00
Dean Herbert
661fec7c8a
Make score setter private
2022-01-29 23:58:57 +09:00
Dean Herbert
b85b2c01fb
Reorder based on accessibility and add regions
2022-01-29 23:58:57 +09:00
Dean Herbert
c548658662
Remove move unused pieces
2022-01-29 23:58:57 +09:00
Dean Herbert
17aa9f3040
Remove pointless level of schedule/cancel logic
2022-01-29 23:58:57 +09:00
Dean Herbert
64925b3fea
Remove unused Content override
2022-01-29 23:58:57 +09:00
Dean Herbert
b9dac6c3b2
Reorder and tidy up bindable flows
2022-01-29 23:58:57 +09:00
Dean Herbert
aee93934d5
Rename methods to make more sense (and always run through AddOnce)
2022-01-29 23:58:57 +09:00
Dean Herbert
c6d303a5b4
Add xmldoc to Leaderboard class
2022-01-29 23:58:57 +09:00
Bartłomiej Dach
4132f67629
Merge pull request #16702 from peppy/fix-ef-migrations
...
Run EF migrations before migrating to realm
2022-01-29 15:40:26 +01:00
Dean Herbert
1a14ccc7ee
Run EF migrations before migrating to realm
...
Turns out that there are more than zero users that are upgrading from
old databases. I think we probably want to support this for now.
Tested against database in https://github.com/ppy/osu/discussions/16700
and one other I had locally, both work correctly.
2022-01-29 23:13:23 +09:00
Dean Herbert
d48fae1100
Revert "Remove all EF migrations"
...
This reverts commit bb5b9458e8
2022-01-29 23:13:23 +09:00
Bartłomiej Dach
0fc29c0e08
Merge pull request #16697 from peppy/fix-score-import-wrong-ruleset
...
Fix `SongSelect` incorrectly exposing decoupled ruleset to child screens
2022-01-29 13:31:35 +01:00
Dean Herbert
e7823982d8
Fix ruleset value not being transferred when FinaliseSelection is not called
2022-01-29 18:44:48 +09:00
Dean Herbert
4c97ed676f
Fix score presentation tests not correctly entering song select before running
2022-01-29 14:46:24 +09:00
Dean Herbert
b2ebcabdd5
Fix potential crash during stable install migration due to multiple configuration files
...
Apparently this can be a thing on windows.
Closes https://github.com/ppy/osu/discussions/16689 .
2022-01-29 13:30:07 +09:00
Bartłomiej Dach
1253e1ecc1
Replace LINQ Count() invocation with count property access
2022-01-28 20:25:12 +01:00
Dan Balasescu
3037a3a769
Purge final spectator frames before ending play
2022-01-28 22:26:05 +09:00
Dan Balasescu
397971c631
Change FrameDataBundle.Frames into an IList
2022-01-28 22:06:34 +09:00
Dan Balasescu
8883505eed
Merge pull request #16686 from peppy/fix-ar-on-old-maps
...
Fix approach rate not being transferred from OD on older beatmaps
2022-01-28 20:17:37 +09:00
Dan Balasescu
261cc6d031
Merge pull request #16687 from peppy/update-framework
...
Update framework
2022-01-28 20:17:23 +09:00
Dan Balasescu
bda3cdc9a7
Add tests
2022-01-28 19:29:30 +09:00
Dan Balasescu
4f2e98f3ef
Merge pull request #16683 from peppy/no-scope-test-lenience
...
Increase lenience of alpha check in `TestSceneOsuModNoScope`
2022-01-28 19:13:00 +09:00
Dean Herbert
53ca597e2b
Update framework
2022-01-28 19:12:32 +09:00
Dean Herbert
142a67e163
Fix approach rate not being transferred from OD on older beatmaps
2022-01-28 18:53:28 +09:00
Dean Herbert
17f0d7897b
Increase lenience of alpha check in TestSceneOsuModNoScope
...
I believe the [test
failures](https://github.com/ppy/osu/runs/4977283066?check_suite_focus=true )
we're seeing here are due to the implementation of interpolation of the
alpha being frame dependent (in a way that doesn't interact well with
tests). The reason for never hitting the expected value is that the
beatmap ends, causing the cursor to become fully visible again.
It's probably already good-enough for most cases, so let's attempt to
silence these test failures by not checking so precisely for the alpha
value.
We're checking for either 1 or 0 so it's not too important how close it
is to either.
2022-01-28 18:36:00 +09:00
Dan Balasescu
f021a274d2
Merge pull request #16681 from peppy/fix-delete-local-scores
...
Fix delete local scores via "Clear all scores" button crashing the game
2022-01-28 17:01:31 +09:00
