67615 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Xesquim	7dd18a84f6	Fixing the GetTotalDuration in PlaylistExtesions	2024-06-05 12:25:33 -03:00
Dean Herbert	318598730b	Merge pull request #26309 from OliBomby/grids-1 ... Add ability to change position, spacing, and rotation of the positional snap grid in the editor	2024-06-05 23:36:45 +09:00
Dean Herbert	212be6b9a7	Merge branch 'master' into grids-1	2024-06-05 15:20:04 +09:00
Dean Herbert	058d7aa7c1	Merge pull request #28388 from bdach/disable-primary-constructors ... Disable primary constructor related inspections	2024-06-05 01:13:49 +09:00
Bartłomiej Dach	442b61da84	Disable primary constructor related inspections ... I'm not actually sure whether the editorconfig incantation does anything but it's the one official sources give: https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0290	2024-06-04 15:14:56 +02:00
Dean Herbert	9f6ff48833	Merge pull request #28387 from bdach/taiko-selection-handler-is-slow ... Fix performance overhead from ternary state bindable callbacks when selection is changing	2024-06-04 18:51:10 +09:00
Bartłomiej Dach	ecfcf7a2c0	Add xmldoc mention about performance overhead of PerformOnSelection()	2024-06-04 10:36:30 +02:00
Bartłomiej Dach	f13ca28d5e	Fix performance overhead from ternary state bindable callbacks when selection is changing ... Closes https://github.com/ppy/osu/issues/28369. The reporter of the issue was incorrect; it's not the beat snap grid that is causing the problem, it's something far stupider than that. When the current selection changes, `EditorSelectionHandler.UpdateTernaryStates()` is supposed to update the state of ternary bindables to reflect the reality of the current selection. This in turn will fire bindable change callbacks for said ternary toggles, which heavily use `EditorBeatmap.PerformOnSelection()`. The thing about that method is that it will attempt to check whether any changes were actually made to avoid producing empty undo states, *but* to do this, it must *serialise out the entire beatmap to a stream* and then *binary equality check that* to determine whether any changes were actually made: 7b14c77e43/osu.Game/Screens/Edit/EditorChangeHandler.cs (L65-L69) As goes without saying, this is very expensive and unnecessary, which leads to stuff like keeping a selection box active while a taiko beatmap is playing under it dog slow. So to attempt to mitigate that, add precondition checks to every single ternary callback of this sort to avoid this serialisation overhead. And yes, those precondition checks use linq, and that is *still* faster than not having them.	2024-06-04 10:32:12 +02:00
Bartłomiej Dach	4fcb902341	Merge branch 'master' into grids-1	2024-06-03 12:33:51 +02:00
Bartłomiej Dach	7b14c77e43	Merge pull request #28383 from peppy/fix-main-menu-test-fail ... Fix occasional test failures on new menu content tests	2024-06-03 10:29:18 +02:00
Dean Herbert	96514132c1	Fix occasional test failures on new menu content tests ... Scheduled data transfer could still overwrite test data.	2024-06-03 12:24:56 +09:00
Dan Balasescu	8296e6318a	Merge pull request #28380 from peppy/ruleset-store-unavailable-but-why ... Fix `AssemblyRulesetStore` not marking rulesets as available	2024-06-02 20:28:28 +09:00
Dean Herbert	091104764e	Fix AssemblyRulesetStore not marking rulesets as available	2024-06-02 17:33:06 +09:00
Dean Herbert	f1689d542e	Merge pull request #28371 from smoogipoo/fix-collections-menu-drag ... Fix unable to drag-scroll on collections right-click menu	2024-06-01 19:16:14 +09:00
Dan Balasescu	e3205fce47	Fix unable to drag-scroll on collections right-click menu	2024-06-01 14:29:23 +09:00
Dean Herbert	4162d0babe	Merge pull request #28297 from Hecatia-Lapislazuli/near-straight-slider-crash-fix ... Fix for nearly straight sliders causing a crash	2024-05-31 20:00:47 +09:00
Bartłomiej Dach	b76ec9654d	Merge pull request #28363 from peppy/external-link-open-trusted ... Bypass external link dialog for links on the trusted osu! domain	2024-05-31 09:11:49 +02:00
Bartłomiej Dach	69990c35cb	Add commentary on presence of IsPresent override	2024-05-31 08:47:19 +02:00
Dean Herbert	c6a7082034	Fix incorrect prefix check	2024-05-31 15:38:26 +09:00
Aurelian	9111da81d2	Updated comments	2024-05-31 08:20:19 +02:00
Bartłomiej Dach	1a26a5dbda	Fix mismatching localisation key prefix ... The `Strings` suffix is not supposed to be in here, judging by other localisation classes.	2024-05-31 08:09:25 +02:00
Bartłomiej Dach	cb72630ce1	Fix compile failures	2024-05-31 08:09:06 +02:00
Dean Herbert	5dfeaa3c4a	Move dialog strings to more common class name	2024-05-31 11:46:32 +09:00
Dean Herbert	e52f524ea2	Use common header text	2024-05-31 11:44:53 +09:00
Dean Herbert	474ff5b99d	Use question mark for more grammatical correctness ... Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>	2024-05-31 10:46:30 +09:00
Dean Herbert	53b7c29488	Add test coverage of menu banner link opening	2024-05-31 03:15:26 +09:00
Dean Herbert	ed64bfff8d	Bypass external link dialog for links on the trusted osu! domain	2024-05-31 02:44:51 +09:00
Dean Herbert	87a331fdde	Improve text on external link warning dialog	2024-05-31 02:44:45 +09:00
Dean Herbert	8196c0026d	Merge pull request #28337 from bdach/catch-conversion-my-old-friend-ive-come-to-talk-to-you-again ... Remove rounding of slider velocity multiplier on juice streams	2024-05-30 22:16:54 +09:00
Dean Herbert	b46222db19	Merge pull request #28359 from smoogipoo/autopilot-resume-overlay ... Use delayed resume overlay for autopilot	2024-05-30 19:52:58 +09:00
Dan Balasescu	3c2599c50f	Merge pull request #27977 from DavidBeh/magnetised-judgements ... Make judgements follow hitcircles and enable them in magnetised, repel and depth	2024-05-30 19:21:20 +09:00
Dan Balasescu	f6a59bee9a	Use delayed resume overlay for autopilot	2024-05-30 19:17:18 +09:00
Dan Balasescu	981b69de2f	Merge pull request #28357 from peppy/dont-fail-acks ... Avoid `ChatAckRequest` failures flooding console in `OsuGameTestScene`s	2024-05-30 18:15:25 +09:00
Dean Herbert	f37546cc77	Merge pull request #28358 from bdach/fix-main-menu-button-bg ... Fix main menu button backgrounds not covering their entire width sometimes	2024-05-30 17:57:53 +09:00
Dean Herbert	f3bc944ac8	Remove using statement	2024-05-30 17:45:32 +09:00
Bartłomiej Dach	50bd0897f6	Fix main menu button backgrounds not covering their entire width sometimes ... I thought I had fixed this already once but it still looks broken. Basically when hovering over main menu buttons every now and then it will look like their backgrounds are not covering their entire width when they expand. The removed X position set looks wrong to me when inspecting the draw visualiser with the element because the element looks to be off centre horizontally, and removing it fixes that.	2024-05-30 10:38:22 +02:00
Dean Herbert	36d7775032	Fix typo in IAPIProvider xmldoc	2024-05-30 17:38:05 +09:00
Dean Herbert	2f2bc8e52e	Avoid ChatAckRequest failures flooding console in OsuGameTestScenes	2024-05-30 17:37:55 +09:00
Bartłomiej Dach	8916f08f86	Only take initial judgement position from object instead of following ... Looks less bad with mods like depth active. Co-authored-by: Dean Herbert <pe@ppy.sh>	2024-05-30 09:03:02 +02:00
Givikap120	f5d2c549cb	Update CatchPerformanceCalculator.cs	2024-05-29 19:25:58 +03:00
Dan Balasescu	0a7336ef17	Merge pull request #28349 from bdach/do-not-hardcode-api-version ... Derive API response version from game version	2024-05-29 21:35:19 +09:00
Bartłomiej Dach	ab01fa6d45	Add xmldoc to APIAccess.APIVersion	2024-05-29 14:10:07 +02:00
Bartłomiej Dach	cc13655617	Derive API response version from game version ... (Or local date, in the case of non-deployed builds). Came up when I was looking at https://github.com/ppy/osu-web/pull/11240 and found that we were still hardcoding this. Thankfully, this *should not* cause issues, since there don't seem to be any (documented or undocumented) API response version checks for versions newer than 20220705 in osu-web master. For clarity and possible debugging needs, the API response version is also logged.	2024-05-29 14:10:01 +02:00
Bartłomiej Dach	a6c776dac8	Use hopefully safer implementation of anchoring judgements to objects	2024-05-29 11:11:43 +02:00
Dan Balasescu	fa1da193ff	Merge pull request #28339 from bdach/fix-legacy-body-piece-animation-not-resetting-sometimes ... Fix legacy mania note body animation not resetting sometimes	2024-05-29 18:04:39 +09:00
Bartłomiej Dach	22a2adb5e6	Revert unrelated changes	2024-05-29 10:57:30 +02:00
Bartłomiej Dach	9fb7cc5900	Merge branch 'master' into magnetised-judgements	2024-05-29 10:56:53 +02:00
Bartłomiej Dach	bf7dc715de	Merge pull request #28309 from OliBomby/scale-tool ... Add precise scaling control to osu! editor	2024-05-29 10:52:00 +02:00
Bartłomiej Dach	84513343d6	Remove unused fields	2024-05-29 10:18:22 +02:00
Bartłomiej Dach	7b7e439d03	Merge branch 'master' into scale-tool	2024-05-29 10:15:48 +02:00