33663 Commits

This Branch

This Branch

All Branches

• Revert "Disable spectator streaming connection logic on iOS to avoid startup crash"

  This reverts commit c9b96a1829.

  Dean Herbert · 2020-11-04 14:27:13 +09:00
  1d90f5fc08
• Disable spectator streaming connection logic on iOS to avoid startup crash

  Due to an [issue](https://github.com/dotnet/runtime/issues/35988) at
  xamarin's end (which *should* have been fixed via [this
  pr](https://github.com/xamarin/xamarin-macios/pull/8615) but still fails
  on latest preview release) we can't support this just yet.

  Dean Herbert · 2020-11-02 15:52:58 +09:00
  c9b96a1829
• Merge pull request #10640 from bdach/fix-music-paused-on-multi-exit
  Dean Herbert · 2020-11-02 15:46:19 +09:00
  8adf146f53
• Merge pull request #10258 from Game4all/results-dynamic-pp-calc
  Dean Herbert · 2020-11-02 15:40:55 +09:00
  ab9e0aac58
• Merge pull request #10605 from peppy/spectator-replay-watcher

  Add screen hierarchy for spectating another player

  Dan Balasescu · 2020-11-02 15:29:59 +09:00
  2c51c24913
• Merge pull request #10654 from peppy/fix-taiko-editor-crash

  Fix taiko drum not correct handling sample / group point changes

  Dan Balasescu · 2020-11-02 15:26:09 +09:00
  c1a9a9082a
• Add matching requestedByUser parameter to Play method
  Dean Herbert · 2020-11-02 15:01:30 +09:00
  8f2cd0e8c5
• Change default value of requestedByUser to false
  Dean Herbert · 2020-11-02 14:56:50 +09:00
  d2f6303988
• Merge branch 'master' into fix-music-paused-on-multi-exit
  Dean Herbert · 2020-11-02 14:55:15 +09:00
  ecad85b5f5
• Merge branch 'master' into spectator-replay-watcher
  Dan Balasescu · 2020-11-02 14:54:51 +09:00
  04178e9458
• Add note about missing expiration logic
  Dean Herbert · 2020-11-02 14:53:32 +09:00
  7b320a991f
• Add xmldoc for new component
  Dean Herbert · 2020-11-02 14:50:44 +09:00
  d46f7535c9
• Remove unnecessary field storage
  Dean Herbert · 2020-11-02 14:49:25 +09:00
  fb105a1e9c
• Merge branch 'master' into results-dynamic-pp-calc
  Dean Herbert · 2020-11-02 14:47:33 +09:00
  73b290aca3
• Handle changes via SamplePoints list for simplicity
  Dean Herbert · 2020-11-02 14:40:40 +09:00
  3adf451e82
• Fix taiko drum not correct handling sample / group point changes

  Closes https://github.com/ppy/osu/issues/10642

  Dean Herbert · 2020-11-02 14:40:40 +09:00
  bfa6ae1b66
• Merge pull request #10615 from peppy/results-screen-applause

  Add applause effect to results screen

  Dan Balasescu · 2020-11-02 14:26:33 +09:00
  8d11b09efe
• Merge branch 'master' into results-screen-applause
  smoogipoo · 2020-11-02 13:38:19 +09:00
  bd7c3d0d9f
• Merge pull request #10619 from peppy/sample-lookup-improvements

  Change sample lookup structure to allow specifications outside of "Gameplay" prefix

  Dan Balasescu · 2020-11-02 13:36:07 +09:00
  db7f8a7322
• Merge branch 'master' into sample-lookup-improvements
  Dan Balasescu · 2020-11-02 13:04:35 +09:00
  1b53e6c782
• Merge pull request #10606 from FamousPig/fix-timeline-drag-select-weirdness

  Fix timeline zoom during drag-select causing unexpected behaviour

  Dan Balasescu · 2020-11-02 13:04:26 +09:00
  8a768669ad
• Merge pull request #10631 from bdach/shift-delete-all-selected
  Dean Herbert · 2020-11-02 12:04:58 +09:00
  6cfaee0f0b
• Merge pull request #10649 from ppy/dependabot/nuget/Microsoft.CodeAnalysis.FxCopAnalyzers-3.3.1
  Dean Herbert · 2020-11-02 11:52:38 +09:00
  6e2d722b8a
• Merge branch 'master' into fix-timeline-drag-select-weirdness
  Dan Balasescu · 2020-11-02 11:18:37 +09:00
  5ae3da9399
• Merge pull request #10653 from Joehuu/fix-resume-beatmap-options-edit

  Fix edit beatmap options button not resuming back to song select

  Dan Balasescu · 2020-11-02 11:18:15 +09:00
  836c3d3401
• Merge branch 'master' into dependabot/nuget/Microsoft.CodeAnalysis.FxCopAnalyzers-3.3.1
  Dean Herbert · 2020-11-02 10:56:09 +09:00
  61c9bb3245
• Merge pull request #10652 from ppy/dependabot/nuget/Microsoft.CodeAnalysis.BannedApiAnalyzers-3.3.1

  Bump Microsoft.CodeAnalysis.BannedApiAnalyzers from 3.3.0 to 3.3.1

  Dean Herbert · 2020-11-02 10:56:01 +09:00
  b048fbead4
• Merge pull request #10651 from ppy/dependabot/nuget/Microsoft.Build.Traversal-2.2.3

  Bump Microsoft.Build.Traversal from 2.1.1 to 2.2.3

  Dean Herbert · 2020-11-02 10:55:51 +09:00
  0d199616c3
• Merge branch 'master' into fix-resume-beatmap-options-edit
  Dan Balasescu · 2020-11-02 10:46:31 +09:00
  b1b52f9073
• Merge pull request #10623 from cadon0/fix-beatmap-details-metadata-bounce

  Fix "bounce" when metadata container text is empty in song select

  Dan Balasescu · 2020-11-02 10:45:14 +09:00
  ba726c6291
• Fix edit beatmap options button not resuming back to song select
  Joehu · 2020-11-01 13:50:38 -08:00
  71d55f16f3
• Use alternative solution to avoid storing last zoom
  Bartłomiej Dach · 2020-11-01 21:25:05 +01:00
  432282e8de
• Resolve more CA1805 inspections
  Bartłomiej Dach · 2020-11-01 20:51:23 +01:00
  164370bc7d
• Resolve CA2249 inspections

  "Use `string.Contains` instead of `string.IndexOf` to improve
  readability"

  Bartłomiej Dach · 2020-11-01 18:54:44 +01:00
  3090b6ccb5
• Resolve CA1835 inspection

  "Change the `ReadAsync` method call to use the
  `Stream.ReadAsync(Memory<byte>, CancellationToken)` overload"

  Bartłomiej Dach · 2020-11-01 18:51:39 +01:00
  89bf7b1bd6
• Resolve CA1834 inspection

  "Use `StringBuilder.Append(char)` instead of
  `StringBuilder.Append(string)` when the input is a constant unit string"

  Bartłomiej Dach · 2020-11-01 18:50:13 +01:00
  ca5de22ca5
• Resolve CA1805 inspections

  "Member is explicitly initialized to its default value"

  Bartłomiej Dach · 2020-11-01 18:47:40 +01:00
  2b0bea535e
• Bump Microsoft.CodeAnalysis.BannedApiAnalyzers from 3.3.0 to 3.3.1

  Bumps [Microsoft.CodeAnalysis.BannedApiAnalyzers](https://github.com/dotnet/roslyn-analyzers) from 3.3.0 to 3.3.1.
  - [Release notes](https://github.com/dotnet/roslyn-analyzers/releases)
  - [Changelog](https://github.com/dotnet/roslyn-analyzers/blob/master/PostReleaseActivities.md)
  - [Commits](https://github.com/dotnet/roslyn-analyzers/compare/v3.3.0...v3.3.1)
  
  Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

  dependabot-preview[bot] · 2020-11-01 17:15:23 +00:00
  79e610d31b
• Bump Microsoft.Build.Traversal from 2.1.1 to 2.2.3

  Bumps [Microsoft.Build.Traversal](https://github.com/Microsoft/MSBuildSdks) from 2.1.1 to 2.2.3.
  - [Release notes](https://github.com/Microsoft/MSBuildSdks/releases)
  - [Changelog](https://github.com/microsoft/MSBuildSdks/blob/master/RELEASE.md)
  - [Commits](https://github.com/Microsoft/MSBuildSdks/compare/Microsoft.Build.Traversal.2.1.1...Microsoft.Build.Traversal.2.2.3)
  
  Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

  dependabot-preview[bot] · 2020-11-01 17:14:57 +00:00
  6e9ed76251
• Bump Microsoft.CodeAnalysis.FxCopAnalyzers from 3.0.0 to 3.3.1

  Bumps [Microsoft.CodeAnalysis.FxCopAnalyzers](https://github.com/dotnet/roslyn-analyzers) from 3.0.0 to 3.3.1.
  - [Release notes](https://github.com/dotnet/roslyn-analyzers/releases)
  - [Changelog](https://github.com/dotnet/roslyn-analyzers/blob/master/PostReleaseActivities.md)
  - [Commits](https://github.com/dotnet/roslyn-analyzers/compare/v3.0.0...v3.3.1)
  
  Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

  dependabot-preview[bot] · 2020-11-01 17:14:13 +00:00
  6ff13e399a
• Ensure spectator player is unsubscribed to prevent leak
  Bartłomiej Dach · 2020-11-01 16:13:19 +01:00
  716458344f
• Merge branch 'master' into spectator-replay-watcher
  Bartłomiej Dach · 2020-11-01 15:53:37 +01:00
  23d9fa4dfa
• Merge pull request #10647 from bdach/beatmap-import-ensure-correct

  Ensure LoadOszIntoOsu returns actual imported map

  Dean Herbert · 2020-11-01 23:49:34 +09:00
  106bac1c6c
• Add more xmldocs
  Bartłomiej Dach · 2020-11-01 15:23:03 +01:00
  b7696c85ad
• Merge branch 'master' into shift-delete-all-selected
  Dean Herbert · 2020-11-01 23:03:01 +09:00
  1f8d627af4
• Merge pull request #10634 from bdach/fix-leftover-selection-box-tooltip

  Fix selection box action tooltips still being visible after object deletion

  Dean Herbert · 2020-11-01 23:02:29 +09:00
  e1b8875553
• Fix inaccurate xmldoc
  Bartłomiej Dach · 2020-11-01 14:39:10 +01:00
  5903c3be90
• Ensure LoadOszIntoOsu returns actual imported map
  Bartłomiej Dach · 2020-11-01 14:25:33 +01:00
  8a54fdd4e6
• Extract StatisticCounter to a separate class and use it instead.
  Lucas A · 2020-11-01 13:25:36 +01:00
  6bfff43634
• Merge branch 'master' into fix-beatmap-details-metadata-bounce
  Bartłomiej Dach · 2020-10-31 17:36:40 +01:00
  f3e0480e77