48566 Commits

This Branch

This Branch

All Branches

• Fix weird reading xmldoc

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-01-30 23:18:40 +09:00
  1cec76df74
• Disallow setting "NoScores" externally as it is handled internally
  Dean Herbert · 2022-01-30 16:18:19 +09:00
  04dbb5d3c6
• Consolidate flows of Set operations, either result or error
  Dean Herbert · 2022-01-30 16:16:00 +09:00
  acc1199add
• Also refactor placeholder logic to make more sense
  Dean Herbert · 2022-01-30 10:50:32 +09:00
  c401629dd8
• Move loading hide operation inside early return to ensure not hidden too early

  It should only be hidden after the async load completes.

  Dean Herbert · 2022-01-30 03:10:15 +09:00
  b434e29a7c
• Ensure Reset/Scores_Set run inline where possible
  Dean Herbert · 2022-01-30 03:06:29 +09:00
  dad9cc9315
• Fix null beatmap in test scene
  Dean Herbert · 2022-01-30 03:02:56 +09:00
  06660ff960
• Add missing entries to switch statement and guard against out of range
  Dean Herbert · 2022-01-30 02:58:53 +09:00
  9b573fbc2b
• Fix assertions to work in both directions
  Dean Herbert · 2022-01-30 02:54:51 +09:00
  d21464ea61
• Convert inline math to not so inline to make operation more explicit
  Dean Herbert · 2022-01-30 02:37:01 +09:00
  d3cb910cf8
• Remove unnecessary loading hide call from PlaceholderState_Set and add more assertiveness
  Dean Herbert · 2022-01-30 02:34:31 +09:00
  3d771c0fc7
• Change test exposure to property instead of method
  Dean Herbert · 2022-01-30 02:29:51 +09:00
  51acf79935
• Remove pointless tests that no longer show anything valid
  Dean Herbert · 2022-01-30 00:03:22 +09:00
  9861c50b33
• Fix occasional failures in TestSceneDeleteLocalScore
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  a915b9cd30
• Add more safety around CancellationToken usage
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  6f54f8ad78
• Fix edge cases with score drawable loading
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  d0b74a91fb
• Simplify IsOnlineScope usage
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  0293d95f82
• Simplify flow of cancellation token
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  daea13f491
• Remove fetch callback logic completely
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  3d59bab7c6
• Move score update code into own method
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  13f445ddd5
• Remove more unnecessary schedule/cancel logic
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  c48e9f2bbd
• Remove scoresLoadedOnce weirdness
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  a700ad3849
• Make score setter private
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  661fec7c8a
• Reorder based on accessibility and add regions
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  b85b2c01fb
• Remove move unused pieces
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  c548658662
• Remove pointless level of schedule/cancel logic
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  17aa9f3040
• Remove unused Content override
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  64925b3fea
• Reorder and tidy up bindable flows
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  b9dac6c3b2
• Rename methods to make more sense (and always run through AddOnce)
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  aee93934d5
• Add xmldoc to Leaderboard class
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  c6d303a5b4
• Merge pull request #16702 from peppy/fix-ef-migrations

  Run EF migrations before migrating to realm

  Bartłomiej Dach · 2022-01-29 15:40:26 +01:00
  4132f67629
• Run EF migrations before migrating to realm

  Turns out that there are more than zero users that are upgrading from
  old databases. I think we probably want to support this for now.
  
  Tested against database in https://github.com/ppy/osu/discussions/16700
  and one other I had locally, both work correctly.

  Dean Herbert · 2022-01-29 23:13:23 +09:00
  1a14ccc7ee
• Revert "Remove all EF migrations"

  This reverts commit bb5b9458e8.

  Dean Herbert · 2022-01-29 23:13:23 +09:00
  d48fae1100
• Merge pull request #16697 from peppy/fix-score-import-wrong-ruleset

  Fix `SongSelect` incorrectly exposing decoupled ruleset to child screens

  Bartłomiej Dach · 2022-01-29 13:31:35 +01:00
  0fc29c0e08
• Fix ruleset value not being transferred when FinaliseSelection is not called
  Dean Herbert · 2022-01-29 18:44:48 +09:00
  e7823982d8
• Fix score presentation tests not correctly entering song select before running
  Dean Herbert · 2022-01-29 14:46:24 +09:00
  4c97ed676f
• Merge pull request #16686 from peppy/fix-ar-on-old-maps

  Fix approach rate not being transferred from OD on older beatmaps

  Dan Balasescu · 2022-01-28 20:17:37 +09:00
  8883505eed
• Merge pull request #16687 from peppy/update-framework

  Update framework

  Dan Balasescu · 2022-01-28 20:17:23 +09:00
  261cc6d031
• Add tests
  Dan Balasescu · 2022-01-28 19:29:30 +09:00
  bda3cdc9a7
• Merge pull request #16683 from peppy/no-scope-test-lenience

  Increase lenience of alpha check in `TestSceneOsuModNoScope`

  Dan Balasescu · 2022-01-28 19:13:00 +09:00
  4f2e98f3ef
• Update framework
  Dean Herbert · 2022-01-28 19:12:32 +09:00
  53ca597e2b
• Fix approach rate not being transferred from OD on older beatmaps
  Dean Herbert · 2022-01-28 18:53:28 +09:00
  142a67e163
• Increase lenience of alpha check in TestSceneOsuModNoScope

  I believe the [test
  failures](https://github.com/ppy/osu/runs/4977283066?check_suite_focus=true)
  we're seeing here are due to the implementation of interpolation of the
  alpha being frame dependent (in a way that doesn't interact well with
  tests). The reason for never hitting the expected value is that the
  beatmap ends, causing the cursor to become fully visible again.
  
  It's probably already good-enough for most cases, so let's attempt to
  silence these test failures by not checking so precisely for the alpha
  value.
  
  We're checking for either 1 or 0 so it's not too important how close it
  is to either.

  Dean Herbert · 2022-01-28 18:36:00 +09:00
  17f0d7897b
• Merge pull request #16681 from peppy/fix-delete-local-scores

  Fix delete local scores via "Clear all scores" button crashing the game

  Dan Balasescu · 2022-01-28 17:01:31 +09:00
  f021a274d2
• Merge pull request #16676 from peppy/fix-editor-custom-ruleset

  Fix editor crashing on custom rulesets due to `ChangeHandler` not being supported

  Dan Balasescu · 2022-01-28 16:26:56 +09:00
  bdc9ca40f2
• Merge pull request #16673 from peppy/fix-polling-component-thread-safety

  Fix occasional non-fatal errors from polling API requests incorrectly getting queued twice

  Dan Balasescu · 2022-01-28 16:26:47 +09:00
  c7f8528d63
• Merge pull request #16678 from peppy/hold-for-menu-always-fade

  Ensure hold for menu button fades out if the cursor is never moved

  Dan Balasescu · 2022-01-28 15:55:41 +09:00
  b94984bd2d
• Fix delete local scores crashing the game
  Dean Herbert · 2022-01-28 15:54:53 +09:00
  0d3ac4fd9c
• Add test coverage of the same thing but via "clear all scores" button
  Dean Herbert · 2022-01-28 15:54:53 +09:00
  2453bf5ed0
• Add test coverage of local score import and deletion
  Dean Herbert · 2022-01-28 15:50:36 +09:00
  778eebc94d