43705 Commits

Author	SHA1	Message	Date
OliBomby	1ce9e97fd4	add arrow indicator	2024-08-20 23:38:38 +02:00
OliBomby	ae6d855f8d	Merge remote-tracking branch 'upstream/master' into doubleclick	2024-08-20 23:19:27 +02:00
Dan Balasescu	5bb94000d3	Merge pull request #29534 from bdach/fix-divisor-crash ... Fix crash on attempting to edit particular beatmaps	2024-08-20 22:06:32 +09:00
Dan Balasescu	44213a34ae	Merge pull request #29508 from peppy/hold-for-menu-sometimes ... Change "hold for menu" button to only show for touch by default	2024-08-20 21:45:50 +09:00
Bartłomiej Dach	c2dd2ad978	Clamp beat divisor to sane range when decoding ... In my view this is a nice change, but do note that on its own it does nothing to fix https://github.com/ppy/osu/issues/29492, because of `BeatmapInfo` reference management foibles when opening the editor. See also: https://github.com/ppy/osu/issues/20883#issuecomment-1288149271, https://github.com/ppy/osu/pull/28473.	2024-08-20 13:52:29 +02:00
Bartłomiej Dach	bb964e32fa	Fix crash on attempting to edit particular beatmaps ... Closes https://github.com/ppy/osu/issues/29492. I'm not immediately sure why this happened, but some old locally modified beatmaps in my local realm database have a `BeatDivisor` of 0 stored, which is then passed to `BindableBeatDivisor.SetArbitraryDivisor()`, which then blows up. To stop this from happening, just refuse to use values outside of a sane range.	2024-08-20 13:51:58 +02:00
Bartłomiej Dach	f0ddb6daa4	Merge pull request #29445 from OliBomby/transparent-break ... Make break periods in bottom timeline transparent	2024-08-20 11:46:02 +02:00
Dean Herbert	bccc797bcb	Move break display to background of summary timeline	2024-08-20 17:45:44 +09:00
Bartłomiej Dach	373ff47a94	Remove dead row attribute classes ... These aren't shown on the control point table since difficulty and sample control points were moved into objects.	2024-08-20 09:53:40 +02:00
Dean Herbert	6985e2e657	Increase default visibility on touch platforms	2024-08-19 20:32:05 +09:00
Dean Herbert	005b1038a3	Change "hold for menu" button to only show for touch by default	2024-08-19 20:23:25 +09:00
Bartłomiej Dach	24a0a3c47f	Merge pull request #29476 from EVAST9919/buffered-editor-grid ... Improve draw performance of editor grids	2024-08-19 12:44:08 +02:00
Dan Balasescu	03188e40ee	Merge pull request #29504 from peppy/skin-editor-fix-sidebar-reload ... Fix skin editor components sidebar not reloading when changing skins	2024-08-19 18:13:52 +09:00
Dan Balasescu	c18f7a239c	Merge pull request #29474 from peppy/fix-legacy-combo-counter-animation-dead ... Fix legacy combo counter bounce animation not always playing	2024-08-19 18:09:57 +09:00
Dean Herbert	1bd2f4c6a2	Fix skin editor components sidebar not reloading when changing skins ... Closes https://github.com/ppy/osu/issues/29098.	2024-08-19 15:45:18 +09:00
Dean Herbert	4a3f4c3a55	Don't duck music when effect volume is set to zero ... Addresses https://github.com/ppy/osu/discussions/28984.	2024-08-19 14:46:50 +09:00
Dean Herbert	e75ae4a37b	More hardening of TestMultiplayerClient to attempt to fix test failures	2024-08-19 04:04:24 +09:00
Joseph Madamba	6dd08e9a96	Fix beatmap carousel panels not blocking hover of other panels in song select	2024-08-17 11:45:54 -07:00
Andrei Zavatski	3cd5820b5b	Make PositionSnapGrid a BufferedContainer	2024-08-17 10:34:39 +03:00
Dean Herbert	04a2d67ca4	Fix legacy combo counter bounce animation not always playing ... As mentioned [in discord](https://discord.com/channels/188630481301012481/1097318920991559880/1274231995261649006).	2024-08-17 15:13:44 +09:00
Andrei Zavatski	f74263db81	Remove extra box in OnlinePlayBackgroundScreen	2024-08-17 01:01:51 +03:00
Dean Herbert	d1d195cf18	Fix incorrect skin lookup shortcutting causing sprites to no longer work	2024-08-17 02:33:52 +09:00
OliBomby	5624c1d304	Make break periods in bottom timeline transparent	2024-08-16 13:22:09 +02:00
Joseph Madamba	e2bf02cf94	Fix preview play button having incorrect click area	2024-08-15 22:49:12 -07:00
Joseph Madamba	fda17a5a72	Expose BeatmapCardNormal height const	2024-08-15 22:49:12 -07:00
Dan Balasescu	52c1858bbe	Merge pull request #29428 from peppy/update-editor-menu-items-difficulty-change ... Ensure the "Change Difficulty" menu uses up-to-date difficulty names	2024-08-16 00:44:59 +09:00
Dean Herbert	5710f0f302	Merge pull request #26254 from frenzibyte/mania-combo-counter ... Add argon/classic osu!mania combo counter	2024-08-15 17:56:28 +09:00
Dean Herbert	b5f615882f	Ensure the "Change Difficulty" menu uses up-to-date difficulty names ... Closes https://github.com/ppy/osu/issues/29391.	2024-08-15 17:25:30 +09:00
Dean Herbert	4b279ecaa8	Fix mistake	2024-08-15 16:44:15 +09:00
Dean Herbert	26da2c0637	Update MultiplayerClient test output with new knowledge	2024-08-15 16:16:48 +09:00
Dean Herbert	9dc496d6a7	Merge pull request #29415 from Joehuu/difficulty-name-content ... Implement song select v2 difficulty name content component	2024-08-15 15:20:52 +09:00
Salman Ahmed	3a4546d62d	Remove x symbol from argon mania combo counter	2024-08-15 15:08:35 +09:00
Dean Herbert	054366b25d	Use zero baseline for legacy sprite text display	2024-08-15 13:07:42 +09:00
Dan Balasescu	8bfb5cedc4	Merge pull request #29406 from peppy/fix-skin-change-crash ... Fix crash on changing skins when classic mod is enabled and game is rewound	2024-08-15 01:04:32 +09:00
Dean Herbert	28ab65243d	Remove daily challenge tooltip from main menu ... Now that we have a nice intro screen for the daily challenge, it's generally thought that we want to "spoil" the beatmap until the intro is shown. Also I was never a huge fan of having a tooltip on a main menu button.. just feels a bit odd.	2024-08-14 20:45:27 +09:00
Dean Herbert	58d9a4adba	Merge pull request #29414 from smoogipoo/fix-daily-challenge-2 ... Add localisation for daily challenge day/week units	2024-08-14 18:45:12 +09:00
Joseph Madamba	11bd0c9a61	Inline single-frame layout issue comment instead	2024-08-14 00:41:43 -07:00
Joseph Madamba	c24f1444f9	Directly resolve IBindable<WorkingBeatmap> by making a local variant of DifficultyNameContent	2024-08-13 23:26:18 -07:00
Joseph Madamba	2b41f71fd0	Workaround single-frame layout issues with {Link|Text|Fill}FlowContainers	2024-08-13 23:26:17 -07:00
Joseph Madamba	625c6fc7eb	Implement song select v2 difficulty name content component	2024-08-13 23:26:17 -07:00
Dean Herbert	e465049050	Merge branch 'master' into mania-combo-counter	2024-08-14 15:12:00 +09:00
Dan Balasescu	f882ad4a53	Add localisation for daily challenge day/week units	2024-08-14 15:10:55 +09:00
Dean Herbert	78ef436ea0	Update test debug output to test second scenario	2024-08-14 12:23:47 +09:00
Dean Herbert	2221c4891f	Remove legacy non-pooled pathway to DrawableJudgement	2024-08-13 21:03:00 +09:00
Dean Herbert	bb0c9e2497	Add log output when judgements aren't being pooled	2024-08-13 20:57:23 +09:00
Dean Herbert	d74ac57092	Never call prepareDrawables from unsafe context ... I can't mentally figure out *what* is causing the issue here, but in the case where `prepareDrawables` is called from `JudgementBody.OnSkinChanged` (only happens in a non-pooled scenario), things go very wrong. I think a smell test is enough for anyone to agree that the flow was very bad. Removing this call doesn't seem to cause any issues. `runAnimation` should always be called in `PrepareForUse` (both pooled and non-pooled scenarios) so things should still always be in a correct state. Closes #29398.	2024-08-13 20:57:20 +09:00
Salman Ahmed	c9b2a5bb9c	Fix user profile overlay colour resetting when changing rulesets	2024-08-13 13:03:31 +03:00
Dan Balasescu	513a666847	Merge pull request #29401 from CloneWith/patch/wiki-locale ... Automatically use in-game language for wiki pages	2024-08-13 17:18:29 +09:00
Dan Balasescu	3f02869bcc	Enable NRT while we're here	2024-08-13 16:08:06 +09:00
Dan Balasescu	4b4f0ecf7d	Merge pull request #29342 from cl8n/remove-mania-action-special ... Remove "Special" `ManiaAction`s for center columns	2024-08-13 15:36:36 +09:00